diff options
| author | Matt A. Tobin <email@mattatobin.com> | 2019-11-10 19:11:03 -0500 |
|---|---|---|
| committer | Matt A. Tobin <email@mattatobin.com> | 2019-11-10 19:11:03 -0500 |
| commit | 201683afe4596ae32f7b1ea12dfca52995d59f9d (patch) | |
| tree | 8632173f59a85d1c3bf679653de7957a59c96eae /mailnews/import/src | |
| parent | 4db1ae892bad565e8e59ec6034b4c98946077248 (diff) | |
| download | UXP-201683afe4596ae32f7b1ea12dfca52995d59f9d.tar UXP-201683afe4596ae32f7b1ea12dfca52995d59f9d.tar.gz UXP-201683afe4596ae32f7b1ea12dfca52995d59f9d.tar.lz UXP-201683afe4596ae32f7b1ea12dfca52995d59f9d.tar.xz UXP-201683afe4596ae32f7b1ea12dfca52995d59f9d.zip | |
Bug 1487082 - Resolve potential for build bustage regarding bad implicit conversion constructors
* Part 1: make conversion CTORs explicit.
Minor tweaks to conform with new(ish) static analysis rule which flags up implicit single-argument conversion constructors.
* Part 2: fix a couple of double-mRefCnt declaration errors.
* Part 3: Fix unsafe use of NS_ConvertASCIItoUTF16().
Tag #1273
Diffstat (limited to 'mailnews/import/src')
| -rw-r--r-- | mailnews/import/src/nsImportFieldMap.h | 2 | ||||
| -rw-r--r-- | mailnews/import/src/nsImportMail.cpp | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/mailnews/import/src/nsImportFieldMap.h b/mailnews/import/src/nsImportFieldMap.h index a25069b1e..314abd800 100644 --- a/mailnews/import/src/nsImportFieldMap.h +++ b/mailnews/import/src/nsImportFieldMap.h @@ -24,7 +24,7 @@ public: NS_DECL_NSIIMPORTFIELDMAP - nsImportFieldMap(nsIStringBundle *aBundle); + explicit nsImportFieldMap(nsIStringBundle *aBundle); static NS_METHOD Create(nsIStringBundle *aBundle, nsISupports *aOuter, REFNSIID aIID, void **aResult); diff --git a/mailnews/import/src/nsImportMail.cpp b/mailnews/import/src/nsImportMail.cpp index ad584b8a6..9e0f6bcd2 100644 --- a/mailnews/import/src/nsImportMail.cpp +++ b/mailnews/import/src/nsImportMail.cpp @@ -993,7 +993,7 @@ bool nsImportGenericMail::CreateFolder(nsIMsgFolder **ppFolder) class GetSubFoldersRunnable : public mozilla::Runnable { public: - GetSubFoldersRunnable(nsIMsgFolder *aFolder); + explicit GetSubFoldersRunnable(nsIMsgFolder *aFolder); NS_DECL_NSIRUNNABLE private: nsCOMPtr<nsIMsgFolder> m_folder; @@ -1182,7 +1182,7 @@ nsresult ProxyCreateSubfolder(nsIMsgFolder *aFolder, const nsAString &aName) class ForceDBClosedRunnable : public mozilla::Runnable { public: - ForceDBClosedRunnable(nsIMsgFolder *aFolder); + explicit ForceDBClosedRunnable(nsIMsgFolder *aFolder); NS_DECL_NSIRUNNABLE protected: nsCOMPtr<nsIMsgFolder> m_folder; |