From 201683afe4596ae32f7b1ea12dfca52995d59f9d Mon Sep 17 00:00:00 2001 From: "Matt A. Tobin" Date: Sun, 10 Nov 2019 19:11:03 -0500 Subject: Bug 1487082 - Resolve potential for build bustage regarding bad implicit conversion constructors * Part 1: make conversion CTORs explicit. Minor tweaks to conform with new(ish) static analysis rule which flags up implicit single-argument conversion constructors. * Part 2: fix a couple of double-mRefCnt declaration errors. * Part 3: Fix unsafe use of NS_ConvertASCIItoUTF16(). Tag #1273 --- mailnews/import/src/nsImportFieldMap.h | 2 +- mailnews/import/src/nsImportMail.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'mailnews/import/src') diff --git a/mailnews/import/src/nsImportFieldMap.h b/mailnews/import/src/nsImportFieldMap.h index a25069b1e..314abd800 100644 --- a/mailnews/import/src/nsImportFieldMap.h +++ b/mailnews/import/src/nsImportFieldMap.h @@ -24,7 +24,7 @@ public: NS_DECL_NSIIMPORTFIELDMAP - nsImportFieldMap(nsIStringBundle *aBundle); + explicit nsImportFieldMap(nsIStringBundle *aBundle); static NS_METHOD Create(nsIStringBundle *aBundle, nsISupports *aOuter, REFNSIID aIID, void **aResult); diff --git a/mailnews/import/src/nsImportMail.cpp b/mailnews/import/src/nsImportMail.cpp index ad584b8a6..9e0f6bcd2 100644 --- a/mailnews/import/src/nsImportMail.cpp +++ b/mailnews/import/src/nsImportMail.cpp @@ -993,7 +993,7 @@ bool nsImportGenericMail::CreateFolder(nsIMsgFolder **ppFolder) class GetSubFoldersRunnable : public mozilla::Runnable { public: - GetSubFoldersRunnable(nsIMsgFolder *aFolder); + explicit GetSubFoldersRunnable(nsIMsgFolder *aFolder); NS_DECL_NSIRUNNABLE private: nsCOMPtr m_folder; @@ -1182,7 +1182,7 @@ nsresult ProxyCreateSubfolder(nsIMsgFolder *aFolder, const nsAString &aName) class ForceDBClosedRunnable : public mozilla::Runnable { public: - ForceDBClosedRunnable(nsIMsgFolder *aFolder); + explicit ForceDBClosedRunnable(nsIMsgFolder *aFolder); NS_DECL_NSIRUNNABLE protected: nsCOMPtr m_folder; -- cgit v1.2.3