diff options
| author | Matt A. Tobin <email@mattatobin.com> | 2019-11-10 19:11:03 -0500 |
|---|---|---|
| committer | Matt A. Tobin <email@mattatobin.com> | 2019-11-10 19:11:03 -0500 |
| commit | 201683afe4596ae32f7b1ea12dfca52995d59f9d (patch) | |
| tree | 8632173f59a85d1c3bf679653de7957a59c96eae /mailnews/addrbook/src/nsAbUtils.h | |
| parent | 4db1ae892bad565e8e59ec6034b4c98946077248 (diff) | |
| download | UXP-201683afe4596ae32f7b1ea12dfca52995d59f9d.tar UXP-201683afe4596ae32f7b1ea12dfca52995d59f9d.tar.gz UXP-201683afe4596ae32f7b1ea12dfca52995d59f9d.tar.lz UXP-201683afe4596ae32f7b1ea12dfca52995d59f9d.tar.xz UXP-201683afe4596ae32f7b1ea12dfca52995d59f9d.zip | |
Bug 1487082 - Resolve potential for build bustage regarding bad implicit conversion constructors
* Part 1: make conversion CTORs explicit.
Minor tweaks to conform with new(ish) static analysis rule which flags up implicit single-argument conversion constructors.
* Part 2: fix a couple of double-mRefCnt declaration errors.
* Part 3: Fix unsafe use of NS_ConvertASCIItoUTF16().
Tag #1273
Diffstat (limited to 'mailnews/addrbook/src/nsAbUtils.h')
| -rw-r--r-- | mailnews/addrbook/src/nsAbUtils.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/mailnews/addrbook/src/nsAbUtils.h b/mailnews/addrbook/src/nsAbUtils.h index d6b8915e0..c50ba4d0d 100644 --- a/mailnews/addrbook/src/nsAbUtils.h +++ b/mailnews/addrbook/src/nsAbUtils.h @@ -15,7 +15,7 @@ class CharPtrArrayGuard { public: - CharPtrArrayGuard (bool freeElements = true) : + explicit CharPtrArrayGuard (bool freeElements = true) : mFreeElements (freeElements), mArray (0), mSize (0) @@ -80,7 +80,7 @@ private: class PRUnicharPtrArrayGuard { public: - PRUnicharPtrArrayGuard (bool freeElements = true) : + explicit PRUnicharPtrArrayGuard (bool freeElements = true) : mFreeElements (freeElements), mArray (0), mSize (0) |