summaryrefslogtreecommitdiffstats
path: root/dom/html/HTMLSelectElement.cpp
diff options
context:
space:
mode:
authorMatt A. Tobin <email@mattatobin.com>2020-04-16 19:59:10 -0400
committerMatt A. Tobin <email@mattatobin.com>2020-04-16 19:59:10 -0400
commit2f59167e65132fc652456ae8629c1246a9b4b2cb (patch)
treed6f5779a031f2c957612dd4f0dd0d6ee166f9a8b /dom/html/HTMLSelectElement.cpp
parent4630e4abb531e416f8153846d422794de20261bd (diff)
downloadUXP-2f59167e65132fc652456ae8629c1246a9b4b2cb.tar
UXP-2f59167e65132fc652456ae8629c1246a9b4b2cb.tar.gz
UXP-2f59167e65132fc652456ae8629c1246a9b4b2cb.tar.lz
UXP-2f59167e65132fc652456ae8629c1246a9b4b2cb.tar.xz
UXP-2f59167e65132fc652456ae8629c1246a9b4b2cb.zip
Bug 656197 - Push state updates further out across beforesetattr/aftersetattr
* Remove the generic attr preparsing mechanism from BeforeSetAttr and just preparse class attributes directly in the one place that needs to do it * Move calls to BeforeSetAttr to after AttributeWillChange * Remove UpdateState calls in BeforeSetAttr * Move calls to AfterSetAttr to before UpdateState when manipulating attributes * Remove UpdateState calls from AfterSetAttr, since they are no longer needed there Tag #1375
Diffstat (limited to 'dom/html/HTMLSelectElement.cpp')
-rw-r--r--dom/html/HTMLSelectElement.cpp4
1 files changed, 1 insertions, 3 deletions
diff --git a/dom/html/HTMLSelectElement.cpp b/dom/html/HTMLSelectElement.cpp
index 272a16578..a5f88f3fb 100644
--- a/dom/html/HTMLSelectElement.cpp
+++ b/dom/html/HTMLSelectElement.cpp
@@ -1269,7 +1269,7 @@ HTMLSelectElement::UnbindFromTree(bool aDeep, bool aNullParent)
nsresult
HTMLSelectElement::BeforeSetAttr(int32_t aNameSpaceID, nsIAtom* aName,
- nsAttrValueOrString* aValue,
+ const nsAttrValueOrString* aValue,
bool aNotify)
{
if (aNotify && aName == nsGkAtoms::disabled &&
@@ -1294,8 +1294,6 @@ HTMLSelectElement::AfterSetAttr(int32_t aNameSpaceID, nsIAtom* aName,
// Clear the cached @autocomplete attribute state
mAutocompleteAttrState = nsContentUtils::eAutocompleteAttrState_Unknown;
}
-
- UpdateState(aNotify);
}
return nsGenericHTMLFormElementWithState::AfterSetAttr(aNameSpaceID, aName,