summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorOlli Pettay <Olli.Pettay@helsinki.fi>2019-03-21 09:02:04 +0100
committerwolfbeast <mcwerewolf@wolfbeast.com>2019-03-21 09:02:04 +0100
commit85e33523c3683fdb8a3fd45f8c317fb30d8ca8a4 (patch)
tree3e9f643bc3cef8f9aefe74beb0bf2a7cbae6867b
parenta36c3f69c82e1a38b43f0c5f36c562fb08615c62 (diff)
downloadUXP-85e33523c3683fdb8a3fd45f8c317fb30d8ca8a4.tar
UXP-85e33523c3683fdb8a3fd45f8c317fb30d8ca8a4.tar.gz
UXP-85e33523c3683fdb8a3fd45f8c317fb30d8ca8a4.tar.lz
UXP-85e33523c3683fdb8a3fd45f8c317fb30d8ca8a4.tar.xz
UXP-85e33523c3683fdb8a3fd45f8c317fb30d8ca8a4.zip
Remove harmless assertions by using IgnoredErrorResult.
-rw-r--r--dom/html/HTMLTableElement.cpp15
-rw-r--r--dom/html/HTMLTableSectionElement.cpp2
2 files changed, 7 insertions, 10 deletions
diff --git a/dom/html/HTMLTableElement.cpp b/dom/html/HTMLTableElement.cpp
index ec1b7cecb..c5b7696cf 100644
--- a/dom/html/HTMLTableElement.cpp
+++ b/dom/html/HTMLTableElement.cpp
@@ -421,11 +421,10 @@ HTMLTableElement::CreateTHead()
void
HTMLTableElement::DeleteTHead()
{
- HTMLTableSectionElement* tHead = GetTHead();
+ RefPtr<HTMLTableSectionElement> tHead = GetTHead();
if (tHead) {
- mozilla::ErrorResult rv;
+ mozilla::IgnoredErrorResult rv;
nsINode::RemoveChild(*tHead, rv);
- MOZ_ASSERT(!rv.Failed());
}
}
@@ -452,11 +451,10 @@ HTMLTableElement::CreateTFoot()
void
HTMLTableElement::DeleteTFoot()
{
- HTMLTableSectionElement* tFoot = GetTFoot();
+ RefPtr<HTMLTableSectionElement> tFoot = GetTFoot();
if (tFoot) {
- mozilla::ErrorResult rv;
+ mozilla::IgnoredErrorResult rv;
nsINode::RemoveChild(*tFoot, rv);
- MOZ_ASSERT(!rv.Failed());
}
}
@@ -483,11 +481,10 @@ HTMLTableElement::CreateCaption()
void
HTMLTableElement::DeleteCaption()
{
- HTMLTableCaptionElement* caption = GetCaption();
+ RefPtr<HTMLTableCaptionElement> caption = GetCaption();
if (caption) {
- mozilla::ErrorResult rv;
+ mozilla::IgnoredErrorResult rv;
nsINode::RemoveChild(*caption, rv);
- MOZ_ASSERT(!rv.Failed());
}
}
diff --git a/dom/html/HTMLTableSectionElement.cpp b/dom/html/HTMLTableSectionElement.cpp
index c7b0665dd..e99597636 100644
--- a/dom/html/HTMLTableSectionElement.cpp
+++ b/dom/html/HTMLTableSectionElement.cpp
@@ -122,7 +122,7 @@ HTMLTableSectionElement::DeleteRow(int32_t aValue, ErrorResult& aError)
refIndex = (uint32_t)aValue;
}
- nsINode* row = rows->Item(refIndex);
+ nsCOMPtr<nsINode> row = rows->Item(refIndex);
if (!row) {
aError.Throw(NS_ERROR_DOM_INDEX_SIZE_ERR);
return;