summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPetr Mrázek <peterix@gmail.com>2017-05-01 12:55:10 +0200
committerPetr Mrázek <peterix@gmail.com>2017-05-01 12:55:10 +0200
commitb20688a18d57b43e90ae6f219eef34c5ffa99c96 (patch)
treeaa190ef7c3c053f5175525e9bc36e19b77f5d84c
parent21df531db1935f6b01411a729e3f45b634f6d9c9 (diff)
downloadMultiMC-b20688a18d57b43e90ae6f219eef34c5ffa99c96.tar
MultiMC-b20688a18d57b43e90ae6f219eef34c5ffa99c96.tar.gz
MultiMC-b20688a18d57b43e90ae6f219eef34c5ffa99c96.tar.lz
MultiMC-b20688a18d57b43e90ae6f219eef34c5ffa99c96.tar.xz
MultiMC-b20688a18d57b43e90ae6f219eef34c5ffa99c96.zip
GH-1875 plug holes in instance/window refcount logic
-rw-r--r--application/MultiMC.cpp3
1 files changed, 1 insertions, 2 deletions
diff --git a/application/MultiMC.cpp b/application/MultiMC.cpp
index bac81f8f..833efc06 100644
--- a/application/MultiMC.cpp
+++ b/application/MultiMC.cpp
@@ -965,8 +965,8 @@ bool MultiMC::launch(InstancePtr instance, bool online, BaseProfilerFactory *pro
}
connect(controller.get(), &LaunchController::succeeded, this, &MultiMC::controllerSucceeded);
connect(controller.get(), &LaunchController::failed, this, &MultiMC::controllerFailed);
- controller->start();
m_runningInstances ++;
+ controller->start();
return true;
}
else if (instance->isRunning())
@@ -1148,7 +1148,6 @@ void MultiMC::on_windowClose()
{
extras.controller->setParentWidget(m_mainWindow);
}
- return;
}
auto mainWindow = qobject_cast<MainWindow *>(QObject::sender());
if(mainWindow)