summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPetr Mrázek <peterix@gmail.com>2017-12-29 00:35:10 +0100
committerPetr Mrázek <peterix@gmail.com>2017-12-29 00:35:10 +0100
commit50ca6cbb4daaa4acd300defc6b7ecc7ccb46cebf (patch)
treee8198fd0ff0916f5389e1ccac49a6bdf4eb4fda7
parent257f8ca9fdb3c12d90e0cdf4167457fc8e810b9d (diff)
downloadMultiMC-50ca6cbb4daaa4acd300defc6b7ecc7ccb46cebf.tar
MultiMC-50ca6cbb4daaa4acd300defc6b7ecc7ccb46cebf.tar.gz
MultiMC-50ca6cbb4daaa4acd300defc6b7ecc7ccb46cebf.tar.lz
MultiMC-50ca6cbb4daaa4acd300defc6b7ecc7ccb46cebf.tar.xz
MultiMC-50ca6cbb4daaa4acd300defc6b7ecc7ccb46cebf.zip
NOISSUE fix crash bug in version page of instances
This was caused by generation of temporary component objects when no such thing should have been happening.
-rw-r--r--application/pages/VersionPage.cpp2
-rw-r--r--application/pages/VersionPage.h2
2 files changed, 2 insertions, 2 deletions
diff --git a/application/pages/VersionPage.cpp b/application/pages/VersionPage.cpp
index a4abcd60..8673e4bc 100644
--- a/application/pages/VersionPage.cpp
+++ b/application/pages/VersionPage.cpp
@@ -527,7 +527,7 @@ void VersionPage::onGameUpdateError(QString error)
QMessageBox::Warning)->show();
}
-ComponentPtr VersionPage::current()
+Component * VersionPage::current()
{
auto row = currentRow();
if(row < 0)
diff --git a/application/pages/VersionPage.h b/application/pages/VersionPage.h
index 809b2c0c..b4c18367 100644
--- a/application/pages/VersionPage.h
+++ b/application/pages/VersionPage.h
@@ -67,7 +67,7 @@ private slots:
void on_changeVersionBtn_clicked();
private:
- ComponentPtr current();
+ Component * current();
int currentRow();
void updateButtons(int row = -1);
void preselect(int row = 0);