diff options
author | wolfbeast <mcwerewolf@wolfbeast.com> | 2020-03-13 11:28:54 +0100 |
---|---|---|
committer | wolfbeast <mcwerewolf@wolfbeast.com> | 2020-03-13 11:28:54 +0100 |
commit | b3a4b8361ecd56ed762353f27dc86b3e28971f4b (patch) | |
tree | 8c54a764add8de5da050fd55db64139810347f6b /sourcestamp.txt | |
parent | 41e5925b4271c598601fdc77238bbf6497576594 (diff) | |
download | UXP-b3a4b8361ecd56ed762353f27dc86b3e28971f4b.tar UXP-b3a4b8361ecd56ed762353f27dc86b3e28971f4b.tar.gz UXP-b3a4b8361ecd56ed762353f27dc86b3e28971f4b.tar.lz UXP-b3a4b8361ecd56ed762353f27dc86b3e28971f4b.tar.xz UXP-b3a4b8361ecd56ed762353f27dc86b3e28971f4b.zip |
Issue #1485 - Fix incorrect grid cell sizing to min/max space.
There were actually two separate logical errors in this method:
The first part is that "origSizes.isSome()" is simply a bogus
requirement for applying min/max-sizes here. I'm still keeping
the optimization of not needlessly copying the mSizes array
(as originally intended) since it's a quite common case.
The second bug is that min/max-sizes were only applied under
the "if (fr != 0.0f)" block. This is bogus since the calculated
'fr' value depends on 'aAvailableSize' which might change by
applying min/max-sizes and thus 'fr' could become non-zero in
the second round.
To fix, this patch just moves "applyMinMax" block out one level.
Diffstat (limited to 'sourcestamp.txt')
0 files changed, 0 insertions, 0 deletions