diff options
| author | wolfbeast <mcwerewolf@wolfbeast.com> | 2019-07-17 01:15:00 +0200 |
|---|---|---|
| committer | wolfbeast <mcwerewolf@wolfbeast.com> | 2019-07-17 01:15:00 +0200 |
| commit | ef189737a3a97bbdeb06825c06121697f62ed50b (patch) | |
| tree | 5f4f91c5bb32b0365485bd79cda33c576f821b9e /security/nss/lib/util | |
| parent | ca0083022fad1f9fb2a7b1d4b94f32402026e3e6 (diff) | |
| download | UXP-ef189737a3a97bbdeb06825c06121697f62ed50b.tar UXP-ef189737a3a97bbdeb06825c06121697f62ed50b.tar.gz UXP-ef189737a3a97bbdeb06825c06121697f62ed50b.tar.lz UXP-ef189737a3a97bbdeb06825c06121697f62ed50b.tar.xz UXP-ef189737a3a97bbdeb06825c06121697f62ed50b.zip | |
Apply better input checking discipline.
Diffstat (limited to 'security/nss/lib/util')
| -rw-r--r-- | security/nss/lib/util/quickder.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/security/nss/lib/util/quickder.c b/security/nss/lib/util/quickder.c index 7a6ac1c53..70ae42b27 100644 --- a/security/nss/lib/util/quickder.c +++ b/security/nss/lib/util/quickder.c @@ -757,6 +757,13 @@ DecodeItem(void* dest, } case SEC_ASN1_BIT_STRING: { + /* Can't be 8 or more spare bits, or any spare bits + * if there are no octets. */ + if (temp.data[0] >= 8 || (temp.data[0] > 0 && temp.len == 1)) { + PORT_SetError(SEC_ERROR_BAD_DER); + rv = SECFailure; + break; + } /* change the length in the SECItem to be the number of bits */ temp.len = (temp.len - 1) * 8 - (temp.data[0] & 0x7); |