diff options
| author | Matt A. Tobin <email@mattatobin.com> | 2019-11-10 21:59:52 -0500 |
|---|---|---|
| committer | Matt A. Tobin <email@mattatobin.com> | 2019-11-10 21:59:52 -0500 |
| commit | cea77b76b3fef912bd79e777f97d353aa50474b6 (patch) | |
| tree | 5f4792d164e62e4b9a257811dd259cc40c053683 /mailnews/local/src/nsPop3Protocol.cpp | |
| parent | 05667b0d48b50f434ea48a3065adea6c0a88f226 (diff) | |
| download | UXP-cea77b76b3fef912bd79e777f97d353aa50474b6.tar UXP-cea77b76b3fef912bd79e777f97d353aa50474b6.tar.gz UXP-cea77b76b3fef912bd79e777f97d353aa50474b6.tar.lz UXP-cea77b76b3fef912bd79e777f97d353aa50474b6.tar.xz UXP-cea77b76b3fef912bd79e777f97d353aa50474b6.zip | |
Bug 1333038 - Use 'modern' pointers to fix crash due to nsMsgLineStreamBuffer object being deleted while still in use.
Suspected "use after free" in nsMsgLineStreamBuffer::ReadNextLine() leading to crash since object may be destroyed while still in use on another thread.
Tag #1273
Diffstat (limited to 'mailnews/local/src/nsPop3Protocol.cpp')
| -rw-r--r-- | mailnews/local/src/nsPop3Protocol.cpp | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/mailnews/local/src/nsPop3Protocol.cpp b/mailnews/local/src/nsPop3Protocol.cpp index 825f45ab3..5d9d9145a 100644 --- a/mailnews/local/src/nsPop3Protocol.cpp +++ b/mailnews/local/src/nsPop3Protocol.cpp @@ -451,7 +451,6 @@ nsPop3Protocol::nsPop3Protocol(nsIURI* aURL) m_totalFolderSize(0), m_totalDownloadSize(0), m_totalBytesReceived(0), - m_lineStreamBuffer(nullptr), m_pop3ConData(nullptr) { } @@ -590,9 +589,6 @@ void nsPop3Protocol::Cleanup() FreeMsgInfo(); PR_Free(m_pop3ConData->only_uidl); PR_Free(m_pop3ConData); - - delete m_lineStreamBuffer; - m_lineStreamBuffer = nullptr; } void nsPop3Protocol::SetCapFlag(uint32_t flag) |