diff options
| author | Moonchild <moonchild@palemoon.org> | 2020-08-03 09:41:42 +0000 |
|---|---|---|
| committer | Moonchild <moonchild@palemoon.org> | 2020-08-03 09:41:42 +0000 |
| commit | 8d38e35759be85eadb7a65e435de46a9fdae7bd6 (patch) | |
| tree | 00652571e68df666890704a4d85d0488ebac02b1 /js/src/gc | |
| parent | 2e1c5dafc6d0795b7b73223e734bb5771948688b (diff) | |
| download | UXP-8d38e35759be85eadb7a65e435de46a9fdae7bd6.tar UXP-8d38e35759be85eadb7a65e435de46a9fdae7bd6.tar.gz UXP-8d38e35759be85eadb7a65e435de46a9fdae7bd6.tar.lz UXP-8d38e35759be85eadb7a65e435de46a9fdae7bd6.tar.xz UXP-8d38e35759be85eadb7a65e435de46a9fdae7bd6.zip | |
[js] Try to catch bad pointers for GC and bail if not valid.
Diffstat (limited to 'js/src/gc')
| -rw-r--r-- | js/src/gc/Marking.cpp | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/js/src/gc/Marking.cpp b/js/src/gc/Marking.cpp index 43e325394..b4db0297a 100644 --- a/js/src/gc/Marking.cpp +++ b/js/src/gc/Marking.cpp @@ -2267,6 +2267,8 @@ void js::gc::StoreBuffer::SlotsEdge::trace(TenuringTracer& mover) const { NativeObject* obj = object(); + if(!IsCellPointerValid(obj)) + return; // Beware JSObject::swap exchanging a native object for a non-native one. if (!obj->isNative()) @@ -2336,6 +2338,8 @@ js::gc::StoreBuffer::traceWholeCells(TenuringTracer& mover) { for (ArenaCellSet* cells = bufferWholeCell; cells; cells = cells->next) { Arena* arena = cells->arena; + if(!IsCellPointerValid(arena)) + continue; MOZ_ASSERT(arena->bufferedCells == cells); arena->bufferedCells = &ArenaCellSet::Empty; @@ -2364,6 +2368,7 @@ js::gc::StoreBuffer::CellPtrEdge::trace(TenuringTracer& mover) const { if (!*edge) return; + // XXX: We should check if the cell pointer is valid here too MOZ_ASSERT((*edge)->getTraceKind() == JS::TraceKind::Object); mover.traverse(reinterpret_cast<JSObject**>(edge)); |