diff options
author | Thomas Groman <tgroman@nuegia.net> | 2019-12-16 21:34:37 -0800 |
---|---|---|
committer | Thomas Groman <tgroman@nuegia.net> | 2019-12-16 21:34:37 -0800 |
commit | ef659abb66a0953593a47477042fd9eb7288bc4f (patch) | |
tree | c969a164ee7f742f8fda726324c864bb44f36e09 | |
parent | e6e22e652391ca01634a42490080361c1de7f322 (diff) | |
download | webbrowser-ef659abb66a0953593a47477042fd9eb7288bc4f.tar webbrowser-ef659abb66a0953593a47477042fd9eb7288bc4f.tar.gz webbrowser-ef659abb66a0953593a47477042fd9eb7288bc4f.tar.lz webbrowser-ef659abb66a0953593a47477042fd9eb7288bc4f.tar.xz webbrowser-ef659abb66a0953593a47477042fd9eb7288bc4f.zip |
Update status bar component for the removal of Object.(un)watch
-rw-r--r-- | components/statusbar/Status.jsm | 66 |
1 files changed, 51 insertions, 15 deletions
diff --git a/components/statusbar/Status.jsm b/components/statusbar/Status.jsm index 19e12dd..dbdd1fc 100644 --- a/components/statusbar/Status.jsm +++ b/components/statusbar/Status.jsm @@ -120,6 +120,57 @@ S4EStatusService.prototype = }, buildBinding: function() { + + // Object.prototype.watch() shim, based on Eli Grey's polyfill + // object.watch + if (!this._window.XULBrowserWindow.watch) { + Object.defineProperty(this._window.XULBrowserWindow, "watch", { + enumerable: false, + configurable: true, + writable: false, + value: function (prop, handler) { + var oldval = this[prop], + newval = oldval, + getter = function () { + return newval; + }, + setter = function (val) { + oldval = newval; + return newval = handler.call(this, prop, oldval, val); + } + ; + + try { + if (delete this[prop]) { // can't watch constants + Object.defineProperty(this, prop, { + get: getter, + set: setter, + enumerable: true, + configurable: true + }); + } + } catch(e) { + // This fails fatally on non-configurable props, so just + // ignore errors if it does. + } + } + }); + } + + // object.unwatch + if (!this._window.XULBrowserWindow.unwatch) { + Object.defineProperty(this._window.XULBrowserWindow, "unwatch", { + enumerable: false, + configurable: true, + writable: false, + value: function (prop) { + var val = this[prop]; + delete this[prop]; // remove accessors + this[prop] = val; + } + }); + } + let XULBWPropHandler = function(prop, oldval, newval) { CU.reportError("Attempt to modify XULBrowserWindow." + prop); return oldval; @@ -139,21 +190,6 @@ S4EStatusService.prototype = this._window.XULBrowserWindow[prop] = this[prop].bind(this); this._window.XULBrowserWindow.watch(prop, XULBWPropHandler); }, this); - - let XULBWHandler = function(prop, oldval, newval) { - if(!newval) - { - return newval; - } - CU.reportError("XULBrowserWindow changed. Updating S4E bindings."); - this._window.setTimeout(function(self) - { - self.buildBinding(); - }, 0, this); - return newval; - }; - - this._window.watch("XULBrowserWindow", XULBWHandler); }, destroy: function() |