summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeLines
* Merge pull request #154 from fbriere/feature/inhibit-idle-sessionLuboš Doležel2020-02-23-0/+521
|\ | | | | Add an option to prevent an idle session while a call is in progress
| * Properly display and log warning messages in IdleSessionInhibitorFrédéric Brière2019-07-13-13/+27
| |
| * Add an option to prevent an idle session while a call is in progressFrédéric Brière2019-07-13-0/+507
| | | | | | | | | | | | | | | | | | Having the session marked as idle while a call is in progress could trigger certain actions (such as locking the screen, logging out automatically, or suspending the system) which could be undesirable in this situation. Closes #123
* | Merge pull request #148 from fbriere/feature/disable-incoming-call-popupLuboš Doležel2020-02-23-2/+42
|\ \ | | | | | | Add configuration option to disable incoming call popup window
| * | Add configuration option to disable incoming call popup windowFrédéric Brière2019-06-30-2/+42
| |/ | | | | | | Closes #126
* | Merge pull request #147 from fbriere/fix/mutex-on-boolLuboš Doležel2020-02-23-2/+2
|\ \ | | | | | | Use a mutex in all t_sys_settings getters/setters, even bool
| * | Use a mutex in all t_sys_settings getters/setters, even boolFrédéric Brière2019-07-03-2/+2
| |/ | | | | | | | | | | | | | | | | | | Despite what one might intuitively expect, the C++ standard does not make any guarantee about fundamental types being atomic, not even bool. (In fact, it explicitly mentions the existence of std::atomic<bool> for that purpose.) See https://stackoverflow.com/a/35226186 for more details about this subject.
* | Merge pull request #116 from fbriere/misc/old-autotools-stuffLuboš Doležel2020-02-23-2/+3
|\ \ | | | | | | Add missing tests lost in the autotools to CMake transition
| * | CMake: Check for res_init() (HAVE_RES_INIT)Frédéric Brière2019-12-29-0/+1
| | | | | | | | | | | | | | | This check (AC_CHECK_RES_INIT) was originally defined in acinclude.m4, and was lost in the transition to CMake.
| * | CMake: Check for strerror_r() (HAVE_STRERROR_R and STRERROR_R_CHAR_P)Frédéric Brière2019-12-29-2/+2
| |/ | | | | | | | | This check (AC_FUNC_STRERROR_R) was originally present in configure.in, and was lost in the transition to CMake.
* | Merge pull request #149 from fbriere/issue/121-toggle-window-menu-entryLuboš Doležel2020-02-23-6/+33
|\ \ | | | | | | Systray icon: Always toggle visibility when clicking & Add "Show/Hide" menu entry
| * | Add a "Show/Hide window" entry to the systray icon menuFrédéric Brière2019-06-30-1/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | It's customary for applications embedding themselves in the system tray to offer a "Show/Hide window" menu entry on right-click, even for those applications which offer the same functionality via a single left-click. (Thanks to qBittorrent for the idea of using QMenu::aboutToShow to update the label of this menu entry.)
| * | Always toggle window visibility when clicking on the systray iconFrédéric Brière2019-06-30-6/+1
| |/ | | | | | | | | | | | | | | | | Left-clicking on the system tray icon should always result in toggling the visibility of the main window; if the icon is visible and clickble, then the window can always be hidden via --hide, or on startup via the "Startup hidden in system tray" option. (In the latter case, this previously resulted in a hidden and inaccessible window, as reported in issue #121.)
* | Merge pull request #164 from fbriere/fix/qml-binding-loopLuboš Doležel2020-02-23-1/+7
|\ \ | | | | | | Fix QML binding loop in TextImageButton (used in incoming call popup)
| * | Fix QML binding loop in TextImageButton (used in incoming call popup)Frédéric Brière2019-09-25-1/+7
| |/
* | Merge pull request #144 from fbriere/issue/143-readline-blocks-cmd-quitLuboš Doležel2020-02-23-17/+93
|\ \ | | | | | | Respond immediately to a "quit" command while in CLI mode
| * | Make Readline non-blocking: Use a self-pipe to break the Readline loopFrédéric Brière2019-06-29-0/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now that we are no longer blocking on Readline calls, we can set up a self-pipe that will let us break out of the Readline loop upon receiving a "quit" command on our local socket, thus (finally) fixing issue #143. (Thanks to https://stackoverflow.com/a/27662212 for the tip!) Fixes #143
| * | Make Readline non-blocking: Wrap select(2) around Readline callFrédéric Brière2019-06-29-1/+23
| | | | | | | | | | | | | | | By only invoking rl_callback_read_char() when there is actual input on stdin, we can now avoid blocking on Readline calls.
| * | Make Readline non-blocking: Relay SIGWINCH to ReadlineFrédéric Brière2019-06-29-0/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When using Readline's callback interface, signals are (by default) only captured within the duration of the rl_callback_read_char() call. It is therefore expected of the application to capture SIGWINCH on its own, and notify Readline of the fact. (While it's possible to change this with rl_persistent_signal_handlers, some signals, such as SIGHUP, will still only be *processed* during that call, making it a somewhat unappealing solution. This all could be alleviated by calling rl_check_signals() periodically, but that function was only introduced in Readline 8.0, which is far too recent.) Note that we are using signal(2) and not sigaction(2), depite the various warnings that come with it, mostly because it's what is already present in the codebase.
| * | Make Readline non-blocking: Use Readline's callback interfaceFrédéric Brière2019-06-29-19/+25
| |/ | | | | | | | | | | | | | | | | | | | | | | | | When Twinkle is running in CLI mode and is sent a "quit" command to its local socket, it will currently not respond immediately, but rather wait until the next line has been read from its standard input (issue #143). This is due to the blocking nature of readline(), which only returns once a complete line has been read. Switching to Readline's "alternate" callback interface is the first step in addressing this issue. (As a bonus, this also fixes a bug where the line pointer returned by readline() was not freed correctly.)
* | Merge pull request #158 from 4-FLOSS-Free-Libre-Open-Source-Software/patch-1Luboš Doležel2020-02-23-2/+21
|\ \ | | | | | | Add twinkle-console option --sip-port --rtp-port
| * | Add twinkle-console option --sip-port --rtp-port4-FLOSS-Free-Libre-Open-Source-Software2019-07-19-2/+21
| |/
* | Merge pull request #150 from fbriere/issue/88-mutex-lock-failedLuboš Doležel2020-02-23-2/+8
|\ \ | | | | | | Prevent recursive locking of phone_users_mtx in add_phone_user()
| * | Prevent recursive locking of phone_users_mtx in add_phone_user()Frédéric Brière2019-07-03-2/+8
| |/ | | | | | | | | | | | | | | When encountering two users with the same contact name, attempting to differentiate them using USER_HOST(), a.k.a. get_ip_sip(), would result in EDEADLK since phone_users_mtx was already locked by add_phone_user(). Closes #88
* | Merge pull request #160 from 4-FLOSS-Free-Libre-Open-Source-Software/patch-2Luboš Doležel2020-02-23-1/+1
|\ \ | | | | | | resolve nat_public_ip hostname for dyndns to work
| * | resolve nat_public_ip hostname for dyndns to work4-FLOSS-Free-Libre-Open-Source-Software2019-08-01-1/+1
| |/
* | Merge pull request #166 from fbriere/issue/165-deadlocks-simpleLuboš Doležel2020-02-23-3/+1
|\ \ | | | | | | Simple fixes for two deadlocks
| * | Make `t_phone::mutex_3way` recursive to avoid a deadlockFrédéric Brière2019-10-02-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `t_phone::mutex_3way` can be locked twice when hanging up a conference call: - `t_phone::cleanup_3way_state()` acquires a lock - `t_audio_session::stop_3way()` is called - `t_audio_session::get_peer_3way()` is called - `t_phone::get_3way_peer_line()` is called - which acquires another lock Making that mutex recursive is a simple way to work around this issue.
| * | Remove duplicate mutex lock in `t_phone::end_call()`Frédéric Brière2019-10-02-2/+0
| |/ | | | | | | | | A write lock on `lines_mtx` has already been acquired at the beginning of `end_call()`.
* | Merge pull request #185 from 4-FLOSS-Free-Libre-Open-Source-Software/patch-3Luboš Doležel2020-02-23-1/+1
|\ \ | | | | | | let gui set MAX_PTIME cutoff 80ms
| * | let gui set MAX_PTIME cutoff 80ms4-FLOSS-Free-Libre-Open-Source-Software2020-01-21-1/+1
| |/
* | Update and fix Czech and Slovak translationsJose Riha2020-02-22-45/+134
| |
* | Run lupdate on lang filesJose Riha2020-02-21-274/+808
| |
* | Fix spelling errorsJose Riha2020-02-20-66/+66
| |
* | Merge pull request #188 from jose1711/sk_translationLuboš Doležel2020-02-20-0/+5819
|\ \ | | | | | | Add Slovak translation
| * | Add Slovak translationJose Riha2020-02-19-0/+5819
| |/
* / Fix typos in Czech translationJose Riha2020-02-19-23/+23
|/
* Change the address of the manual until we have our own up and runningLubos Dolezel2019-06-17-1/+1
|
* Case insensivity in WWW-Authenticate headerJan Schlüter2019-04-08-1/+1
|
* audio: Fix parameter setting failure with alsa v1.1.7Palo Kisa2018-11-29-5/+3
|
* Update Russian translationglixx2018-10-11-87/+324
|
* Include <QRegExpValidator> explicitlyMichal Kubecek2018-06-06-1/+8
| | | | | | | Since Qt 5.11, generated ui_getprofilename.h no longer includes QHeaderView which breaks the chain that included qvalidator.h in getprofilename.cpp. As it feels rather fragile to rely on such indirect includes, let's include <QRegExpValidator> explicitly in each file using QRegExpValidator class.
* Fix spelling mistakePeter Colberg2018-03-27-1/+1
|
* Remove remaining bits of Qt 4 codeFrédéric Brière2018-02-10-32/+0
|
* Remove some code specific to Qt 4Frédéric Brière2018-02-10-4/+0
|
* Disambiguate reference to ::bind()Frédéric Brière2018-02-09-4/+4
| | | | | | There's a potential ambiguity between ::bind() and std::bind() if <functional> happens to be included beforehand (as is the case with libc++).
* bugfix: Signal name was omitted in selectLocalAddress() emitFrédéric Brière2018-02-09-1/+1
|
* Merge pull request #94 from gwozniak/masterLuboš Doležel2017-11-26-0/+53
|\ | | | | PAI Header option
| * PAI Header optionGrzegorz Woźniak2017-04-13-0/+53
| |
* | User-Determined User Busy (UDUB)Alexander Traud2017-11-26-2/+2
| | | | | | | | | | | | | | | | | | | | | | When you reject a call, either A. the forwarding rule for User-Busy kicks in, like an answering machine or another extension (of a personal secretary or a deputy). Or B. the caller hears normal ringing first, and then the busy tone. To allow case A, a SIP user-agent client (UAC) has to return the status User-Busy (486). The same should happen in case B, because the caller shall hear a busy tone on rejection. 486 is mandated for SIP clients in mobile phones by the GSMA. Furthermore, other SIP-client creators give a 486 in that case as well; I tested Acrobits, Atlinks, Counterpath, Gigaset, Grandstream, RTX, Snom, Yealink, and Vtech. Before this change, twinkle rejected a call with the SIP-Status 603. The class 6xx requires that *all* other registered phones stop to ring. Furthermore, some SIP user-agent servers (UAS) follow RFC 3398 and map a status 603 to the cause-code 21, which is mapped back to status 403 (Forbidden). Cisco and Digium Asterisk do this. For example in Asterisk, after you rejected the call in twinkle, the caller did not get 603 or 486, but 403. However, in case of 403, the original caller is allowed to re-try the call setup. For example, I have a Nokia Symbian/S60 based phone which tries via IPv4 first, then after it received the 403, that phone tries again via IPv6. Consequently, a user of twinkle had to reject the call twice when 603 was returned.
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-30 09:03:27 +0000