summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeLines
* Merge pull request #107 from fbriere/bug/bind-is-ambiguousLuboš Doležel2018-02-09-4/+4
|\ | | | | Disambiguate reference to ::bind()
| * Disambiguate reference to ::bind()Frédéric Brière2018-02-09-4/+4
|/ | | | | | There's a potential ambiguity between ::bind() and std::bind() if <functional> happens to be included beforehand (as is the case with libc++).
* Merge pull request #105 from fbriere/bug/addressbook-emitLuboš Doležel2018-02-09-1/+1
|\ | | | | bugfix: Signal name was omitted in selectLocalAddress() emit
| * bugfix: Signal name was omitted in selectLocalAddress() emitFrédéric Brière2018-02-09-1/+1
| |
* | Merge pull request #106 from fbriere/bug/cmake-libmagic-fileLuboš Doležel2018-02-09-6/+4
|\ \ | |/ |/| Don't require file(1) when checking for libmagic
| * Don't require file(1) when checking for libmagicFrédéric Brière2018-02-09-6/+4
|/ | | | | | | | | | | | | | | | | | Attempting to compile Twinkle on a system where file(1) is not available currently produces a confusing error message about libmagic not being found. The only reason to require file(1) was to obtain the libmagic version, as the MAGIC_VERSION constant was apparently only introduced in 5.13. But since we don't need any particular version, we might as well drop this requirement. Using find_program() instead of find_path() avoids picking /usr/include/file by mistake, which resulted in a (harmless) empty version string in the CMake output. (Thanks to https://bro-tracker.atlassian.net/browse/BIT-1096 for providing some of this information.)
* Merge pull request #94 from gwozniak/masterLuboš Doležel2017-11-26-0/+53
|\ | | | | PAI Header option
| * PAI Header optionGrzegorz Woźniak2017-04-13-0/+53
| |
* | Merge pull request #102 from traud/UDUBLuboš Doležel2017-11-26-2/+2
|\ \ | | | | | | User-Determined User Busy (UDUB)
| * | User-Determined User Busy (UDUB)Alexander Traud2017-11-26-2/+2
|/ / | | | | | | | | | | | | | | | | | | | | When you reject a call, either A. the forwarding rule for User-Busy kicks in, like an answering machine or another extension (of a personal secretary or a deputy). Or B. the caller hears normal ringing first, and then the busy tone. To allow case A, a SIP user-agent client (UAC) has to return the status User-Busy (486). The same should happen in case B, because the caller shall hear a busy tone on rejection. 486 is mandated for SIP clients in mobile phones by the GSMA. Furthermore, other SIP-client creators give a 486 in that case as well; I tested Acrobits, Atlinks, Counterpath, Gigaset, Grandstream, RTX, Snom, Yealink, and Vtech. Before this change, twinkle rejected a call with the SIP-Status 603. The class 6xx requires that *all* other registered phones stop to ring. Furthermore, some SIP user-agent servers (UAS) follow RFC 3398 and map a status 603 to the cause-code 21, which is mapped back to status 403 (Forbidden). Cisco and Digium Asterisk do this. For example in Asterisk, after you rejected the call in twinkle, the caller did not get 603 or 486, but 403. However, in case of 403, the original caller is allowed to re-try the call setup. For example, I have a Nokia Symbian/S60 based phone which tries via IPv4 first, then after it received the 403, that phone tries again via IPv6. Consequently, a user of twinkle had to reject the call twice when 603 was returned.
* | Fix crash in parsing pending message countLubos Dolezel2017-11-15-2/+6
| |
* | Fix DTMF key 3 being sent twice (resolves #95)Lubos Dolezel2017-04-28-1/+0
|/
* Merge pull request #92 from omni6/patch-1Luboš Doležel2017-03-09-1/+1
|\ | | | | Update twinkle_de.ts
| * Update twinkle_de.tsomni62017-03-09-1/+1
|/
* Merge pull request #87 from Atalanttore/patch-1Luboš Doležel2016-11-04-212/+208
|\ | | | | Small German translation update
| * Small German translation updateEttore Atalan2016-11-04-212/+208
|/ | | I've updated the German translation file.
* Merge pull request #86 from petercolberg/masterLuboš Doležel2016-10-31-9/+9
|\ | | | | Fix spelling mistakes
| * Fix spelling mistakesPeter Colberg2016-10-28-9/+9
|/
* Release 1.10.1Lubos Dolezel2016-10-07-2/+9
|
* Merge pull request #84 from fbriere/issue/82-gui-thread-call-show-hideLuboš Doležel2016-10-07-35/+47
|\ | | | | Have --call/show/hide invoke methods in the GUI thread
| * Move (private) gui_cmd_call/show/hide() methods to their proper locationFrédéric Brière2016-10-05-38/+38
| | | | | | | | (This is just cut-and-paste, also removing some trailing whitespace.)
| * Have --call/show/hide invoke methods in the GUI threadFrédéric Brière2016-10-05-6/+18
|/ | | | Fixes #82
* Merge pull request #79 from fbriere/bug/selectuserformLuboš Doležel2016-10-05-2/+1
|\ | | | | Fix two issues with SelectUserForm
| * List users in forward order in SelectUserForm::show()Frédéric Brière2016-10-03-1/+1
| |
| * Fix double incrementation in SelectUserForm::validate()Frédéric Brière2016-10-03-1/+0
| |
* | Merge pull request #80 from fbriere/bug/number-conversion-multipleLuboš Doležel2016-10-05-3/+3
|\ \ | | | | | | Fix two issues with multiple number conversion rules in UserProfileForm
| * | Display number conversions in forward order for UserProfileFormFrédéric Brière2016-10-03-1/+1
| | |
| * | Actually iterate over rows in UserProfileForm::get_number_conversions()Frédéric Brière2016-10-03-2/+2
| |/
* | Merge pull request #78 from fbriere/issue/73-freeze-on-xferLuboš Doležel2016-10-05-1/+40
|\ \ | | | | | | Skip over the mutex field when copying t_call_info data
| * | Skip over the mutex field when copying t_call_info dataFrédéric Brière2016-10-04-1/+40
| |/ | | | | | | | | | | | | | | | | | | | | | | t_line::get_call_info() returns a copy of a (locked) t_call_info; copying the mutex, aside from being undefined in POSIX, returns an unexpectedly locked copy, possibly resulting in a deadlock. This fix is pretty much a copy of the one applied to t_call_record in 38bb6b7, with an added check for self-assignment. Like its predecessor, it is still susceptible to deadlock, though (as unlikely as it may be). Fixes #73
* | Merge pull request #76 from fbriere/issue/25-fsf-old-addressLuboš Doležel2016-10-05-695/+347
|\ \ | | | | | | Replace (old) FSF postal address with URL in header files
| * | Replace (old) FSF postal address with URL in header filesFrédéric Brière2016-10-02-695/+347
| | | | | | | | | | | | | | | | | | Wording copied from https://www.gnu.org/licenses/gpl-howto.en.html Fixes #25, fixes #71
* | | Merge pull request #83 from fbriere/issue/74-freeze-on-referLuboš Doležel2016-10-05-6/+23
|\ \ \ | | | | | | | | Invoke "ask user to refer" from within the GUI thread
| * | | Invoke "ask user to refer" from within the GUI threadFrédéric Brière2016-10-04-6/+23
| | |/ | |/| | | | | | | Fixes #74
* | | Merge pull request #81 from fbriere/bug/ucommon-not-commoncpp2Luboš Doležel2016-10-05-5/+5
|\ \ \ | |/ / |/| | Remove remaining traces of obsolete commoncpp2 dependency
| * | Have CMake check for Ucommon before CommoncppFrédéric Brière2016-10-03-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Failure to install uCommon C++ will result in the message "Could NOT find commoncpp development files". This could be confusing, as "commoncpp" may ambiguously refer to either Common C++ (commoncpp2) or uCommon C++ (libcommoncpp). By checking for Ucommon first, the resulting message will be: "Could NOT find ucommon development files", which is clearly unambiguous.
| * | Remove remaining traces of obsolete commoncpp2 dependencyFrédéric Brière2016-10-03-4/+4
|/ /
* | Merge pull request #77 from fbriere/misc/addressbook-messages-frLuboš Doležel2016-10-03-28/+36
|\ \ | |/ |/| Additions/corrections of French messages related to the address book
| * Fix French spelling error: "carnet d'adresse" -> "carnet d'adresses"Frédéric Brière2016-10-03-28/+28
| | | | | | | | | | | | | | The correct French term for "address book" is "carnet d'adresses", as documented in the following term record: http://www.gdt.oqlf.gouv.qc.ca/ficheOqlf.aspx?Id_Fiche=8365993
| * Add French translation for contact deletion confirmation promptFrédéric Brière2016-10-03-0/+8
|/ | | | | | The confirmation prompt when deleting a contact from the local address book (added in 57dc032) contains two new translatable strings; this commit provides their French translation.
* Merge pull request #72 from manisandro/pa_roleLuboš Doležel2016-07-20-0/+4
|\ | | | | Set PULSE_PROP_media.role=phone environment variable to pause music playback during conversations
| * Set PULSE_PROP_media.role=phone environment variable to pause music playback ↵Sandro Mani2016-07-20-0/+4
|/ | | | during conversations
* Merge pull request #70 from manisandro/gsm_extern_cLuboš Doležel2016-07-20-0/+4
|\ | | | | Enclose gsm.h includes with extern C to resolve link failures
| * Enclose gsm.h includes with extern C to resolve link failuresSandro Mani2016-07-20-0/+4
|/
* Twinkle 1.10.0Luboš Doležel2016-07-15-4/+15
|
* Merge pull request #68 from mkubecek/mk/obs-fixLuboš Doležel2016-05-20-42/+65
|\ | | | | DTMF event type cleanup
| * DTMF event type cleanupMichal Kubecek2016-05-20-42/+65
|/ | | | | | | DTMF event constants handling is a bit messy as three different types are used in different source files, triggering various compiler warnings. Introduce t_dtmf_ev type and use it everywhere, also replace helper macros by inline functions.
* Merge pull request #66 from petercolberg/spellingLuboš Doležel2016-05-14-1/+1
|\ | | | | Fix spelling error
| * Fix spelling errorPeter Colberg2016-05-13-1/+1
|/
* Merge pull request #65 from palinek/warn_fixLuboš Doležel2016-03-21-7/+7
|\ | | | | Fix couple of wanrnings, typos, wrong usage