From 23adb0d02f6b75a1f7463cc905e38b4145969681 Mon Sep 17 00:00:00 2001 From: Nathan Adams Date: Sun, 15 Jan 2012 05:58:56 +0000 Subject: Minor optimization in BlockGrass by only checking light once instead of twice. Thanks to oloflarsson for the PR. --- src/main/java/net/minecraft/server/BlockGrass.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'src') diff --git a/src/main/java/net/minecraft/server/BlockGrass.java b/src/main/java/net/minecraft/server/BlockGrass.java index 97afac5d..27762345 100644 --- a/src/main/java/net/minecraft/server/BlockGrass.java +++ b/src/main/java/net/minecraft/server/BlockGrass.java @@ -21,8 +21,9 @@ public class BlockGrass extends Block { public void a(World world, int i, int j, int k, Random random) { if (!world.isStatic) { - if (world.getLightLevel(i, j + 1, k) < 4 && Block.q[world.getTypeId(i, j + 1, k)] > 2) { - // CraftBukkit start + // CraftBukkit start - reuse getLightLevel + int lightLevel = world.getLightLevel(i, j + 1, k); + if (lightLevel < 4 && Block.q[world.getTypeId(i, j + 1, k)] > 2) { org.bukkit.World bworld = world.getWorld(); org.bukkit.block.BlockState blockState = bworld.getBlockAt(i, j, k).getState(); blockState.setTypeId(Block.DIRT.id); @@ -33,8 +34,8 @@ public class BlockGrass extends Block { if (!event.isCancelled()) { blockState.update(true); } - // CraftBukkit end - } else if (world.getLightLevel(i, j + 1, k) >= 9) { + } else if (lightLevel >= 9) { + // CraftBukkit end for (int l = 0; l < 4; ++l) { int i1 = i + random.nextInt(3) - 1; int j1 = j + random.nextInt(5) - 3; -- cgit v1.2.3