Use ImmutableList rather than AbstractList for CraftMetaBook

Although the AbstracList implementation does return a list, it is a
of a form that does not play well with libraries using reflection,
such as Gson. Leveraging a stream and the ImmutableList collector,
this process is greatly simplified (and cleaner).

1 files changed, 1 insertions, 13 deletions

diff --git a/src/main/java/org/bukkit/craftbukkit/inventory/CraftMetaBook.java b/src/main/java/org/bukkit/craftbukkit/inventory/CraftMetaBook.java
index c8654c68..0831e13e 100644
--- a/src/main/java/org/bukkit/craftbukkit/inventory/CraftMetaBook.java
+++ b/src/main/java/org/bukkit/craftbukkit/inventory/CraftMetaBook.java
@@ -256,19 +256,7 @@ public class CraftMetaBook extends CraftMetaItem implements BookMeta {
     }
 
     public List<String> getPages() {
-        final List<IChatBaseComponent> copy = ImmutableList.copyOf(pages);
-        return new AbstractList<String>() {
-
-            @Override
-            public String get(int index) {
-                return CraftChatMessage.fromComponent(copy.get(index));
-            }
-
-            @Override
-            public int size() {
-                return copy.size();
-            }
-        };
+        return pages.stream().map(CraftChatMessage::fromComponent).collect(ImmutableList.toImmutableList());
     }
 
     public void setPages(List<String> pages) {