From 6e4ba4302f805ed55f9d92f52bcaf7614b2b0376 Mon Sep 17 00:00:00 2001 From: Necrodoom Date: Wed, 30 Jan 2013 18:15:58 +0200 Subject: update config.yml to include commandblock change --- EssentialsGroupManager/src/config.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'EssentialsGroupManager') diff --git a/EssentialsGroupManager/src/config.yml b/EssentialsGroupManager/src/config.yml index cc90bea6f..bff472be0 100644 --- a/EssentialsGroupManager/src/config.yml +++ b/EssentialsGroupManager/src/config.yml @@ -7,6 +7,10 @@ settings: # Default setting for 'mantoglevalidate' # true will cause GroupManager to attempt name matching by default. validate_toggle: true + # *************************************************************************************************************** + # *** NOTE: Having this feature enabled, improper use of commandblocks will lead to server chaos, be alarmed! *** + # *************************************************************************************************************** + allow_commandblocks: false data: save: @@ -39,4 +43,4 @@ settings: # world4: # - groups (World4 would use the groups.yml from world2, but it's own users.yml) # world5: - # - world6 (this would cause world6 to mirror both files from world5) \ No newline at end of file + # - world6 (this would cause world6 to mirror both files from world5) -- cgit v1.2.3 From 623ff0f6290d6cc518a9a7dcb7f301dea7e4364f Mon Sep 17 00:00:00 2001 From: Necrodoom Date: Wed, 30 Jan 2013 18:47:19 +0200 Subject: register new config setting --- .../src/org/anjocaido/groupmanager/GMConfiguration.java | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) (limited to 'EssentialsGroupManager') diff --git a/EssentialsGroupManager/src/org/anjocaido/groupmanager/GMConfiguration.java b/EssentialsGroupManager/src/org/anjocaido/groupmanager/GMConfiguration.java index 4fcd0a554..e5a24258e 100644 --- a/EssentialsGroupManager/src/org/anjocaido/groupmanager/GMConfiguration.java +++ b/EssentialsGroupManager/src/org/anjocaido/groupmanager/GMConfiguration.java @@ -22,6 +22,7 @@ import org.yaml.snakeyaml.reader.UnicodeReader; */ public class GMConfiguration { + private boolean allowCommandBlocks = false; private boolean opOverride = true; private boolean toggleValidate = true; private Integer saveInterval = 10; @@ -40,6 +41,7 @@ public class GMConfiguration { /* * Set defaults */ + allowCommandBlocks = false; opOverride = true; toggleValidate = true; saveInterval = 10; @@ -83,6 +85,7 @@ public class GMConfiguration { try { Map config = getElement("config", getElement("settings", GMconfig)); + allowCommandBlocks = (Boolean) config.get("allow_commandblocks"); opOverride = (Boolean) config.get("opOverrides"); toggleValidate = (Boolean) config.get("validate_toggle"); @@ -142,6 +145,10 @@ public class GMConfiguration { return (Map) map.get(element); } + public boolean isAllowCommandBlocks() { + + return allowCommandBlocks; + } public boolean isOpOverride() { @@ -183,4 +190,4 @@ public class GMConfiguration { } -} \ No newline at end of file +} -- cgit v1.2.3 From 4167dd25903d6bf75f6f84d919d088532a9c2fe3 Mon Sep 17 00:00:00 2001 From: Necrodoom Date: Wed, 30 Jan 2013 18:53:40 +0200 Subject: add allow commandblock check --- .../src/org/anjocaido/groupmanager/GroupManager.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'EssentialsGroupManager') diff --git a/EssentialsGroupManager/src/org/anjocaido/groupmanager/GroupManager.java b/EssentialsGroupManager/src/org/anjocaido/groupmanager/GroupManager.java index 050bd9995..b99bebf63 100644 --- a/EssentialsGroupManager/src/org/anjocaido/groupmanager/GroupManager.java +++ b/EssentialsGroupManager/src/org/anjocaido/groupmanager/GroupManager.java @@ -387,10 +387,11 @@ public class GroupManager extends JavaPlugin { Group senderGroup = null; User senderUser = null; boolean isOpOverride = config.isOpOverride(); + boolean isAllowCommandBlocks = config.isAllowCommandBlocks(); // PREVENT GM COMMANDS BEING USED ON COMMANDBLOCKS - if (sender instanceof BlockCommandSender) { - sender.sendMessage(ChatColor.RED + "GM Commands can not be called from CommandBlocks"); + if (sender instanceof BlockCommandSender && !isAllowCommandBlocks) { + console.sendMessage(ChatColor.RED + "GM Commands can not be called from CommandBlocks"); return true; } -- cgit v1.2.3 From 5535435215fc7cd98b7951ba71624ae6f9172734 Mon Sep 17 00:00:00 2001 From: Necrodoom Date: Wed, 30 Jan 2013 19:14:57 +0200 Subject: update config description of allow_commmandblocks --- EssentialsGroupManager/src/config.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'EssentialsGroupManager') diff --git a/EssentialsGroupManager/src/config.yml b/EssentialsGroupManager/src/config.yml index bff472be0..479399bb6 100644 --- a/EssentialsGroupManager/src/config.yml +++ b/EssentialsGroupManager/src/config.yml @@ -7,9 +7,9 @@ settings: # Default setting for 'mantoglevalidate' # true will cause GroupManager to attempt name matching by default. validate_toggle: true - # *************************************************************************************************************** - # *** NOTE: Having this feature enabled, improper use of commandblocks will lead to server chaos, be alarmed! *** - # *************************************************************************************************************** + # ********************************************************************************************************************************** + # *** NOTE: Having this feature enabled, improper use of commandblocks will lead to undesireable permission changes, be alarmed! *** + # ********************************************************************************************************************************** allow_commandblocks: false data: -- cgit v1.2.3 From 738ded7ae5ca9d9990ca2298cac3f91b6768665e Mon Sep 17 00:00:00 2001 From: Necrodoom Date: Wed, 30 Jan 2013 19:25:35 +0200 Subject: update commandblock usage deny message --- .../src/org/anjocaido/groupmanager/GroupManager.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'EssentialsGroupManager') diff --git a/EssentialsGroupManager/src/org/anjocaido/groupmanager/GroupManager.java b/EssentialsGroupManager/src/org/anjocaido/groupmanager/GroupManager.java index b99bebf63..4a9b65317 100644 --- a/EssentialsGroupManager/src/org/anjocaido/groupmanager/GroupManager.java +++ b/EssentialsGroupManager/src/org/anjocaido/groupmanager/GroupManager.java @@ -391,7 +391,8 @@ public class GroupManager extends JavaPlugin { // PREVENT GM COMMANDS BEING USED ON COMMANDBLOCKS if (sender instanceof BlockCommandSender && !isAllowCommandBlocks) { - console.sendMessage(ChatColor.RED + "GM Commands can not be called from CommandBlocks"); + Block block = ((BlockCommandSender)sender).getBlock(); + console.sendMessage(ChatColor.RED + "GM Commands can not be called from CommandBlock at location:" + ChatColor.GREEN + " " + block.getX + ", " + block.getY + ", " + block.getZ); return true; } @@ -400,7 +401,7 @@ public class GroupManager extends JavaPlugin { senderPlayer = (Player) sender; if (!lastError.isEmpty() && !commandLabel.equalsIgnoreCase("manload")) { - sender.sendMessage(ChatColor.RED + "All commands are locked due to an error. " + ChatColor.BOLD + "" + ChatColor.UNDERLINE + "Check the log" + ChatColor.RESET + "" + ChatColor.RED + " and then try a '/manload'."); + GroupManager.logger.warning(ChatColor.RED + "All commands are locked due to an error. " + ChatColor.BOLD + "" + ChatColor.UNDERLINE + "Check the log" + ChatColor.RESET + "" + ChatColor.RED + " and then try a '/manload'."); return true; } -- cgit v1.2.3 From b8a71761ec9ddbd2c894508581ef78d46b1ba93b Mon Sep 17 00:00:00 2001 From: Necrodoom Date: Wed, 30 Jan 2013 19:26:46 +0200 Subject: update changelog --- EssentialsGroupManager/src/Changelog.txt | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'EssentialsGroupManager') diff --git a/EssentialsGroupManager/src/Changelog.txt b/EssentialsGroupManager/src/Changelog.txt index dae50fd15..f3bc35baa 100644 --- a/EssentialsGroupManager/src/Changelog.txt +++ b/EssentialsGroupManager/src/Changelog.txt @@ -34,10 +34,10 @@ v 1.3: (for all worlds named in config.yml) - Attempt to stop GM wiping groups/users yml's on a bad shut down. - Added event handling to manage new world creation at runtime. - - Added the ability to handle unknown worlds at server start. - (GM will create the data files for any worlds it finds which are not in the config.yml) + - Added the ability to handle unknown worlds at server start. + (GM will create the data files for any worlds it finds which are not in the config.yml) - Fix for Bukkit passing a null To location on a player Portaling - - Fixed manudelsub not correctly selecting the group to remove. + - Fixed manudelsub not correctly selecting the group to remove. - Added two new permission nodes - groupmanager.notify.self & groupmanager.notify.other These allow players/admins to be notified when players are moved between groups. v 1.4: @@ -211,4 +211,5 @@ v 2.0: - Negate 'groupmanager.noofflineperms' by default in the owner group. - Add support for BukkitForge using 'overworld' as the main world name. - Prevent '*' permissions granting the 'groupmanager.noofflineperms' permission. - - Added '/mancheckw ' to inspect which permission files a world is referencing. \ No newline at end of file + - Added '/mancheckw ' to inspect which permission files a world is referencing. + - Add config potion to set if GM commands should be allowed on CommnandBlocks. -- cgit v1.2.3