From e864696b000db1da774a0a164568deede9bf09af Mon Sep 17 00:00:00 2001
From: Chris Ward <chris@chrisgward.com>
Date: Sat, 7 Dec 2013 13:24:48 +1100
Subject: Revert "Fixed bug when logging in silently"

This reverts commit 5fe19dbd8321beaec20d359cc85371b6320c33ec.
---
 .../essentials/EssentialsPlayerListener.java       | 33 ++++++++++++----------
 1 file changed, 18 insertions(+), 15 deletions(-)

diff --git a/Essentials/src/com/earth2me/essentials/EssentialsPlayerListener.java b/Essentials/src/com/earth2me/essentials/EssentialsPlayerListener.java
index ddc0cd950..4547ead88 100644
--- a/Essentials/src/com/earth2me/essentials/EssentialsPlayerListener.java
+++ b/Essentials/src/com/earth2me/essentials/EssentialsPlayerListener.java
@@ -186,30 +186,19 @@ public class EssentialsPlayerListener implements Listener
 	@EventHandler(priority = EventPriority.HIGHEST)
 	public void onPlayerJoin(final PlayerJoinEvent event)
 	{
+		final String joinMessage = event.getJoinMessage();
 		ess.runTaskAsynchronously(new Runnable()
 		{
 			@Override
 			public void run()
 			{
-				delayedJoin(event.getPlayer());
+				delayedJoin(event.getPlayer(), joinMessage);
 			}
 		});
-		if (ess.getSettings().allowSilentJoinQuit() && event.getPlayer().hasPermission("essentials.silentjoin"))
-				{
-					event.setJoinMessage(null);
-				}
-		if (ess.getSettings().isCustomJoinMessage() && event.getJoinMessage() != null)
-				{
-					event.setJoinMessage(null);
-					ess.getServer().broadcastMessage(
-							ess.getSettings().getCustomJoinMessage()
-									.replace("{PLAYER}", event.getPlayer().getDisplayName())
-									.replace("{USERNAME}", event.getPlayer().getName())
-					);
-				}
+		event.setJoinMessage(null);
 	}
 
-	public void delayedJoin(final Player player)
+	public void delayedJoin(final Player player, final String message)
 	{
 		if (!player.isOnline())
 		{
@@ -219,6 +208,7 @@ public class EssentialsPlayerListener implements Listener
 		ess.getBackup().onPlayerJoin();
 		final User user = ess.getUser(player);
 
+
 		if (user.isNPC())
 		{
 			user.setNPC(false);
@@ -259,6 +249,19 @@ public class EssentialsPlayerListener implements Listener
 					user.setSleepingIgnored(true);
 				}
 
+				if (ess.getSettings().isCustomJoinMessage())
+				{
+					ess.getServer().broadcastMessage(
+							ess.getSettings().getCustomJoinMessage()
+									.replace("{PLAYER}", player.getDisplayName())
+									.replace("{USERNAME}", player.getName())
+					);
+				}
+				else if (!(ess.getSettings().allowSilentJoinQuit() && user.isAuthorized("esentials.silentjoin")) && message != null)
+				{
+					ess.getServer().broadcastMessage(message);
+				}
+
 				if (!ess.getSettings().isCommandDisabled("motd") && user.isAuthorized("essentials.motd"))
 				{
 					try
-- 
cgit v1.2.3