From c62f762724991f5cd55a4698b9d885d4bb8e42be Mon Sep 17 00:00:00 2001 From: snowleo Date: Fri, 3 May 2013 01:15:02 +0200 Subject: Do not keep hard references to User objects --- Essentials/src/com/earth2me/essentials/EssentialsTimer.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Essentials/src/com/earth2me/essentials/EssentialsTimer.java b/Essentials/src/com/earth2me/essentials/EssentialsTimer.java index 38c42e918..d53336bb2 100644 --- a/Essentials/src/com/earth2me/essentials/EssentialsTimer.java +++ b/Essentials/src/com/earth2me/essentials/EssentialsTimer.java @@ -11,7 +11,7 @@ import org.bukkit.entity.Player; public class EssentialsTimer implements Runnable { private final transient IEssentials ess; - private final transient Set onlineUsers = new HashSet(); + private final transient Set onlineUsers = new HashSet(); private transient long lastPoll = System.nanoTime(); private final LinkedList history = new LinkedList(); private int skip1 = 0; @@ -64,7 +64,7 @@ public class EssentialsTimer implements Runnable try { final User user = ess.getUser(player); - onlineUsers.add(user); + onlineUsers.add(user.getName()); user.setLastOnlineActivity(currentTime); user.checkActivity(); } @@ -75,7 +75,7 @@ public class EssentialsTimer implements Runnable } count = 0; - final Iterator iterator = onlineUsers.iterator(); + final Iterator iterator = onlineUsers.iterator(); while (iterator.hasNext()) { count++; @@ -92,7 +92,7 @@ public class EssentialsTimer implements Runnable break; } } - final User user = iterator.next(); + final User user = ess.getUser(iterator.next()); if (user.getLastOnlineActivity() < currentTime && user.getLastOnlineActivity() > user.getLastLogout()) { user.setLastLogout(user.getLastOnlineActivity()); -- cgit v1.2.3