From 9e4493fbb42b044f74d4ca08dec880fb63522593 Mon Sep 17 00:00:00 2001 From: ElgarL Date: Tue, 29 Jan 2013 16:14:24 +0000 Subject: Prevent '*' permissions granting the 'groupmanager.noofflineperm' permission. --- EssentialsGroupManager/src/Changelog.txt | 3 ++- .../org/anjocaido/groupmanager/permissions/AnjoPermissionsHandler.java | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/EssentialsGroupManager/src/Changelog.txt b/EssentialsGroupManager/src/Changelog.txt index fe443e2a4..c8d577945 100644 --- a/EssentialsGroupManager/src/Changelog.txt +++ b/EssentialsGroupManager/src/Changelog.txt @@ -209,4 +209,5 @@ v 2.0: - Synchronize pushing to Bukkit perms to prevent any ConcurrentModificationException. - Do not grant any permissions (nor update Bukkit) if the server is in offline mode and the player has the permission node 'groupmanager.noofflineperms'. - Negate 'groupmanager.noofflineperms' by default in the owner group. - - Add support for BukkitForge using 'overworld' as the main world name. \ No newline at end of file + - Add support for BukkitForge using 'overworld' as the main world name. + - Prevent '*' permissions granting the 'groupmanager.noofflineperm' permission. \ No newline at end of file diff --git a/EssentialsGroupManager/src/org/anjocaido/groupmanager/permissions/AnjoPermissionsHandler.java b/EssentialsGroupManager/src/org/anjocaido/groupmanager/permissions/AnjoPermissionsHandler.java index 7396f3f70..a221c56a2 100644 --- a/EssentialsGroupManager/src/org/anjocaido/groupmanager/permissions/AnjoPermissionsHandler.java +++ b/EssentialsGroupManager/src/org/anjocaido/groupmanager/permissions/AnjoPermissionsHandler.java @@ -172,6 +172,8 @@ public class AnjoPermissionsHandler extends PermissionsReaderInterface { permArray.addAll(GroupManager.BukkitPermissions.getAllRegisteredPermissions(includeChildren)); allPerms = true; perms.remove("*"); + // Remove the no offline perms node as this should not be given. + perms.remove("groupmanager.noofflineperms"); } for (String perm : perms) { -- cgit v1.2.3