From 3f35a6b59c20cf52de833aae7fb383775069da50 Mon Sep 17 00:00:00 2001 From: ElgarL Date: Sun, 28 Jul 2013 09:10:23 +0100 Subject: Prevent adding sub groups for ranks the granting player doesn't have access to. --- EssentialsGroupManager/src/Changelog.txt | 1 + .../src/org/anjocaido/groupmanager/GroupManager.java | 10 +++++++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/EssentialsGroupManager/src/Changelog.txt b/EssentialsGroupManager/src/Changelog.txt index fcdd930f0..d30265810 100644 --- a/EssentialsGroupManager/src/Changelog.txt +++ b/EssentialsGroupManager/src/Changelog.txt @@ -222,3 +222,4 @@ v 2.0: - Store worldSelection indexed on the senders name rather than the object (fixes commandblocks using manselect). - Check subgroup permissions with an equal priority so no one subgroup is higher ranked than another. - add recursive permission adding/deleting + - Prevent adding sub groups for ranks the granting player doesn't have access to. \ No newline at end of file diff --git a/EssentialsGroupManager/src/org/anjocaido/groupmanager/GroupManager.java b/EssentialsGroupManager/src/org/anjocaido/groupmanager/GroupManager.java index dcbfbd326..24a70d465 100644 --- a/EssentialsGroupManager/src/org/anjocaido/groupmanager/GroupManager.java +++ b/EssentialsGroupManager/src/org/anjocaido/groupmanager/GroupManager.java @@ -611,6 +611,14 @@ public class GroupManager extends JavaPlugin { sender.sendMessage(ChatColor.RED + "You can't modify a player with same permissions as you, or higher."); return true; } + if (!isConsole && !isOpOverride && (permissionHandler.hasGroupInInheritance(auxGroup, senderGroup.getName()))) { + sender.sendMessage(ChatColor.RED + "The sub-group can't be the same as yours, or higher."); + return true; + } + if (!isConsole && !isOpOverride && (!permissionHandler.inGroup(senderUser.getName(), auxUser.getGroupName()) || !permissionHandler.inGroup(senderUser.getName(), auxGroup.getName()))) { + sender.sendMessage(ChatColor.RED + "You can't modify a player involving a group that you don't inherit."); + return true; + } // Seems OK if (auxUser.addSubGroup(auxGroup)) sender.sendMessage(ChatColor.YELLOW + "You added subgroup '" + auxGroup.getName() + "' to player '" + auxUser.getName() + "'."); @@ -993,7 +1001,7 @@ public class GroupManager extends JavaPlugin { } // Validating arguments if (args.length < 2) { - sender.sendMessage(ChatColor.RED + "Review your arguments count! (/mangaaddp [permission2] [permission3]...)"); + sender.sendMessage(ChatColor.RED + "Review your arguments count! (/mangaddp [permission2] [permission3]...)"); return true; } -- cgit v1.2.3