From 2dba03fd2f864bd8020bd1502041fa67de8bf409 Mon Sep 17 00:00:00 2001 From: trav90 Date: Fri, 6 Apr 2018 11:25:22 -0500 Subject: [GTK3] Ignore double-click on WM without _NET_WM_MOVERESIZE support This fixes a crash with GTK3 builds used with a window manager that does not support _NET_WM_MOVERESIZE. --- widget/gtk/nsWindow.cpp | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) (limited to 'widget') diff --git a/widget/gtk/nsWindow.cpp b/widget/gtk/nsWindow.cpp index d97b35002..e4e69c1b4 100644 --- a/widget/gtk/nsWindow.cpp +++ b/widget/gtk/nsWindow.cpp @@ -6627,6 +6627,22 @@ nsWindow::GetDragInfo(WidgetMouseEvent* aMouseEvent, return false; } + if (mIsX11Display) { + // Workaround for https://bugzilla.gnome.org/show_bug.cgi?id=789054 + // To avoid crashes disable double-click on WM without _NET_WM_MOVERESIZE. + // See _should_perform_ewmh_drag() at gdkwindow-x11.c + GdkScreen* screen = gdk_window_get_screen(gdk_window); + GdkAtom atom = gdk_atom_intern("_NET_WM_MOVERESIZE", FALSE); + if (!gdk_x11_screen_supports_net_wm_hint(screen, atom)) { + static unsigned int lastTimeStamp = 0; + if (lastTimeStamp != aMouseEvent->mTime) { + lastTimeStamp = aMouseEvent->mTime; + } else { + return false; + } + } + } + // FIXME: It would be nice to have the widget position at the time // of the event, but it's relatively unlikely that the widget has // moved since the mousedown. (On the other hand, it's quite likely -- cgit v1.2.3