From 891ca8709adab06325b0f6e5432ffa4a620438bb Mon Sep 17 00:00:00 2001 From: "Matt A. Tobin" Date: Sun, 10 Nov 2019 22:20:52 -0500 Subject: Bug 1507718 - crash in nsImapProtocol::GetMessageSize(). Make m_hostSessionList an nsCOMPtr. Tag #1273 --- mailnews/imap/src/nsImapProtocol.cpp | 4 ++-- mailnews/imap/src/nsImapProtocol.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'mailnews') diff --git a/mailnews/imap/src/nsImapProtocol.cpp b/mailnews/imap/src/nsImapProtocol.cpp index fd6b84d20..609a30e19 100644 --- a/mailnews/imap/src/nsImapProtocol.cpp +++ b/mailnews/imap/src/nsImapProtocol.cpp @@ -530,7 +530,7 @@ nsresult nsImapProtocol::Configure(int32_t TooFastTime, int32_t IdealTime, NS_IMETHODIMP -nsImapProtocol::Initialize(nsIImapHostSessionList * aHostSessionList, +nsImapProtocol::Initialize(nsIImapHostSessionList *aHostSessionList, nsIImapIncomingServer *aServer) { NS_PRECONDITION(aHostSessionList && aServer, @@ -551,7 +551,7 @@ nsImapProtocol::Initialize(nsIImapHostSessionList * aHostSessionList, aServer->GetUseCompressDeflate(&m_useCompressDeflate); NS_ADDREF(m_flagState); - m_hostSessionList = aHostSessionList; // no ref count...host session list has life time > connection + m_hostSessionList = aHostSessionList; m_parser.SetHostSessionList(aHostSessionList); m_parser.SetFlagState(m_flagState); diff --git a/mailnews/imap/src/nsImapProtocol.h b/mailnews/imap/src/nsImapProtocol.h index 53db32f96..ba2594c89 100644 --- a/mailnews/imap/src/nsImapProtocol.h +++ b/mailnews/imap/src/nsImapProtocol.h @@ -619,7 +619,7 @@ private: nsDataHashtable m_specialXListMailboxes; - nsIImapHostSessionList * m_hostSessionList; + nsCOMPtr m_hostSessionList; bool m_fromHeaderSeen; -- cgit v1.2.3