From 201683afe4596ae32f7b1ea12dfca52995d59f9d Mon Sep 17 00:00:00 2001 From: "Matt A. Tobin" Date: Sun, 10 Nov 2019 19:11:03 -0500 Subject: Bug 1487082 - Resolve potential for build bustage regarding bad implicit conversion constructors * Part 1: make conversion CTORs explicit. Minor tweaks to conform with new(ish) static analysis rule which flags up implicit single-argument conversion constructors. * Part 2: fix a couple of double-mRefCnt declaration errors. * Part 3: Fix unsafe use of NS_ConvertASCIItoUTF16(). Tag #1273 --- mailnews/mime/src/nsSimpleMimeConverterStub.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'mailnews/mime/src/nsSimpleMimeConverterStub.cpp') diff --git a/mailnews/mime/src/nsSimpleMimeConverterStub.cpp b/mailnews/mime/src/nsSimpleMimeConverterStub.cpp index 50dcf27fd..ca608b54c 100644 --- a/mailnews/mime/src/nsSimpleMimeConverterStub.cpp +++ b/mailnews/mime/src/nsSimpleMimeConverterStub.cpp @@ -164,7 +164,7 @@ MimeSimpleStubClassInitialize(MimeSimpleStubClass *clazz) class nsSimpleMimeConverterStub : public nsIMimeContentTypeHandler { public: - nsSimpleMimeConverterStub(const char *aContentType) : mContentType(aContentType) { } + explicit nsSimpleMimeConverterStub(const char *aContentType) : mContentType(aContentType) { } NS_DECL_ISUPPORTS -- cgit v1.2.3