From 201683afe4596ae32f7b1ea12dfca52995d59f9d Mon Sep 17 00:00:00 2001 From: "Matt A. Tobin" Date: Sun, 10 Nov 2019 19:11:03 -0500 Subject: Bug 1487082 - Resolve potential for build bustage regarding bad implicit conversion constructors * Part 1: make conversion CTORs explicit. Minor tweaks to conform with new(ish) static analysis rule which flags up implicit single-argument conversion constructors. * Part 2: fix a couple of double-mRefCnt declaration errors. * Part 3: Fix unsafe use of NS_ConvertASCIItoUTF16(). Tag #1273 --- mailnews/local/src/nsMailboxProtocol.h | 2 +- mailnews/local/src/nsParseMailbox.h | 2 +- mailnews/local/src/nsPop3Protocol.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) (limited to 'mailnews/local') diff --git a/mailnews/local/src/nsMailboxProtocol.h b/mailnews/local/src/nsMailboxProtocol.h index 53c65b40f..e030c8d7c 100644 --- a/mailnews/local/src/nsMailboxProtocol.h +++ b/mailnews/local/src/nsMailboxProtocol.h @@ -50,7 +50,7 @@ class nsMailboxProtocol : public nsMsgProtocol public: // Creating a protocol instance requires the URL which needs to be run AND it requires // a transport layer. - nsMailboxProtocol(nsIURI * aURL); + explicit nsMailboxProtocol(nsIURI * aURL); virtual ~nsMailboxProtocol(); // initialization function given a new url and transport layer diff --git a/mailnews/local/src/nsParseMailbox.h b/mailnews/local/src/nsParseMailbox.h index aac40611a..646cfd533 100644 --- a/mailnews/local/src/nsParseMailbox.h +++ b/mailnews/local/src/nsParseMailbox.h @@ -133,7 +133,7 @@ protected: class nsMsgMailboxParser : public nsIStreamListener, public nsParseMailMessageState, public nsMsgLineBuffer { public: - nsMsgMailboxParser(nsIMsgFolder *); + explicit nsMsgMailboxParser(nsIMsgFolder *); nsMsgMailboxParser(); nsresult Init(); diff --git a/mailnews/local/src/nsPop3Protocol.h b/mailnews/local/src/nsPop3Protocol.h index a937427d1..a332eae84 100644 --- a/mailnews/local/src/nsPop3Protocol.h +++ b/mailnews/local/src/nsPop3Protocol.h @@ -254,7 +254,7 @@ class nsPop3Protocol : public nsMsgProtocol, public nsIMsgAsyncPromptListener { public: - nsPop3Protocol(nsIURI* aURL); + explicit nsPop3Protocol(nsIURI* aURL); NS_DECL_ISUPPORTS_INHERITED NS_DECL_NSIPOP3PROTOCOL -- cgit v1.2.3