From 201683afe4596ae32f7b1ea12dfca52995d59f9d Mon Sep 17 00:00:00 2001 From: "Matt A. Tobin" Date: Sun, 10 Nov 2019 19:11:03 -0500 Subject: Bug 1487082 - Resolve potential for build bustage regarding bad implicit conversion constructors * Part 1: make conversion CTORs explicit. Minor tweaks to conform with new(ish) static analysis rule which flags up implicit single-argument conversion constructors. * Part 2: fix a couple of double-mRefCnt declaration errors. * Part 3: Fix unsafe use of NS_ConvertASCIItoUTF16(). Tag #1273 --- mailnews/local/src/nsMailboxProtocol.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'mailnews/local/src/nsMailboxProtocol.h') diff --git a/mailnews/local/src/nsMailboxProtocol.h b/mailnews/local/src/nsMailboxProtocol.h index 53c65b40f..e030c8d7c 100644 --- a/mailnews/local/src/nsMailboxProtocol.h +++ b/mailnews/local/src/nsMailboxProtocol.h @@ -50,7 +50,7 @@ class nsMailboxProtocol : public nsMsgProtocol public: // Creating a protocol instance requires the URL which needs to be run AND it requires // a transport layer. - nsMailboxProtocol(nsIURI * aURL); + explicit nsMailboxProtocol(nsIURI * aURL); virtual ~nsMailboxProtocol(); // initialization function given a new url and transport layer -- cgit v1.2.3