From 201683afe4596ae32f7b1ea12dfca52995d59f9d Mon Sep 17 00:00:00 2001 From: "Matt A. Tobin" Date: Sun, 10 Nov 2019 19:11:03 -0500 Subject: Bug 1487082 - Resolve potential for build bustage regarding bad implicit conversion constructors * Part 1: make conversion CTORs explicit. Minor tweaks to conform with new(ish) static analysis rule which flags up implicit single-argument conversion constructors. * Part 2: fix a couple of double-mRefCnt declaration errors. * Part 3: Fix unsafe use of NS_ConvertASCIItoUTF16(). Tag #1273 --- mailnews/jsaccount/src/JaMsgFolder.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'mailnews/jsaccount/src/JaMsgFolder.h') diff --git a/mailnews/jsaccount/src/JaMsgFolder.h b/mailnews/jsaccount/src/JaMsgFolder.h index 514d6e07f..d1b7d37aa 100644 --- a/mailnews/jsaccount/src/JaMsgFolder.h +++ b/mailnews/jsaccount/src/JaMsgFolder.h @@ -89,7 +89,7 @@ private: // Why fake this? Because this method is fully owned by // JaCppMsgFolderDelegator, and this reference is to the "this" of the // main method. But it is not really the local "this". - Super(JaCppMsgFolderDelegator* aFakeThis) {mFakeThis = aFakeThis;} + explicit Super(JaCppMsgFolderDelegator* aFakeThis) {mFakeThis = aFakeThis;} NS_DECL_ISUPPORTS NS_FORWARD_NSIMSGFOLDER(mFakeThis->JaBaseCppMsgFolder::) NS_FORWARD_NSIRDFRESOURCE(mFakeThis->JaBaseCppMsgFolder::) -- cgit v1.2.3