From 201683afe4596ae32f7b1ea12dfca52995d59f9d Mon Sep 17 00:00:00 2001 From: "Matt A. Tobin" Date: Sun, 10 Nov 2019 19:11:03 -0500 Subject: Bug 1487082 - Resolve potential for build bustage regarding bad implicit conversion constructors * Part 1: make conversion CTORs explicit. Minor tweaks to conform with new(ish) static analysis rule which flags up implicit single-argument conversion constructors. * Part 2: fix a couple of double-mRefCnt declaration errors. * Part 3: Fix unsafe use of NS_ConvertASCIItoUTF16(). Tag #1273 --- mailnews/jsaccount/src/JaIncomingServer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'mailnews/jsaccount/src/JaIncomingServer.h') diff --git a/mailnews/jsaccount/src/JaIncomingServer.h b/mailnews/jsaccount/src/JaIncomingServer.h index 5b0362324..cac0dfce4 100644 --- a/mailnews/jsaccount/src/JaIncomingServer.h +++ b/mailnews/jsaccount/src/JaIncomingServer.h @@ -63,7 +63,7 @@ private: public nsIInterfaceRequestor { public: - Super(JaCppIncomingServerDelegator* aFakeThis) {mFakeThis = aFakeThis;} + explicit Super(JaCppIncomingServerDelegator* aFakeThis) {mFakeThis = aFakeThis;} NS_DECL_ISUPPORTS // Forward all overridable methods, bypassing JS override. NS_FORWARD_NSIMSGINCOMINGSERVER(mFakeThis->JaBaseCppIncomingServer::) -- cgit v1.2.3