From 201683afe4596ae32f7b1ea12dfca52995d59f9d Mon Sep 17 00:00:00 2001 From: "Matt A. Tobin" Date: Sun, 10 Nov 2019 19:11:03 -0500 Subject: Bug 1487082 - Resolve potential for build bustage regarding bad implicit conversion constructors * Part 1: make conversion CTORs explicit. Minor tweaks to conform with new(ish) static analysis rule which flags up implicit single-argument conversion constructors. * Part 2: fix a couple of double-mRefCnt declaration errors. * Part 3: Fix unsafe use of NS_ConvertASCIItoUTF16(). Tag #1273 --- mailnews/imap/src/nsImapMailFolder.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'mailnews/imap/src/nsImapMailFolder.cpp') diff --git a/mailnews/imap/src/nsImapMailFolder.cpp b/mailnews/imap/src/nsImapMailFolder.cpp index 12e687360..4ed12a026 100644 --- a/mailnews/imap/src/nsImapMailFolder.cpp +++ b/mailnews/imap/src/nsImapMailFolder.cpp @@ -6363,7 +6363,7 @@ NS_IMETHODIMP nsImapMailFolder::GetOtherUsersWithAccess( class AdoptUTF8StringEnumerator final : public nsIUTF8StringEnumerator { public: - AdoptUTF8StringEnumerator(nsTArray* array) : + explicit AdoptUTF8StringEnumerator(nsTArray* array) : mStrings(array), mIndex(0) {} -- cgit v1.2.3