From 711a5031d015a9fde7feb61905473b52d9cc3369 Mon Sep 17 00:00:00 2001 From: "Matt A. Tobin" Date: Sun, 3 Nov 2019 22:50:47 -0500 Subject: Issue #1258 - Part 7: UXP Specific fixes * This includes Bug 1326433 for Janek fallout (ldap already had this fix) --- mailnews/base/src/nsMessengerWinIntegration.cpp | 16 ++++------------ mailnews/base/src/nsMessengerWinIntegration.h | 18 ------------------ mailnews/base/util/nsMsgMailNewsUrl.cpp | 3 ++- mailnews/base/util/nsMsgMailNewsUrl.h | 1 - 4 files changed, 6 insertions(+), 32 deletions(-) (limited to 'mailnews/base') diff --git a/mailnews/base/src/nsMessengerWinIntegration.cpp b/mailnews/base/src/nsMessengerWinIntegration.cpp index a014b9737..98888fcb3 100644 --- a/mailnews/base/src/nsMessengerWinIntegration.cpp +++ b/mailnews/base/src/nsMessengerWinIntegration.cpp @@ -56,7 +56,6 @@ #define NOTIFICATIONCLASSNAME "MailBiffNotificationMessageWindow" #define UNREADMAILNODEKEY "Software\\Microsoft\\Windows\\CurrentVersion\\UnreadMail\\" -#define SHELL32_DLL L"shell32.dll" #define DOUBLE_QUOTE "\"" #define MAIL_COMMANDLINE_ARG " -mail" #define IDI_MAILBIFF 32576 @@ -336,14 +335,6 @@ nsMessengerWinIntegration::Init() { nsresult rv; - // Get shell32.dll handle - HMODULE hModule = ::GetModuleHandleW(SHELL32_DLL); - - if (hModule) { - // SHQueryUserNotificationState is available from Vista - mSHQueryUserNotificationState = (fnSHQueryUserNotificationState)GetProcAddress(hModule, "SHQueryUserNotificationState"); - } - nsCOMPtr accountManager = do_GetService(NS_MSGACCOUNTMANAGER_CONTRACTID, &rv); NS_ENSURE_SUCCESS(rv,rv); @@ -492,9 +483,10 @@ nsresult nsMessengerWinIntegration::ShowNewAlertNotification(bool aUserInitiated prefBranch->GetBoolPref(SHOW_ALERT_PREF, &showAlert); // check if we are allowed to show a notification - if (showAlert && mSHQueryUserNotificationState) { - MOZ_QUERY_USER_NOTIFICATION_STATE qstate; - if (SUCCEEDED(mSHQueryUserNotificationState(&qstate))) { + if (showAlert) { + QUERY_USER_NOTIFICATION_STATE qstate; + + if (SUCCEEDED(SHQueryUserNotificationState(&qstate))) { if (qstate != QUNS_ACCEPTS_NOTIFICATIONS) { showAlert = false; } diff --git a/mailnews/base/src/nsMessengerWinIntegration.h b/mailnews/base/src/nsMessengerWinIntegration.h index 6c49a71c2..344e05e76 100644 --- a/mailnews/base/src/nsMessengerWinIntegration.h +++ b/mailnews/base/src/nsMessengerWinIntegration.h @@ -20,22 +20,6 @@ #include "nsIMutableArray.h" #include "nsIObserver.h" -typedef enum tagMOZ_QUERY_USER_NOTIFICATION_STATE { - QUNS_NOT_PRESENT = 1, - QUNS_BUSY = 2, - QUNS_RUNNING_D3D_FULL_SCREEN = 3, - QUNS_PRESENTATION_MODE = 4, - QUNS_ACCEPTS_NOTIFICATIONS = 5, - QUNS_QUIET_TIME = 6 -} MOZ_QUERY_USER_NOTIFICATION_STATE; - -// this function is exported by shell32.dll on Windows Vista or later -extern "C" -{ -// Vista or later -typedef HRESULT (__stdcall *fnSHQueryUserNotificationState)(MOZ_QUERY_USER_NOTIFICATION_STATE *pquns); -} - #define NS_MESSENGERWININTEGRATION_CID \ {0xf62f3d3a, 0x1dd1, 0x11b2, \ {0xa5, 0x16, 0xef, 0xad, 0xb1, 0x31, 0x61, 0x5c}} @@ -105,8 +89,6 @@ private: nsCOMPtr mTotalUnreadMessagesAtom; nsCOMPtr mUnreadCountUpdateTimer; - fnSHQueryUserNotificationState mSHQueryUserNotificationState; - nsCString mInboxURI; nsCString mEmail; diff --git a/mailnews/base/util/nsMsgMailNewsUrl.cpp b/mailnews/base/util/nsMsgMailNewsUrl.cpp index e9dc52b33..17f95fc30 100644 --- a/mailnews/base/util/nsMsgMailNewsUrl.cpp +++ b/mailnews/base/util/nsMsgMailNewsUrl.cpp @@ -82,7 +82,6 @@ NS_INTERFACE_MAP_BEGIN(nsMsgMailNewsUrl) NS_INTERFACE_MAP_ENTRY_AMBIGUOUS(nsISupports, nsIMsgMailNewsUrl) NS_INTERFACE_MAP_ENTRY(nsIMsgMailNewsUrl) NS_INTERFACE_MAP_ENTRY(nsIURL) - NS_INTERFACE_MAP_ENTRY(nsIURIWithQuery) NS_INTERFACE_MAP_ENTRY(nsIURI) NS_INTERFACE_MAP_ENTRY_CONDITIONAL(nsIURIWithPrincipal, !m_isPrincipalURL) NS_INTERFACE_MAP_END @@ -127,6 +126,8 @@ NS_IMETHODIMP nsMsgMailNewsUrl::GetPrincipalUri(nsIURI **aPrincipalURI) return m_principal->GetURI(aPrincipalURI); } +// NS_IMPL_ISUPPORTS(nsMsgMailNewsUrl, nsIMsgMailNewsUrl, nsIURL, nsIURI) + //////////////////////////////////////////////////////////////////////////////////// // Begin nsIMsgMailNewsUrl specific support //////////////////////////////////////////////////////////////////////////////////// diff --git a/mailnews/base/util/nsMsgMailNewsUrl.h b/mailnews/base/util/nsMsgMailNewsUrl.h index 5833dfef1..61fd4827e 100644 --- a/mailnews/base/util/nsMsgMailNewsUrl.h +++ b/mailnews/base/util/nsMsgMailNewsUrl.h @@ -46,7 +46,6 @@ public: NS_DECL_THREADSAFE_ISUPPORTS NS_DECL_NSIMSGMAILNEWSURL NS_DECL_NSIURI - NS_DECL_NSIURIWITHQUERY NS_DECL_NSIURL NS_DECL_NSIURIWITHPRINCIPAL -- cgit v1.2.3