From 81b341a9b37acae2b60e0334a9b0846bc5be8445 Mon Sep 17 00:00:00 2001 From: wolfbeast Date: Sat, 29 Sep 2018 23:20:36 +0200 Subject: Clean up a number of unused variables. Tag #21. --- extensions/cookie/nsPermissionManager.cpp | 6 ------ 1 file changed, 6 deletions(-) (limited to 'extensions') diff --git a/extensions/cookie/nsPermissionManager.cpp b/extensions/cookie/nsPermissionManager.cpp index 13ae7fd35..2c2e2d79c 100644 --- a/extensions/cookie/nsPermissionManager.cpp +++ b/extensions/cookie/nsPermissionManager.cpp @@ -1076,8 +1076,6 @@ nsPermissionManager::InitDB(bool aRemoveFile) bool hostsTableExists = false; mDBConn->TableExists(NS_LITERAL_CSTRING("moz_hosts"), &hostsTableExists); if (hostsTableExists) { - bool migrationError = false; - // Both versions 4 and 6 have a version 4 formatted hosts table named // moz_hosts. We can migrate this table to our version 7 table moz_perms. // If moz_perms is present, then we can use it as a basis for comparison. @@ -1125,12 +1123,10 @@ nsPermissionManager::InitDB(bool aRemoveFile) // Read in the old row rv = stmt->GetUTF8String(0, host); if (NS_WARN_IF(NS_FAILED(rv))) { - migrationError = true; continue; } rv = stmt->GetUTF8String(1, type); if (NS_WARN_IF(NS_FAILED(rv))) { - migrationError = true; continue; } permission = stmt->AsInt32(2); @@ -1138,7 +1134,6 @@ nsPermissionManager::InitDB(bool aRemoveFile) expireTime = stmt->AsInt64(4); modificationTime = stmt->AsInt64(5); if (NS_WARN_IF(stmt->AsInt64(6) < 0)) { - migrationError = true; continue; } appId = static_cast(stmt->AsInt64(6)); @@ -1155,7 +1150,6 @@ nsPermissionManager::InitDB(bool aRemoveFile) if (NS_FAILED(rv)) { NS_WARNING("Unexpected failure when upgrading migrating permission " "from host to origin"); - migrationError = true; } } -- cgit v1.2.3 From e8f913da98fdc9b2c0777dcbebd93bf64feb1dab Mon Sep 17 00:00:00 2001 From: wolfbeast Date: Thu, 1 Nov 2018 20:16:49 +0100 Subject: Reorder boolean expression to take advantage of short-circuiting. --- extensions/spellcheck/src/mozEnglishWordUtils.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'extensions') diff --git a/extensions/spellcheck/src/mozEnglishWordUtils.cpp b/extensions/spellcheck/src/mozEnglishWordUtils.cpp index 5033b247b..671b22c16 100644 --- a/extensions/spellcheck/src/mozEnglishWordUtils.cpp +++ b/extensions/spellcheck/src/mozEnglishWordUtils.cpp @@ -165,7 +165,7 @@ NS_IMETHODIMP mozEnglishWordUtils::FindNextWord(const char16_t *word, uint32_t l // before we spend more time looking to see if the word is a url, look for a url identifer // and make sure that identifer isn't the last character in the word fragment. - if ( (*p == ':' || *p == '@' || *p == '.') && p < endbuf - 1) { + if ( (p < endbuf - 1) && (*p == ':' || *p == '@' || *p == '.') ) { // ok, we have a possible url...do more research to find out if we really have one // and determine the length of the url so we can skip over it. -- cgit v1.2.3