From d6baead6c8bcd90f04d62908bfaf73b369df4e6f Mon Sep 17 00:00:00 2001 From: wolfbeast Date: Fri, 20 Dec 2019 23:08:47 +0100 Subject: Issue #1219 - Align computed DOM styles with mainstream behvior. This updates our behavior for computed DOM styling to no longer return null on elements that have no display, but return a 0-length (empty) style instead and don't throw. For this we stop looking at having a presentation for the style and just look at the document instead. This resolves #1219 --- editor/libeditor/CSSEditUtils.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 'editor') diff --git a/editor/libeditor/CSSEditUtils.cpp b/editor/libeditor/CSSEditUtils.cpp index 5199838c0..d8146ca65 100644 --- a/editor/libeditor/CSSEditUtils.cpp +++ b/editor/libeditor/CSSEditUtils.cpp @@ -569,11 +569,8 @@ CSSEditUtils::GetComputedStyle(Element* aElement) nsIDocument* doc = aElement->GetUncomposedDoc(); NS_ENSURE_TRUE(doc, nullptr); - nsIPresShell* presShell = doc->GetShell(); - NS_ENSURE_TRUE(presShell, nullptr); - RefPtr style = - NS_NewComputedDOMStyle(aElement, EmptyString(), presShell); + NS_NewComputedDOMStyle(aElement, EmptyString(), doc); return style.forget(); } -- cgit v1.2.3