From 71fd51a863171d9f462d1311749de717361406a6 Mon Sep 17 00:00:00 2001 From: janekptacijarabaci Date: Fri, 2 Mar 2018 14:59:24 +0100 Subject: Bug 1320362: Move indexedDb storage type in the storage inspector into a new column Issue #31 --- devtools/server/actors/storage.js | 8 +++++++- devtools/server/tests/browser/browser_storage_listings.js | 8 ++++---- 2 files changed, 11 insertions(+), 5 deletions(-) (limited to 'devtools/server') diff --git a/devtools/server/actors/storage.js b/devtools/server/actors/storage.js index 22f4eaabe..f4fbbd8c3 100644 --- a/devtools/server/actors/storage.js +++ b/devtools/server/actors/storage.js @@ -1463,7 +1463,9 @@ DatabaseMetadata.prototype = { toObject() { return { - name: `${this._name} (${this.storage})`, + uniqueKey: `${this._name}${SEPARATOR_GUID}${this.storage}`, + name: this._name, + storage: this.storage, origin: this._origin, version: this._version, objectStores: this._objectStores.size @@ -1671,7 +1673,9 @@ StorageActors.createActor({ if ("objectStores" in item) { // DB meta data return { + uniqueKey: `${item.name} (${item.storage})`, db: item.name, + storage: item.storage, origin: item.origin, version: item.version, objectStores: item.objectStores @@ -1813,7 +1817,9 @@ StorageActors.createActor({ // Detail of indexedDB for one origin default: return [ + { name: "uniqueKey", editable: false, private: true }, { name: "db", editable: false }, + { name: "storage", editable: false }, { name: "origin", editable: false }, { name: "version", editable: false }, { name: "objectStores", editable: false }, diff --git a/devtools/server/tests/browser/browser_storage_listings.js b/devtools/server/tests/browser/browser_storage_listings.js index 15e5ccd50..e47a320b8 100644 --- a/devtools/server/tests/browser/browser_storage_listings.js +++ b/devtools/server/tests/browser/browser_storage_listings.js @@ -470,17 +470,17 @@ var testIndexedDBs = Task.async(function* (index, hosts, indexedDBActor) { for (let item of data.data) { let found = false; for (let toMatch of IDBValues.dbDetails[host]) { - if (item.db == toMatch.db) { + if (item.uniqueKey == toMatch.db) { found = true; - ok(true, "Found indexed db " + item.db + " in response"); + ok(true, "Found indexed db " + item.uniqueKey + " in response"); is(item.origin, toMatch.origin, "The origin matches."); is(item.version, toMatch.version, "The version matches."); is(item.objectStores, toMatch.objectStores, - "The numebr of object stores matches."); + "The number of object stores matches."); break; } } - ok(found, "indexed db " + item.name + " should exist in response"); + ok(found, "indexed db " + item.uniqueKey + " should exist in response"); } }; -- cgit v1.2.3