From 879619491f79870170abb0d398ab6a5c506984b0 Mon Sep 17 00:00:00 2001 From: Valentin Gosu Date: Sun, 11 Feb 2018 03:51:09 +0100 Subject: Bug 1334465 - Set mIPCClosed to true before calling SendDeleteSelf in order to avoid race. r=bagder, a=ritu In the previous code, a race condition could cause us to call SendSetPriority() after calling SendDeleteSelf. For example: T1: SendDeleteSelf() T2: if (!mIPCClosed) SendSetPriority() T1: mIPCClosed = true MozReview-Commit-ID: 3XOwCaphb2o --HG-- extra : rebase_source : d6e6886402d1e0b0afed23c25a9fb18d8ca29ad6 extra : intermediate-source : cfc9afe916091e6449f7d748991e2a19187dc817 extra : source : 4ebdab0e332892378558817e30d0138c95199ce5 --- netwerk/protocol/http/HttpChannelParent.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/netwerk/protocol/http/HttpChannelParent.cpp b/netwerk/protocol/http/HttpChannelParent.cpp index fe076a237..5f0859f28 100644 --- a/netwerk/protocol/http/HttpChannelParent.cpp +++ b/netwerk/protocol/http/HttpChannelParent.cpp @@ -1772,8 +1772,8 @@ HttpChannelParent::UpdateAndSerializeSecurityInfo(nsACString& aSerializedSecurit bool HttpChannelParent::DoSendDeleteSelf() { - bool rv = SendDeleteSelf(); mIPCClosed = true; + bool rv = SendDeleteSelf(); return rv; } -- cgit v1.2.3