From 6e457e653e5c4b2a92a2a7adc1ea6bcdc2d39a5f Mon Sep 17 00:00:00 2001 From: adeshkp Date: Thu, 14 Mar 2019 09:49:51 -0400 Subject: Fix a warning about method override --- dom/ipc/ContentChild.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dom/ipc/ContentChild.h b/dom/ipc/ContentChild.h index f29d17e7f..4c8f15cc0 100644 --- a/dom/ipc/ContentChild.h +++ b/dom/ipc/ContentChild.h @@ -152,13 +152,13 @@ public: RecvInitRendering( Endpoint&& aCompositor, Endpoint&& aImageBridge, - Endpoint&& aVideoManager); + Endpoint&& aVideoManager) override; bool RecvReinitRendering( Endpoint&& aCompositor, Endpoint&& aImageBridge, - Endpoint&& aVideoManager); + Endpoint&& aVideoManager) override; PProcessHangMonitorChild* AllocPProcessHangMonitorChild(Transport* aTransport, -- cgit v1.2.3 From 52be954e59b3ef06b7e8bfa28630e1005351d183 Mon Sep 17 00:00:00 2001 From: adeshkp Date: Thu, 14 Mar 2019 09:52:03 -0400 Subject: Fix order of member variables in a couple of initializer lists --- image/imgFrame.cpp | 2 +- security/manager/ssl/nsSiteSecurityService.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/image/imgFrame.cpp b/image/imgFrame.cpp index c9f44181d..d982c17c4 100644 --- a/image/imgFrame.cpp +++ b/image/imgFrame.cpp @@ -161,13 +161,13 @@ imgFrame::imgFrame() : mMonitor("imgFrame") , mDecoded(0, 0, 0, 0) , mLockCount(0) + , mHasNoAlpha(false) , mAborted(false) , mFinished(false) , mOptimizable(false) , mTimeout(FrameTimeout::FromRawMilliseconds(100)) , mDisposalMethod(DisposalMethod::NOT_SPECIFIED) , mBlendMethod(BlendMethod::OVER) - , mHasNoAlpha(false) , mPalettedImageData(nullptr) , mPaletteDepth(0) , mNonPremult(false) diff --git a/security/manager/ssl/nsSiteSecurityService.cpp b/security/manager/ssl/nsSiteSecurityService.cpp index fc38f4e64..cfee79d8d 100644 --- a/security/manager/ssl/nsSiteSecurityService.cpp +++ b/security/manager/ssl/nsSiteSecurityService.cpp @@ -210,8 +210,8 @@ const uint64_t kSixtyDaysInSeconds = 60 * 24 * 60 * 60; nsSiteSecurityService::nsSiteSecurityService() : mMaxMaxAge(kSixtyDaysInSeconds) , mUsePreloadList(true) - , mPreloadListTimeOffset(0) , mUseStsService(true) + , mPreloadListTimeOffset(0) { } -- cgit v1.2.3 From 90d1ee25b1de235847605fbc95a9ddebcf5c061d Mon Sep 17 00:00:00 2001 From: adeshkp Date: Thu, 14 Mar 2019 09:53:02 -0400 Subject: Remove a couple of unused variables --- js/src/jit/StupidAllocator.cpp | 1 - js/src/vm/ObjectGroup.cpp | 1 - 2 files changed, 2 deletions(-) diff --git a/js/src/jit/StupidAllocator.cpp b/js/src/jit/StupidAllocator.cpp index 8e3ea6286..55431e8e0 100644 --- a/js/src/jit/StupidAllocator.cpp +++ b/js/src/jit/StupidAllocator.cpp @@ -407,7 +407,6 @@ StupidAllocator::allocateForDefinition(LInstruction* ins, LDefinition* def) { uint32_t vreg = def->virtualRegister(); - CodePosition from; if ((def->output()->isRegister() && def->policy() == LDefinition::FIXED) || def->policy() == LDefinition::MUST_REUSE_INPUT) { diff --git a/js/src/vm/ObjectGroup.cpp b/js/src/vm/ObjectGroup.cpp index 1fbf8976b..46159a972 100644 --- a/js/src/vm/ObjectGroup.cpp +++ b/js/src/vm/ObjectGroup.cpp @@ -495,7 +495,6 @@ ObjectGroup::defaultNewGroup(ExclusiveContext* cx, const Class* clasp, if (associated->is()) { // Canonicalize new functions to use the original one associated with its script. - JSFunction* fun = &associated->as(); associated = associated->as().maybeCanonicalFunction(); // If we have previously cleared the 'new' script information for this -- cgit v1.2.3 From cf36d986290114b6dd1fcdac6c08283178629742 Mon Sep 17 00:00:00 2001 From: adeshkp Date: Thu, 14 Mar 2019 09:54:30 -0400 Subject: Fix warnings about unreachable code in cubeb --- media/libcubeb/src/cubeb.c | 2 +- media/libcubeb/src/cubeb_audiounit.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/media/libcubeb/src/cubeb.c b/media/libcubeb/src/cubeb.c index e0375c394..eb22a9b94 100644 --- a/media/libcubeb/src/cubeb.c +++ b/media/libcubeb/src/cubeb.c @@ -562,7 +562,7 @@ int cubeb_set_log_callback(cubeb_log_level log_level, void cubeb_crash() { - abort(); *((volatile int *) NULL) = 0; + abort(); } diff --git a/media/libcubeb/src/cubeb_audiounit.cpp b/media/libcubeb/src/cubeb_audiounit.cpp index f24dfbff2..9483c2795 100644 --- a/media/libcubeb/src/cubeb_audiounit.cpp +++ b/media/libcubeb/src/cubeb_audiounit.cpp @@ -1443,12 +1443,12 @@ audiounit_set_buffer_size(cubeb_stream * stm, uint32_t new_size_frames, set_buff buffer_size_changed_callback, stm); if (r != noErr) { - return CUBEB_ERROR; if (set_side == INPUT) { PRINT_ERROR_CODE("AudioUnitAddPropertyListener/input/kAudioDevicePropertyBufferFrameSize", r); } else { PRINT_ERROR_CODE("AudioUnitAddPropertyListener/output/kAudioDevicePropertyBufferFrameSize", r); } + return CUBEB_ERROR; } if (!stm->buffer_size_change_state && count >= 30) { -- cgit v1.2.3