summaryrefslogtreecommitdiffstats
path: root/memory
Commit message (Collapse)AuthorAgeLines
* Revert "Issue #1699 - Part 3a: mozjemalloc: Memory barriers on ↵Olivier Certner2021-01-07-12/+2
| | | | | | | | | 'malloc_initialized'" This reverts commit f76695c1ce032b634f3e0e2a593aebdd1d49703b. SUSv4 specifies that 'pthread_create' acts as a (full) memory barrier, so barriers here are not necessary.
* Issue #1699 - Part 3b: mozjemalloc: Bootstrap allocator, early diversion for ↵Olivier Certner2021-01-07-42/+294
| | | | | | | | | | | | | | | | | | | | FreeBSD Coded a simple memory allocator meant to be used during jemalloc bootstrap (malloc_init_hard()). Although protected by "#ifdef __FreeBSD__", it is not FreeBSD-specific: Any POSIX platform could use it. Hook it so that it is used in place of jemalloc's own routines while malloc_init_hard() is executing or memory for mutexes is being allocated. Currently, 'malloc', 'calloc', '*memalign' and 'free' are diverted during init or lock initializations. Details are quite complex, see the big comment block starting with "There are several problematic interactions between FreeBSD's libthr and this jemalloc." for more explanations. Also replaced ad-hoc BSD code to determine the number of CPUs with 'sysconf', which is POSIX-compliant (and supported on modern BSDs).
* Issue #1699 - Part 3a: mozjemalloc: Memory barriers on 'malloc_initialized'Olivier Certner2021-01-07-2/+12
| | | | | | | | | | | | | | | The barriers are here to make sure that setting 'malloc_initialized' at end of init must be noticed later by any thread running on a different core. They are in theory necessary in the absence of an explicit pthread lock. What could happen is that the thread doing the initialization later spawns other threads that could not have the updated 'malloc_initialized' value, leading to a second initialization. This is dependent on whether OSes force a full memory barrier before the new thread is run, which I don't know, and don't want to bother. This was done for FreeBSD only, for the sake of robustness. In theory, this would be needed on Windows too.
* Issue #1667 - Part 1: Define _pthread_self if it is not already defined in ↵Brian Smith2020-11-16-0/+3
| | | | jemalloc
* Issue #1656 - Part 6: Clean up the build filesMoonchild2020-09-23-14/+0
|
* Issue #1656 - Part 1: Nuke most vim config lines in the tree.Moonchild2020-09-23-6/+0
| | | | | | Since these are just interpreted comments, there's 0 impact on actual code. This removes all lines that match /* vim: set(.*)tw=80: */ with S&R -- there are a few others scattered around which will be removed manually in a second part.
* Issue #1571 - Remove JEMALLOC_USES_MAP_ALIGN and fix 48-bit addressing on ↵athenian2002020-05-31-42/+4
| | | | | | | | | | | | | | | | SunOS AMD64. The JEMALLOC_USES_MAP_ALIGN code has turned out to be worse than useless, and in fact it breaks 64-bit SunOS. It's very old and turned out not to be needed anymore because the way the memory allocator works has changed since it was implemented. It prevented a fix I tried for 48-bit addressing from working properly. However, without either this code or the 48-bit addressing fix, the 64-bit version won't even start, which is why I thought the code was still needed. https://bugzilla.mozilla.org/show_bug.cgi?id=457189 https://hg.mozilla.org/mozilla-central/rev/a26c500b98ab The 48-bit addressing fix is based on code found here: https://github.com/OpenIndiana/oi-userland/blob/oi/hipster/components/web/firefox/patches/patch-js_src_gc_Memory.cpp.patch I already applied these changes to js/src/gc/Memory.cpp, but as I was looking through jemalloc.c I saw that there were very similar ifdefs for Linux on SPARC as the ones I'd had to enaable in Memory.cpp, but for whatever reason the patches I found didn't touch them. So I tried doing for jemalloc.c what was already done for Memory.cpp, and it worked (but only after I removed the map align code).
* Issue #1471 - Fix building on sparc64 LinuxJMadgwick2020-03-09-3/+26
| | | | | Correct various pre-processor defines for sparc64 and in mozjemalloc use the JS arm64 allocator on Linux/sparc64. This corrects build problems opn Linux sparc64 and is in line with bugzilla bug #1275204.
* Issue #1053 - Remove android support from memoryMatt A. Tobin2020-02-23-374/+19
|
* Issue #1307 - Part 8: Remove deprecated sysctl.h inclusion.wolfbeast2019-12-02-3/+0
|
* Issue #1307 - Part 7: Add missing MALLOC_STATSwolfbeast2019-11-30-1/+2
|
* Issue #1307 - Part 6: Remove dead code behind PTHREAD_MMAP_UNALIGNED_TSDwolfbeast2019-11-30-6/+0
|
* Issue #1307 - Part 5: Remove allocation tracing.wolfbeast2019-11-30-99/+1
| | | | Pointless for debugging and a major performance sink.
* Issue #1307 - Part 4: Stop using variable-length arrays.wolfbeast2019-11-30-38/+20
| | | | | | "USING VLA'S IS ACTIVELY STUPID! It generates much more code, and much slower code (and more fragile code), than just using a fixed key size would have done." -- Linus Torvalds
* Issue #1307 - Part 3: Assume MOZ_MEMORY is always enabled.wolfbeast2019-11-30-161/+10
| | | | | | We never use jemalloc without MOZ_MEMORY surrounding code (mostly a FreeBSD concession which doesn't work anyway). This allows us to get rid of the "poor man's mutex" (CPU-based spinlock) in mozjemalloc.
* Issue #1307 - Part 2: Remove disabled code blockswolfbeast2019-11-30-49/+1
|
* Issue #1307 - Part 1: Remove MALLOC_VALIDATEwolfbeast2019-11-30-37/+10
| | | | | | This basic validation is hard-set to always-on, so no point in keeping it conditional since we basically always want this rudimentary pointer validation to be done.
* MoonchildProductions#1251 - Part 13: Redefining abort in C++ requires extern "C"athenian2002019-10-21-1/+1
| | | | | | | | https://bugzilla.mozilla.org/show_bug.cgi?id=1375467 I would ifdef this, but it's been in Firefox since version of 56, and Petr Sumbara's explanation as to why it's wrong in the first place is so detailed that it's pretty obvious the code wasn't technically doing things properly to begin with. Basically, they tried to redefine a system function after including the header file that declares it, and it caused problems on Solaris because libc functions are imported into the C++ std namespace in a different way that also complies with standards. So the existing implementation is technically bad code on all platforms, the Solaris implementation just uncovered the lack of standards compliance in the Mozilla code.
* MoonchildProductions#1251 - Part 7: All the posix_m* memory-related stuff, ↵athenian2002019-10-21-4/+14
| | | | | | | | | | gathered together. https://bugzilla.mozilla.org/show_bug.cgi?id=1158445 https://bugzilla.mozilla.org/show_bug.cgi?id=963983 https://bugzilla.mozilla.org/show_bug.cgi?id=1542758 Solaris madvise and malign don't perfectly map to their POSIX counterparts, and some Linux versions (especially Android) don't define the POSIX counterparts at all, so options are limited. Ideally posix_madvise and posix_malign should be the safer and more portable options for all platforms.
* MoonchildProductions#1251 - Part 1: Restore initial Solaris support, fixed up.athenian2002019-10-21-1/+20
| | | | | | | | | | | | | | Compared with what Pale Moon had for Solaris originally, this is mostly the same zero point I started patching from, but I've made the following changes here after reviewing all this initial code I never looked at closely before. 1. In package-manifest.in for both Basilisk and Pale Moon, I've made the SPARC code for libfreebl not interefere with the x86 code, use the proper build flags, and also updated it to allow a SPARC64 build which is more likely to be used than the 32-bit SPARC code we had there. 2. See Mozilla bug #832272 and the old rules.mk patch from around Firefox 30 in oracle/solaris-userland. I believe they screwed up NSINSTALL on Solaris when they were trying to streamline the NSS buildsystem, because they started having unexplained issues with it around that time after Firefox 22 that they never properly resolved until Mozilla began building NSS with gyp files. I'm actually not even sure how relevant the thing they broke actually is to Solaris at this point, bug 665509 is so old it predates Firefox itself and goes back to the Mozilla suite days. I believe $(INSTALL) -t was wrong, and they meant $(NSINSTALL) -t because that makes more sense and is closer to what was there originally. It's what they have for WINNT, and it's possible a fix more like that could serve for Solaris as well. Alternatively, we could get rid of all these half-broken Makefiles and start building NSS with gyp files like Mozilla did. 3. I've completely cut out support for the Sun compiler and taken into account the reality that everyone builds Firefox (and therefore its forks) with GCC now on Solaris. This alone helped clean up a lot of the uglier parts of the code. 4. I've updated all remaining SOLARIS build flags to the newer XP_SOLARIS, because the SOLARIS flag is no longer set when building Solaris. 5. I've confirmed the workaround in gtxFontconfigFonts.cpp is no longer necessary. The Solaris people got impatient about implementing a half-baked patch for a fontconfig feature that wasn't ready yet back in 2009, and somehow convinced Mozilla to patch their software to work around it when really they should have just fixed or removed their broken fontconfig patch. The feature they wanted has since been implemented properly, and no version of Solaris still uses the broken patch that required this fix. If anyone had ever properly audited this code, it would have been removed a long time ago.
* Issue #187: Remove solaris 1st party code OS checks.wolfbeast2019-03-30-5/+0
|
* Issue #187: Remove solaris conditional code.wolfbeast2019-03-30-25/+2
|
* Silence the -Wuninitialized warning in mozjemalloctrav902018-09-08-1/+4
| | | | GCC 7+ warns about too many false positives.
* Revert "Switch to using a single memory allocation arena"wolfbeast2018-09-01-1/+1
| | | | This reverts commit 4ceb21241eacac2911f2fed846359215870f121f.
* Switch to using a single memory allocation arenawolfbeast2018-08-25-1/+1
|
* Remove the Dark Matter Detector (DMD) Memeory debugger component.wolfbeast2018-05-23-6153/+0
| | | | This resolves #376.
* Remove MOZ_WIDGET_GONK [2/2]wolfbeast2018-05-13-14/+2
| | | | Tag #288
* Use slim reader/writer locks instead of critical sections.wolfbeast2018-04-28-13/+8
|
* Remove the unused and rudimentary arena load balancer.wolfbeast2018-04-28-252/+4
| | | | | Lock contention is not something we'd easily have to deal with in our application. This simplifies our code.
* Make our allocator use multiple arenas based on number of CPU cores.wolfbeast2018-04-28-21/+19
|
* Remove single-threaded considerations.wolfbeast2018-04-27-52/+30
| | | | We assume our applications are always going to have multithreaded access to the malloc.
* Update credits in BSD-licensed files.wolfbeast2018-04-27-7/+7
|
* Remove jemalloc 4 leftover conditional.wolfbeast2018-04-27-2/+0
|
* Remove MOZ_REPLACE_JEMALLOCwolfbeast2018-04-27-6/+2
| | | | This was only defined when building jemalloc4 as a replace-malloc library.
* Remove jemalloc 4 from our tree.wolfbeast2018-04-27-73367/+4
|
* Remove support for making jemalloc4 the default memory allocator.wolfbeast2018-04-27-361/+15
|
* Remove support for system jemalloc.wolfbeast2018-04-26-48/+29
|
* Bug 1424709 - Force disable the OSX system "nano allocator". r=spohl, a=RyanVMMike Hommey2018-03-14-0/+6
| | | | | | | | | | | We're not actually using it, and it messes up with the zone allocator in mozjemalloc after fork(). See the lengthy analysis in https://bugzilla.mozilla.org/show_bug.cgi?id=1424709#c34 and following. --HG-- extra : rebase_source : b191048290a907cc7668ad7ab6369ef8661f31dc extra : intermediate-source : 45c5d467a46077dcc3ccd59feafd0c2784432fef extra : source : bf1efa161edb20a83fe8db2f96c51f4e66880153
* Use |noexcept| instead of an exception-specification in mozalloc.htrav902018-03-04-0/+6
| | | | We are using |throw(std::bad_alloc)|, but dynamic exception specifications have been deprecated in C++11. The C++11 equivalent is |noexcept(false)|. This causes build warning spam when using newer compilers such as GCC 7.x.
* Add m-esr52 at 52.6.0Matt A. Tobin2018-02-02-0/+94028