| Commit message (Collapse) | Author | Age | Lines |
|
|
|
|
|
|
|
| |
whether they should be drawn.
This reduces the size of display lists for tables by only adding display
list items that are actually going to be visibly drawn, which will help
overall performance of table drawing.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There were actually two separate logical errors in this method:
The first part is that "origSizes.isSome()" is simply a bogus
requirement for applying min/max-sizes here. I'm still keeping
the optimization of not needlessly copying the mSizes array
(as originally intended) since it's a quite common case.
The second bug is that min/max-sizes were only applied under
the "if (fr != 0.0f)" block. This is bogus since the calculated
'fr' value depends on 'aAvailableSize' which might change by
applying min/max-sizes and thus 'fr' could become non-zero in
the second round.
To fix, this patch just moves "applyMinMax" block out one level.
|
| |
|
|
|
|
| |
This reverts commit 44c47c50388f526c2d134e16d5debebe94a0faf8.
|
|
|
|
|
|
| |
additions to the end of it."
This reverts commit efdc2af8ab06c50b85e584ef15deab73b66bec6d.
|
|
|
|
|
|
| |
the end of it.
Layout\reftests\table-background\reftest.list should have only additions to the end of it. Revert incorrect additions.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Part 1: Remove current table item, as it's never set.
Part 2: Get rid of generic table painting code, and handle each class separately.
Part 4: Hoist outline skipping into col(group) frame code.
Part 5: Skip box-shadow for table column and column groups.
Part 6: Store column and column group backgrounds separately, and then append them before the rest of the table contents.
Part 7: Pass rects in display list coordinates to AppendBackgroundItemsToTop.
Part 8: Create column and column group background display items as part of the cell's BuildDisplayList.
Part 9: Used cached values instead of calling nsDisplayListBuilder::ToReferenceFrame when possible, since it can be expensive when the requested frame isn't the builder's current frame.
Part 10: Make sure we build display items for table parts where only the normal position is visible, since we may need to create background items for ancestors at that position.
Part 11: Create an AutoBuildingDisplayList when we create background items for table columns and column groups, so that we initialize the invalidation state correctly.
|
|
|
|
| |
We can devirtualize it, remove some branches.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
This stub is added because websites insist on considering this
very hardware-dependent and O.S.-variable low-level font-control
as a "critical feature" which it isn't as there is 0 guarantee
that font variation settings are supported or honored by any
operating system used by the client.
On top this is a WD status feature that sites shouldn't be using, and
the feature itself is strongly discouraged for use in favor of standard
CSS font manipulation keywords like `font-weight`.
|
|
|
|
|
|
|
|
|
|
| |
PaintRowGroupBackgroundByColIdx
Do less work in PaintRowGroupBackgroundByColIdx for cells that are not in our desired set of columns.
crash fix:
Guard against empty column groups when building a display list for a table.
|
|
|
|
| |
fix whitespace.
|
|
|
|
| |
It's at ~1.5% on the perf log for the Netflix use case, which seems a bit too much.
|
| |
|
| |
|
|
|
|
| |
Add dirty rect intersection checks so that we don't build unnecessary table part display items.
|
|
|
|
| |
This reverts commit f7b2f0a66536e8e74a0b2dc071a098b7693acecb.
|
|
|
|
| |
Add dirty rect intersection checks so that we don't build unnecessary table part display items.
|
| |
|
| |
|
|
|
|
| |
Speed up getting the first cellframe in a row and the next cellframe after the given one
|
| |
|
| |
|
|
|
|
| |
Tag #1343
|
| |
|
|
|
|
|
| |
The behavior change of document.open() requires these tests to be
changed to account for the new spec behavior.
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changes the work we do for document.open() in the following ways:
- We no longer create a new Window when doing document.open().
We use the same Window but remove all the event listeners on the
existing DOM tree and Window before removing the document's existing
children to provide a clean slate document to use for .write().
- We no longer create a session history entry (previously would be a
wyciwyg URI). We now replace the current one, effectively losing the
entry for the original document.
- We now support document.open() on windowless documents.
|
|
|
|
|
|
|
|
|
| |
This updates our behavior for computed DOM styling to no longer return
null on elements that have no display, but return a 0-length (empty)
style instead and don't throw. For this we stop looking at having a
presentation for the style and just look at the document instead.
This resolves #1219
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
forming a monotonically increasing sequence (e.g. with position:sticky)
Relative positioning can cause table parts to move, which can cause
issues with the cursor position to know which rows can be skipped.
To make this work, use the max difference between the frame's rect and
the union of the frame's "normal" position and the overflow rect to
cover the area of relatively positioned elements even if they are out of
order.
This resolves #1309.
|
|
|
|
|
|
|
|
| |
list collisions when processing the background color of a table.
This is effectively #146 Part 3c to go along with the other 2 there.
This resolves #1308.
|
|
|
|
| |
nsInlineFrame.
|
|
|
|
| |
nsInlineFrame::DestroyFrom.
|
| |
|
|
|
|
|
| |
This also reorganizes the exports in the build system to use `brotli/`
as include directory.
|
|\
| |
| |
| | |
This resolves #146.
|
| | |
|
| | |
|
| |
| |
| |
| | |
This aligns our behavior with Gecko/Blink.
|
| |
| |
| |
| |
| |
| | |
This also adds a reftest for border radius on collapsed borders (should
be ignored according to the CSS3 standard). We didn't do this before,
except on internal elements.
|
| |
| |
| |
| | |
display list collisions when processing the background image of a table.
|
| |
| |
| |
| | |
list collisions when processing the background image of a table.
|
| |
| |
| |
| |
| |
| | |
Since we're now putting table borders and backgrounds properly in the
display lists, we no longer need this custom component to do this work
for us.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
list items.
This patch does the following things:
1. Creates nsDisplayTableBorderCollapse that draws all collapse border
of tables.
2. Stops the use of nsDisplayTableBorderBackground.
3. Lets column and column group frames generate display items.
4. When traversing the table, also traverses the column and column group
frames.
5. For each type of table frame (col group, col, row group, row and
cell), draws their own background.
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
| |
Compared with what Pale Moon had for Solaris originally, this is mostly the same zero point I started patching from, but I've made the following changes here after reviewing all this initial code I never looked at closely before.
1. In package-manifest.in for both Basilisk and Pale Moon, I've made the SPARC code for libfreebl not interefere with the x86 code, use the proper build flags, and also updated it to allow a SPARC64 build which is more likely to be used than the 32-bit SPARC code we had there.
2. See Mozilla bug #832272 and the old rules.mk patch from around Firefox 30 in oracle/solaris-userland. I believe they screwed up NSINSTALL on Solaris when they were trying to streamline the NSS buildsystem, because they started having unexplained issues with it around that time after Firefox 22 that they never properly resolved until Mozilla began building NSS with gyp files. I'm actually not even sure how relevant the thing they broke actually is to Solaris at this point, bug 665509 is so old it predates Firefox itself and goes back to the Mozilla suite days. I believe $(INSTALL) -t was wrong, and they meant $(NSINSTALL) -t because that makes more sense and is closer to what was there originally. It's what they have for WINNT, and it's possible a fix more like that could serve for Solaris as well. Alternatively, we could get rid of all these half-broken Makefiles and start building NSS with gyp files like Mozilla did.
3. I've completely cut out support for the Sun compiler and taken into account the reality that everyone builds Firefox (and therefore its forks) with GCC now on Solaris. This alone helped clean up a lot of the uglier parts of the code.
4. I've updated all remaining SOLARIS build flags to the newer XP_SOLARIS, because the SOLARIS flag is no longer set when building Solaris.
5. I've confirmed the workaround in gtxFontconfigFonts.cpp is no longer necessary. The Solaris people got impatient about implementing a half-baked patch for a fontconfig feature that wasn't ready yet back in 2009, and somehow convinced Mozilla to patch their software to work around it when really they should have just fixed or removed their broken fontconfig patch. The feature they wanted has since been implemented properly, and no version of Solaris still uses the broken patch that required this fix. If anyone had ever properly audited this code, it would have been removed a long time ago.
|
|
|
|
|
| |
Ref:
1434478 part 7 - Update tests and enable some previously temporarily disabled Grid reftests from bug 1427608.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Layout CSS-Grid
List of relevant patches applied:
1398537 part 2 - [css-multicol] Implement percentages for 'column-gap' (Gecko part).
1434478 part 1 - [css-grid] Stop back-computing percentage grid gaps when the percentage basis is indefinite. Treat them as zero sized instead.
1434478 part 2 - Stop back-computing percentage padding/margin when the percentage basis is indefinite. Treat them as zero sized instead.
1434478 part 3 - Remove IntrinsicISizeOffsetData::hPctPadding/hPctMargin members since they are now unused.
1434478 part 4 - Factor out constants like NS_UNCONSTRAINEDSIZE so they can be used in headers without needing nsIFrame.h (idempotent patch).
1434478 part 5 - Create nsLayoutUtils::ResolveToLength for resolving CSS <length-percentage> (idempotent patch).
1434478 part 6 - Propagate a percentage basis to nsIFrame::IntrinsicISizeOffsets for resolving padding/margin.
This is needed only for CSS Grid since in other cases we're only using IntrinsicISizeOffsets in the inline-axis and the percentage basis is always indefinite for *intrinsic sizing*. When calculating the intrinsic size of grid items in the grid container's block axis however, we do have a definite size for the grid area in the inline-axis and it should be used per: https://drafts.csswg.org/css-grid/#algo-overview "2. Next, the track sizing algorithm resolves the sizes of the grid rows, using the grid column sizes calculated in the previous step." (Percentage padding/margin for grid items is always resolved against the grid area's inline-size nowadays.)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
List of relevant patches applied:
1425599 part 15 - [css-grid] Test reference fixes + more tests.
1373678 Part 3: Add line number checks to test_grid_implicit.html.
1416350 - Part 3: Add test to verify line numbers of grids with leading implicit tracks.
1416350 - Part 4: Add a reftest of repeat:auto-fit grids with leading implicit tracks.
1417711 - [css-grid] An abs.pos. grid container child that only covers removed 'auto-fit' tracks should not span to the end padding edge.
1416350 - Part 5: Correct the expected results for grids that have leading implicit tracks.
1418727 part 3 - [css-grid] Reftest updates.
|