summaryrefslogtreecommitdiffstats
path: root/layout/tables
Commit message (Collapse)AuthorAgeLines
* [layout] Re-order rowgroups if reflowing.Moonchild2020-10-23-2/+14
| | | | This logic was missing for tfoot. See existing code in second hunk.
* [layout] Avoid negative availSize.BSizes in paginated table reflow.Moonchild2020-10-23-9/+11
|
* Issue #1656 - Part 6: Clean up the build filesMoonchild2020-09-23-1/+0
|
* Issue #1656 - Part 1: Nuke most vim config lines in the tree.Moonchild2020-09-23-2/+0
| | | | | | Since these are just interpreted comments, there's 0 impact on actual code. This removes all lines that match /* vim: set(.*)tw=80: */ with S&R -- there are a few others scattered around which will be removed manually in a second part.
* issue #1547 - Correct z-ordering for some table parts and add reftestswin7-72020-05-13-2/+5
|
* Issue #1545 - Fix border-radius on table row groups, rows, column groups, or ↵win7-72020-05-12-16/+0
| | | | | | | | | | columns Before issue #146, border-radius on row groups, rows, column groups, or columns don't apply to the background of each cell, yet the border-radius on the cell itself does. After issue #146, the behaviors changed. In this patch, I tried to revert the behaviors of border-radius on table row groups, rows, column groups, or columns back to what happened before issue #146. Also: Don't override GetBorderRadii in nsBCTableCellFrame.
* Issue #1543 - Align <img> with no src to the updated spec.Moonchild2020-05-11-1/+1
|
* Issue #1355 - Better way to create display items for column backgroundswin7-72020-05-08-296/+253
| | | | | | | | | | | | | | | | | | | | | | Part 1: Remove current table item, as it's never set. Part 2: Get rid of generic table painting code, and handle each class separately. Part 4: Hoist outline skipping into col(group) frame code. Part 5: Skip box-shadow for table column and column groups. Part 6: Store column and column group backgrounds separately, and then append them before the rest of the table contents. Part 7: Pass rects in display list coordinates to AppendBackgroundItemsToTop. Part 8: Create column and column group background display items as part of the cell's BuildDisplayList. Part 9: Used cached values instead of calling nsDisplayListBuilder::ToReferenceFrame when possible, since it can be expensive when the requested frame isn't the builder's current frame. Part 10: Make sure we build display items for table parts where only the normal position is visible, since we may need to create background items for ancestors at that position. Part 11: Create an AutoBuildingDisplayList when we create background items for table columns and column groups, so that we initialize the invalidation state correctly.
* Issue #1355 - SetNeedToCalcHasBCBorders to true when initialize nsTableFramewin7-72020-05-08-0/+3
| | | | In the printing preview, we create continuous table frame if table is too long to containing in a page. But the default value of NeedToCalcHasBCBorders is false which means we don't calculate HasBCBorders for continuous table frame. Thus, the border collapse is not shown when printing preview.
* Issue #1355 - Preemptively fix build bustage for 1409114win7-72020-05-08-1/+1
|
* Issue #1355 - Store the dirty rect on the display list builder rather than ↵win7-72020-05-08-55/+34
| | | | | | passing it as a parameter to BuildDisplayList Also fix build bustage for De-unified layout/xul in nsRootBoxFrame.cpp
* Issue #80 - De-unify layout/tablesMoonchild2020-04-30-1/+9
|
* Issue #1355 - Make addition of cell border display items depend onwolfbeast2020-03-16-4/+112
| | | | | | | | whether they should be drawn. This reduces the size of display lists for tables by only adding display list items that are actually going to be visibly drawn, which will help overall performance of table drawing.
* Revert "Issue #1355 - Better way to create display items for column backgrounds"wolfbeast2020-02-26-337/+293
| | | | This reverts commit 44c47c50388f526c2d134e16d5debebe94a0faf8.
* Issue #1355 - Better way to create display items for column backgroundswin7-72020-02-25-293/+337
| | | | | | | | | | | | | | | | | | | | | | Part 1: Remove current table item, as it's never set. Part 2: Get rid of generic table painting code, and handle each class separately. Part 4: Hoist outline skipping into col(group) frame code. Part 5: Skip box-shadow for table column and column groups. Part 6: Store column and column group backgrounds separately, and then append them before the rest of the table contents. Part 7: Pass rects in display list coordinates to AppendBackgroundItemsToTop. Part 8: Create column and column group background display items as part of the cell's BuildDisplayList. Part 9: Used cached values instead of calling nsDisplayListBuilder::ToReferenceFrame when possible, since it can be expensive when the requested frame isn't the builder's current frame. Part 10: Make sure we build display items for table parts where only the normal position is visible, since we may need to create background items for ancestors at that position. Part 11: Create an AutoBuildingDisplayList when we create background items for table columns and column groups, so that we initialize the invalidation state correctly.
* Issue #1355 - Make nsTableCellFrame::GetColIndex/GetRowIndex fasterwin7-72020-02-16-99/+59
| | | | We can devirtualize it, remove some branches.
* Merge pull request #1393 from win7-7/optimization-3-prMoonchild2020-02-08-12/+26
|\ | | | | Do less work for columns not in the desired set in PaintRowGroupBackgroundByColIdx
| * Issue #1355 - Do less work for columns not in the desired set in ↵win7-72020-02-06-12/+26
| | | | | | | | | | | | | | | | | | | | PaintRowGroupBackgroundByColIdx Do less work in PaintRowGroupBackgroundByColIdx for cells that are not in our desired set of columns. crash fix: Guard against empty column groups when building a display list for a table.
* | fix whitespacewin7-72020-02-05-1/+1
| | | | | | | | fix whitespace.
* | Issue #1386 - Devirtualize GetRowSpan/GetColSpanwin7-72020-02-03-18/+24
|/ | | | It's at ~1.5% on the perf log for the Netflix use case, which seems a bit too much.
* Issue #1355 - Hit testing in large tables has become extremely slowwin7-72020-02-02-7/+30
| | | | Add dirty rect intersection checks so that we don't build unnecessary table part display items.
* Issue #1378 - Follow-up: make sure background items remain table-aligned.wolfbeast2020-02-02-1/+1
|
* Issue #1378 - Align the drawing of table cell backgrounds with the spec.wolfbeast2020-02-02-55/+105
|
* Issue #1355 - Speed up the traversal of a table row frame's child cellswin7-72020-01-29-28/+27
| | | | Speed up getting the first cellframe in a row and the next cellframe after the given one
* Issue #1309 - Fix handling of display rows where the elements are notwolfbeast2019-12-01-13/+11
| | | | | | | | | | | | | forming a monotonically increasing sequence (e.g. with position:sticky) Relative positioning can cause table parts to move, which can cause issues with the cursor position to know which rows can be skipped. To make this work, use the max difference between the frame's rect and the union of the frame's "normal" position and the overflow rect to cover the area of relatively positioned elements even if they are out of order. This resolves #1309.
* Issue #146 - Part 6: Allow `position: sticky` on table elements.wolfbeast2019-11-03-6/+5
|
* Issue #146 - Part 3: Create nsDisplayTableFixedPosition to avoid displaywolfbeast2019-11-03-3/+5
| | | | list collisions when processing the background image of a table.
* Issue #146 - Part 2: Remove custom table painting component.wolfbeast2019-11-02-1159/+0
| | | | | | Since we're now putting table borders and backgrounds properly in the display lists, we no longer need this custom component to do this work for us.
* Issue #146 - Part 1: Draw each table's background on their own displaywolfbeast2019-11-02-220/+213
| | | | | | | | | | | | | | list items. This patch does the following things: 1. Creates nsDisplayTableBorderCollapse that draws all collapse border of tables. 2. Stops the use of nsDisplayTableBorderBackground. 3. Lets column and column group frames generate display items. 4. When traversing the table, also traverses the column and column group frames. 5. For each type of table frame (col group, col, row group, row and cell), draws their own background.
* Issue #1230 - Part 1: Fix Back-computing percentages for intrinsic sizing in ↵Gaming4JC2019-09-28-9/+10
| | | | | | | | | | | | | | | | | | | | | | Layout CSS-Grid List of relevant patches applied: 1398537 part 2 - [css-multicol] Implement percentages for 'column-gap' (Gecko part). 1434478 part 1 - [css-grid] Stop back-computing percentage grid gaps when the percentage basis is indefinite. Treat them as zero sized instead. 1434478 part 2 - Stop back-computing percentage padding/margin when the percentage basis is indefinite. Treat them as zero sized instead. 1434478 part 3 - Remove IntrinsicISizeOffsetData::hPctPadding/hPctMargin members since they are now unused. 1434478 part 4 - Factor out constants like NS_UNCONSTRAINEDSIZE so they can be used in headers without needing nsIFrame.h (idempotent patch). 1434478 part 5 - Create nsLayoutUtils::ResolveToLength for resolving CSS <length-percentage> (idempotent patch). 1434478 part 6 - Propagate a percentage basis to nsIFrame::IntrinsicISizeOffsets for resolving padding/margin. This is needed only for CSS Grid since in other cases we're only using IntrinsicISizeOffsets in the inline-axis and the percentage basis is always indefinite for *intrinsic sizing*. When calculating the intrinsic size of grid items in the grid container's block axis however, we do have a definite size for the grid area in the inline-axis and it should be used per: https://drafts.csswg.org/css-grid/#algo-overview "2. Next, the track sizing algorithm resolves the sizes of the grid rows, using the grid column sizes calculated in the previous step." (Percentage padding/margin for grid items is always resolved against the grid area's inline-size nowadays.)
* Attach FrameProperties to each frame instead of using a shared hashtablewin7-72019-06-26-26/+28
| | | | Dispense the shared hashtable and instead attach the frame property list directly to nsIFrame.
* Use device pixels instead of CSS pixels for table borders.wolfbeast2018-10-07-38/+41
| | | | This resolves #821 (regression).
* Add m-esr52 at 52.6.0Matt A. Tobin2018-02-02-0/+31299