summaryrefslogtreecommitdiffstats
path: root/layout/style
Commit message (Collapse)AuthorAgeLines
* Issue #1647 - Followup: Remove excessive VARIANT_OPACITY statements.athenian2002020-09-30-6/+6
| | | | | | | | I got very anxious about making sure I included VARIANT_OPACITY in all the places VARIANT_NUMBER was included to make sure it couldn't possibly break unexpectedly, and that led to me accidentally breaking a mechanism that prevented percentages from serializing as numbers in other parts of the code. It was a total accident, and these additions were unnecessary. Basically, the situation is that there was one part of the code where it determines what's allowed for the flex statement (and possibly other statements) by checking whether it got stored as a "number", and basically only disallows percentages if it attempted to store/serialize them as percentages. However, it only got to that part of the code because I accidentally allowed VARIANT_OPACITY as a valid way for certain tokens to parse where it wasn't necessary. If it tries to parse it that way under very specific circumstances... percentages will be marked valid and fed through the system as numbers rather than being rejected and not serialized at all, because the check to disallow percentages there relied on them being stored as percentages. It's a really weird thing to have a problem with in a lot of ways, because if percentages aren't allowed in a field, you would think people wouldn't try to use them there, much less depend on the broken behavior that results from them not parsing as a related value.
* Issue #1656 - Part 8: Devtools and misc.Moonchild2020-09-24-2/+0
|
* Issue #1656 - Part 6: Clean up the build filesMoonchild2020-09-23-2/+0
|
* Issue #1656 - Part 4: Manual cleanupMoonchild2020-09-23-15/+0
|
* Issue #1656 - Part 3: Nuke more vim config lines in the tree.Moonchild2020-09-23-8/+0
| | | | Another S&R run with some smarter matching.
* Issue #1656 - Part 1: Nuke most vim config lines in the tree.Moonchild2020-09-23-51/+0
| | | | | | Since these are just interpreted comments, there's 0 impact on actual code. This removes all lines that match /* vim: set(.*)tw=80: */ with S&R -- there are a few others scattered around which will be removed manually in a second part.
* Issue #1655: Update MediaQueryList to the current draft spec.Moonchild2020-09-23-87/+176
| | | | | | | This make MediaQueryList inherit from EventTarget and adds MediaQueryListEvent as an interface as well as the onchange() method. This should not affect compatibility with other code; the event object is a MediaQueryListEvent instance, which is recognized as a MediaListQuery instance.
* Merge pull request #1654 from athenian200/opacity_percentageMoonchild2020-09-18-23/+36
|\ | | | | Implement percentage for CSS opacity keywords
| * Issue #1647 - Part 2: Implement VARIANT_OPACITY to correctly serialize.athenian2002020-09-17-33/+31
| | | | | | | | Even though percentages are already treated as floats internally by the style system for computation purposes, you have to go out of your way to stop them from being read back out as percentages. What I do here amounts to storing the percentage token in the "wrong" container, the one normally used for floats. This allows a value that was read in as a percentage to be read back out as something else, which is normally prevented by the design of the style system.
| * Issue #1647 - Part 1: Implement percentage for CSS opacity keywordsathenian2002020-09-16-14/+29
| | | | | | | | | | This preliminary step allows percentages to be computed and display correctly, but unfortunately it fails a test after changing VARIANT_HN to VARIANT_HPN because that allows values to be serialized as percentages. However, not doing this means percentages are rejected as valid values for the user to input. The way the style system is setup makes it hard to change this for opacity without changing it for everything else, especially since some code-saving speed hacks in Bug 636029 and Bug 441367 that make a lot of assumptions about this stuff very rigid.
* | Merge pull request #1651 from athenian200/link_element_disabledMoonchild2020-09-13-5/+7
|\| | | | | Clean up local variables from <link> disabled issue.
| * Issue #1629 - Part 5: Remove pointless local variables.athenian2002020-09-09-8/+7
| | | | | | | | Since the local variable is always initialized to false, we don't actually need to declare it and can just pass "false" directly as a parameter to the PrepareSheet function's bool. I was worried about code readability at first, but some well-placed comments took care of that.
| * Issue #1629 - Part 4: Ensure isExplicitlyEnabled is false upon sheet creation.athenian2002020-09-06-2/+5
| | | | | | | | This clarifies the assumptions the code is making and the order in which the variables pass through the loading process. The new variable is set after the sheet is created and prepared, and is assumed to be false in the beginning.
* | Issue #1641 - Implement CSS flow-root keywordathenian2002020-09-03-2/+15
| | | | | | | | This is just a clean port of 1322191 and follow-up 1325970. It really seems to add create a new way to access existing code relating to block formatting and floating elements rather than implementing new functionality, and it is mercifully straightforwards.
* | Merge pull request #1632 from athenian200/link_element_disabledMoonchild2020-08-18-13/+28
|\| | | | | Respond to disabled attribute set on <link> elements from HTML
| * Issue #1629 - Part 2: Implement the Explicitly Enabled flag.athenian2002020-08-13-13/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This part of the bug was significantly complicated by the following major refactors: https://bugzilla.mozilla.org/show_bug.cgi?id=1456435 https://bugzilla.mozilla.org/show_bug.cgi?id=1459498 As best as I can tell, we just need to implement the explicitly enabled flag on every instance of GetStyleSheetInfo, make sure aIsExplicitlyEnabled is false in every situation except the one where the disabled content attribute is removed from a link element, and enable alternate stylesheets if this flag is set on them. So we take the explicitly enabled flag as an input to PrepareSheet, and also add it to LoadStyleLink and LoadInlineStyle. I also decided not to defer loading of alternate stylesheets that have been explicitly enabled.
* | Issue #1620 - Intrinsic Aspect Ratio: Debug Follow up.Gaming4JC2020-08-16-0/+2
| | | | | | | | | | | | | | Newly introduced aspect-ratio property did not have CSS_PROP_LIST_EXCLUDE_INTERNAL defines, resulting in the following assertion: \!nsCSSProps::PropHasFlags(p, (1<<28)) (properties defined outside of #ifndef CSS_PROP_LIST_EXCLUDE_INTERNAL sections must not have the CSS_PROPERTY_INTERNAL flag), at ...layout/style/nsCSSProps.cpp:289 This patch resolves the assertion by adding #ifndef around the aspect-ratio property.
* | [CSS] Alias -webkit-appearance for compatibility reasonsMoonchild2020-08-10-0/+5
| | | | | | | | | | | | | | | | | | | | Since this is supported as an alias by Firefox and Edge for the same reasons and we have websites using this to (attempt to) override the system-provided styling with their own, leaving out the only supported keyword we'd otherwise have (with -moz- prefix) but still stating -webkit-. TODO: unprefix this completely and make the vendor prefixes aliases.
* | Issue #1620 - Use Intrinsic Aspect Ratio for ImagesAndy2020-08-04-0/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://bugzilla.mozilla.org/show_bug.cgi?id=1547231 https://bugzilla.mozilla.org/show_bug.cgi?id=1559094 https://bugzilla.mozilla.org/show_bug.cgi?id=1633434 https://bugzilla.mozilla.org/show_bug.cgi?id=1565690 https://bugzilla.mozilla.org/show_bug.cgi?id=1602047 Make use of Aspect Ratios in Image frames before Images are loaded. - Check for width and height HTML properties and create a ratio with them. - Overwrite HTML size values with actual image dimensions on load. - Collapse any frames with srcless images. Comments: dom/html/nsGenericHTMLElement.cpp:1483 layout/generic/nsImageFrame.cpp:289
* | Issue #1619 - Convert Intrinsic Ratio to FloatAndy2020-07-31-2/+2
|/ | | | | | | | | https://bugzilla.mozilla.org/show_bug.cgi?id=1547792 Aspect Ratio handling simplified by using floating point integers: - Multiplication of value (or inverse value) to a known side for Scaling - No unequal equal values such as "4/3" vs "8/6" vs "20/15" - Truly "Empty" aspect ratios, even if one dimension is not 0
* Issue #1525 - Kill marquee elementMoonchild2020-06-01-789/+0
| | | | | | * Remove marquee code * Regenerate HTML Elements/parser code for Removal of Marquee. Co-authored-by: Gaming4JC <g4jc@hyperbola.info>
* Issue #1564 - Split off nsIdentifierMapEntry in its own headerwolfbeast2020-05-25-0/+1
| | | | + Fix dependency fallout from removing nsDocument.h from ShadowRoot.h
* Revert "Merge pull request #1357 from athenian200/form-disabled-issue"athenian2002020-05-20-1/+6
| | | | | This reverts commit ed88b99849156004c04e4a0c87ea9b2360ef19b6, reversing changes made to c4b0715baaffc541670fd1158557aa7e61e521d3.
* Issue #1543 - Follow-up: avoid displaying the Alt text if an image is loading.Moonchild2020-05-12-1/+0
| | | | | This prevents the Alt text from briefly being shown before being replaced with the image.
* Issue #80 - Resolve issues with compiling on insane gcc configurations with ↵Moonchild2020-05-01-0/+3
| | | | | | no optimizations in layout/ (and fix a typo for cs fs)
* Issue #80 - De-unify layout/styleMoonchild2020-04-30-15/+39
|
* Bug 1425769 - Base class for ShadowRoot and Document to manage style stateMatt A. Tobin2020-04-17-4/+4
| | | | Tag #1375
* Issue #80 - De-unify dom/baseMatt A. Tobin2020-04-17-0/+1
| | | | Tag #1375
* Bug 1417829 - Remove unresolved pseudoclassMatt A. Tobin2020-04-17-3/+0
| | | | Tag #1375
* Bug 1422197 - Add fast path to get DocGroup in binding code for [CEReactions]Matt A. Tobin2020-04-17-0/+66
| | | | Tag #1375
* Bug 1409975 - Implement node distribution for shadow tree slotsMatt A. Tobin2020-04-17-0/+6
| | | | | | | | | | * Implementation for assignedNodes * Include slots in the flat tree * Fix event get-the-parent algorithm for a node * Update and add reftests for Shadow DOM v1 * Update web platform tests expectations Tag #1375
* Bug 1416999 - Remove document.registerElementMatt A. Tobin2020-04-17-14/+14
| | | | Tag #1375
* Bug 1373798 - Move HTML dir attribute state into event state flagsMatt A. Tobin2020-04-17-7/+25
| | | | | | | | | | * Stop calling SetHasDirAuto/ClearHasDirAuto in input element code * Introduce event state flags that track the state of an element's dir attribute * Rewrite our existing checks for the state of the dir attr on top of the new event state flags * Add pseudo-classes for matching on the dir attribute states * Use the new dir attribute pseudoclasses in html.css Tag #1375
* Bug 1332353 - Make it clearer when a stylesheet is really owned by its mDocumentMatt A. Tobin2020-04-17-24/+69
| | | | Tag #1375
* Bug 1355351 - Make pseudo-elements return the correct style via getComputedStyleMatt A. Tobin2020-04-17-4/+43
| | | | | | | | | * Add a node property to access the ::before and ::after pseudo-elements * Look for the frame for ::before and ::after pseudos * Clean up pseudo-element props * Simplify nsLayoutUtils callers, and make child iterators notice display: contents pseudos Tag #1375
* Bug 1330843 - Allow JS to create NAC pseudo-elementsMatt A. Tobin2020-04-17-2/+14
| | | | Tag #1375
* Bug 1346623 - Allow anonymous content created with ↵Matt A. Tobin2020-04-16-0/+61
| | | | | | | | | nsIDocument::InsertAnonymousContent can change from non-native to native AC * Prevent canvas custom content from becoming NAC when reframing the root element * Add an API to get computed style values through an AnonymousContent object Tag #1375
* Bug 1331322 - Allow tagging of pseudo-implementing native anonymous content ↵Matt A. Tobin2020-04-16-0/+2
| | | | | | | | | | | with the pseudo type at creation time * Stop using a node bit for HasExplicitBaseURI * Move MAY_HAVE_CLASS to mBoolFlags * Add a flag to indicate that a node is native anonymous content * Allow tagging of pseudo-implementing native anonymous content with the pseudo type at creation time, and eliminate explicit style contexts in nsIAnonymousContentCreator::ContentInfo Tag #1375
* Issue #1375 - Fix unified sourcesMatt A. Tobin2020-04-14-4/+7
|
* Bug 1321284 - Crash in nsCSSFrameConstructor::GetInsertionPrevSibling when ↵Matt A. Tobin2020-04-14-0/+80
| | | | | | | | | | | | trying to reframe native anonymous content * Make StyleChildrenIterator skip NAC generated by root element primary frame ancestors. * Add nsINode::GetFlattenedTreeParentNodeForStyle. * Add iterator class to find all restyle roots. NOTE: Parts 1, 2, and "4.2" Tag #1375
* Fix a whitespace issue in nsComputedDOMStyle.cppwolfbeast2020-02-12-3/+3
|
* [CSS] Add stub for font-variation-settingswolfbeast2020-02-11-0/+42
| | | | | | | | | | | | This stub is added because websites insist on considering this very hardware-dependent and O.S.-variable low-level font-control as a "critical feature" which it isn't as there is 0 guarantee that font variation settings are supported or honored by any operating system used by the client. On top this is a WD status feature that sites shouldn't be using, and the feature itself is strongly discouraged for use in favor of standard CSS font manipulation keywords like `font-weight`.
* Merge branch 'master' of https://github.com/MoonchildProductions/UXP into ↵athenian2002020-01-27-8/+2
|\ | | | | | | form-disabled-issue
| * Bug 1271549 - Remove details and summary preference.Gaming4JC2020-01-26-8/+2
| | | | | | | | Tag UXP Issue #1344
* | Issue #1356 - Remove -moz-user-input disabled to improve event handling.athenian2002020-01-16-6/+1
|/
* Bug 1322938 - Basic implementation of HTMLDialogElement.Gaming4JC2020-01-07-0/+21
| | | | Tag #1343
* Issue #1345 - Implement non-standard legacy CSSStyleSheet rulesJustOff2020-01-07-0/+29
|
* Issue #1118 - Part 6: Fix various tests that are no longer correct.wolfbeast2019-12-22-1/+0
| | | | | The behavior change of document.open() requires these tests to be changed to account for the new spec behavior.
* Issue #1219 - Align computed DOM styles with mainstream behvior.wolfbeast2019-12-20-37/+42
| | | | | | | | | This updates our behavior for computed DOM styling to no longer return null on elements that have no display, but return a 0-length (empty) style instead and don't throw. For this we stop looking at having a presentation for the style and just look at the document instead. This resolves #1219
* MoonchildProductions#1251 - Part 1: Restore initial Solaris support, fixed up.athenian2002019-10-21-0/+3
| | | | | | | | | | | | | | Compared with what Pale Moon had for Solaris originally, this is mostly the same zero point I started patching from, but I've made the following changes here after reviewing all this initial code I never looked at closely before. 1. In package-manifest.in for both Basilisk and Pale Moon, I've made the SPARC code for libfreebl not interefere with the x86 code, use the proper build flags, and also updated it to allow a SPARC64 build which is more likely to be used than the 32-bit SPARC code we had there. 2. See Mozilla bug #832272 and the old rules.mk patch from around Firefox 30 in oracle/solaris-userland. I believe they screwed up NSINSTALL on Solaris when they were trying to streamline the NSS buildsystem, because they started having unexplained issues with it around that time after Firefox 22 that they never properly resolved until Mozilla began building NSS with gyp files. I'm actually not even sure how relevant the thing they broke actually is to Solaris at this point, bug 665509 is so old it predates Firefox itself and goes back to the Mozilla suite days. I believe $(INSTALL) -t was wrong, and they meant $(NSINSTALL) -t because that makes more sense and is closer to what was there originally. It's what they have for WINNT, and it's possible a fix more like that could serve for Solaris as well. Alternatively, we could get rid of all these half-broken Makefiles and start building NSS with gyp files like Mozilla did. 3. I've completely cut out support for the Sun compiler and taken into account the reality that everyone builds Firefox (and therefore its forks) with GCC now on Solaris. This alone helped clean up a lot of the uglier parts of the code. 4. I've updated all remaining SOLARIS build flags to the newer XP_SOLARIS, because the SOLARIS flag is no longer set when building Solaris. 5. I've confirmed the workaround in gtxFontconfigFonts.cpp is no longer necessary. The Solaris people got impatient about implementing a half-baked patch for a fontconfig feature that wasn't ready yet back in 2009, and somehow convinced Mozilla to patch their software to work around it when really they should have just fixed or removed their broken fontconfig patch. The feature they wanted has since been implemented properly, and no version of Solaris still uses the broken patch that required this fix. If anyone had ever properly audited this code, it would have been removed a long time ago.
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-28 16:05:55 +0000