summaryrefslogtreecommitdiffstats
path: root/layout/generic
Commit message (Collapse)AuthorAgeLines
* Issue #1673 - Part 3: Bring minimum tab advance up to spec.athenian2002020-11-18-11/+30
| | | | This provides a clearer rule for the minimum tab advance that brings us to alignment with the spec and both major browsers.
* Issue #1673 - Part 2: Make tab-size animatable and fix typos.athenian2002020-11-18-3/+3
| | | | There were a few typos in the previous patch and this patch also makes tab-size animatable which didn't really require much of a change at all.
* Issue #1673 - Part 1: Allow tab-size to accept <length>.athenian2002020-11-18-29/+45
| | | | Currently -moz-tab-size only accepts <number> values, and both Chrome and Firefox currently support <length> values and have for some time now. So with this you would be able to support sizes in px or em, for instance. This was implemented in Firefox 53 and was trivial to backport.
* Issue #1671 - Unprefix ::-moz-selectionMoonchild2020-10-24-2/+9
| | | | | | | | This actually keeps both pseudo-elements for now, since the prefixed version is still used internally, but we need the unprefixed version for web compat. Note: while unprefixing a non-spec-compliant pseudo here, it's exactly in line with what other browsers do. Nobody is following the spec here and at least we'll be doing what everyone else is with our unprefixed version.
* Issue #1668 - Part 2: Visited color and auto support for caret-color property.athenian2002020-10-24-1/+1
| | | | Mozilla's original implementation of this failed a couple of tests, but this seems to solve all the problems. Basically, the caret-color wasn't able to be set differently based on whether a link was visited, and the auto value implementation was incomplete. The only test we fail now is the one where you have grey text on a grey background and the caret is supposed to be visible, but I think that may have been removed from the spec. Even if it wasn't, no other browser supports it anyway.
* Issue #1668 - Part 1: Implement support for caret-color property.athenian2002020-10-24-2/+1
| | | | | | This CSS property allows input carets (that blinking input cursor you see in text fields), to be given a custom color. This was implemented in Firefox 53, and it was such a minor feature that no one ever missed it, but I don't see any harm in implementing this. https://bugzilla.mozilla.org/show_bug.cgi?id=1063162
* Issue #1666 - Implement overflow-wrap: anywhereMoonchild2020-10-06-2/+3
| | | | | | | This aligns with the current spec regarding overflow-wrap: break-word and overflow-wrap: anywhere in if it affects intrinsic sized due to considering soft-wrap opportunities or not. See CSS Text Module Level 3, Editor’s Draft, 1 October 2020, Section 5.5
* Issue #1665 - Take overflow-wrap into account when calculating min-content ↵Moonchild2020-10-06-0/+10
| | | | intrinsic size.
* Issue #1641 - Implement CSS flow-root keywordathenian2002020-09-08-5/+9
| | | | This is just a clean port of 1322191 and follow-up 1325970. It really seems to add create a new way to access existing code relating to block formatting and floating elements rather than implementing new functionality, and it is mercifully straightforwards.
* Issue #1525 - Kill marquee element (uplift)Moonchild2020-09-05-332/+0
|
* Issue #1620 - Remove Development CommentsAndy2020-08-30-4/+0
|
* Issue #1620 - Use Intrinsic Aspect Ratio for Images (uplift)Andy2020-08-30-126/+176
|
* Issue #1619 - Nits PickedAndy2020-08-07-6/+7
|
* Issue #1619 - Add Vertical Writing TestcaseAndy2020-08-07-20/+0
| | | | | Ensures aspect ratio numerator and denominator aren't swapped in vertical writing modes. https://bugzilla.mozilla.org/show_bug.cgi?id=1548768
* Issue #1619 - Convert Intrinsic Ratio to FloatAndy2020-08-07-103/+182
| | | | | | | | | https://bugzilla.mozilla.org/show_bug.cgi?id=1547792 Aspect Ratio handling simplified by using floating point integers: - Multiplication of value (or inverse value) to a known side for Scaling - No unequal equal values such as "4/3" vs "8/6" vs "20/15" - Truly "Empty" aspect ratios, even if one dimension is not 0
* Revert "Merge pull request #1357 from athenian200/form-disabled-issue"athenian2002020-05-23-18/+0
| | | | | This reverts commit ed88b99849156004c04e4a0c87ea9b2360ef19b6, reversing changes made to c4b0715baaffc541670fd1158557aa7e61e521d3.
* Issue #1543 - Follow-up: avoid displaying the Alt text if an image is loading.Moonchild2020-05-20-17/+9
| | | | | This prevents the Alt text from briefly being shown before being replaced with the image.
* Issue #1543 - Align <img> with no src to the updated spec.Moonchild2020-05-20-55/+59
|
* Issue #1355 - Fix the nit, remove nsPoint offset in nsFrame.cpp and change ↵win7-72020-05-20-2/+1
| | | | PresShellState member order
* Issue #1355 - Better way to create display items for column backgroundswin7-72020-05-20-4/+40
| | | | | | | | | | | | | | | | | | | | | | Part 1: Remove current table item, as it's never set. Part 2: Get rid of generic table painting code, and handle each class separately. Part 4: Hoist outline skipping into col(group) frame code. Part 5: Skip box-shadow for table column and column groups. Part 6: Store column and column group backgrounds separately, and then append them before the rest of the table contents. Part 7: Pass rects in display list coordinates to AppendBackgroundItemsToTop. Part 8: Create column and column group background display items as part of the cell's BuildDisplayList. Part 9: Used cached values instead of calling nsDisplayListBuilder::ToReferenceFrame when possible, since it can be expensive when the requested frame isn't the builder's current frame. Part 10: Make sure we build display items for table parts where only the normal position is visible, since we may need to create background items for ancestors at that position. Part 11: Create an AutoBuildingDisplayList when we create background items for table columns and column groups, so that we initialize the invalidation state correctly.
* Issue #1355 - Avoid unnecessary work in ↵win7-72020-05-20-47/+53
| | | | | | | | | | nsIFrame::BuildDisplayListForStackingContext() and nsIFrame::BuildDisplayListForChild() and Cleanup DescendIntoChild Bug 1441796 - Part 1: Optimize the (pseudo)-stacking context conditions Bug 1441796 - Part 3: Reuse the results in nsIFrame::BuildDisplayListForStackingContext() for ChildrenHavePerspective(), IsTransformed(), and Combines3DTransformWithAncestors() Bug 1512244 - Part 1: Cleanup DescendIntoChild
* Issue #1355 - Preemptively fix build bustage for 1409114win7-72020-05-20-8/+8
|
* Issue #1355 - Store the dirty rect on the display list builder rather than ↵win7-72020-05-20-192/+146
| | | | | | passing it as a parameter to BuildDisplayList Also fix build bustage for De-unified layout/xul in nsRootBoxFrame.cpp
* Issue #80 - Resolve issues with compiling on insane gcc configurations with ↵Moonchild2020-05-06-1/+1
| | | | | | no optimizations in layout/ (and fix a typo for cs fs)
* Issue #80 - De-unify layout/PITA... I mean layout/genericMoonchild2020-05-06-8/+21
|
* Issue #1512 - Improve handling of multiple selections.wolfbeast2020-04-14-1/+1
| | | | | | | | | IsSelectionEditable should check whether the focus node and anchor node aren't null before trying to use them. This also changes the initialization of selections' aOutIndex to the last range in the selection as a fallback in case we don't add a range later (in AddItem) which could also end up with a null selection otherwise if the additional selection nodes are removed.
* [layout] Always move descendants of layout frames if moved.wolfbeast2020-04-14-0/+2
| | | | | If we move the frame then we always need to move any descendant views, not just in case the frame itself has a view.
* Issue #1511 - Bail on orphan situation.wolfbeast2020-04-14-0/+4
| | | | This resolves #1511
* Issue #1485 - Fix incorrect grid cell sizing to min/max space.wolfbeast2020-04-14-29/+29
| | | | | | | | | | | | | | | | There were actually two separate logical errors in this method: The first part is that "origSizes.isSome()" is simply a bogus requirement for applying min/max-sizes here. I'm still keeping the optimization of not needlessly copying the mSizes array (as originally intended) since it's a quite common case. The second bug is that min/max-sizes were only applied under the "if (fr != 0.0f)" block. This is bogus since the calculated 'fr' value depends on 'aAvailableSize' which might change by applying min/max-sizes and thus 'fr' could become non-zero in the second round. To fix, this patch just moves "applyMinMax" block out one level.
* Issue #1480 - Skip abspos, fixed, float and placeholders for outline.wolfbeast2020-04-14-2/+12
|
* Revert "Issue #1355 - Better way to create display items for column backgrounds"wolfbeast2020-04-14-320/+258
| | | | This reverts commit 44c47c50388f526c2d134e16d5debebe94a0faf8.
* Issue #1355 - Better way to create display items for column backgroundswin7-72020-04-14-258/+320
| | | | | | | | | | | | | | | | | | | | | | Part 1: Remove current table item, as it's never set. Part 2: Get rid of generic table painting code, and handle each class separately. Part 4: Hoist outline skipping into col(group) frame code. Part 5: Skip box-shadow for table column and column groups. Part 6: Store column and column group backgrounds separately, and then append them before the rest of the table contents. Part 7: Pass rects in display list coordinates to AppendBackgroundItemsToTop. Part 8: Create column and column group background display items as part of the cell's BuildDisplayList. Part 9: Used cached values instead of calling nsDisplayListBuilder::ToReferenceFrame when possible, since it can be expensive when the requested frame isn't the builder's current frame. Part 10: Make sure we build display items for table parts where only the normal position is visible, since we may need to create background items for ancestors at that position. Part 11: Create an AutoBuildingDisplayList when we create background items for table columns and column groups, so that we initialize the invalidation state correctly.
* Issue #1355 - Make nsTableCellFrame::GetColIndex/GetRowIndex fasterwin7-72020-04-14-12/+10
| | | | We can devirtualize it, remove some branches.
* Issue #1356 - Remove -moz-user-input disabled to improve event handling.athenian2002020-04-14-0/+18
|
* Issue #1328 - Part 3: Add fuzz to reftests and fix misc other tests.Chris Peterson2019-12-18-1/+1
|
* Check if we're already at the end of the frame's content.Jonathan Kew2019-12-06-1/+2
|
* Remove unnecessary calls to ReparentFloatsForInlineChild inMats Palmgren2019-11-29-45/+10
| | | | nsInlineFrame.
* Simplify the overflow child frame reparenting inMats Palmgren2019-11-29-7/+2
| | | | nsInlineFrame::DestroyFrom.
* Issue #146 - Part 6: Allow `position: sticky` on table elements.wolfbeast2019-11-03-5/+2
|
* Issue #146 - Part 5: Treat table row groups as containing blocks.wolfbeast2019-11-03-0/+11
| | | | This aligns our behavior with Gecko/Blink.
* Issue #1230 - Part 1: Fix Back-computing percentages for intrinsic sizing in ↵Gaming4JC2019-09-28-233/+93
| | | | | | | | | | | | | | | | | | | | | | Layout CSS-Grid List of relevant patches applied: 1398537 part 2 - [css-multicol] Implement percentages for 'column-gap' (Gecko part). 1434478 part 1 - [css-grid] Stop back-computing percentage grid gaps when the percentage basis is indefinite. Treat them as zero sized instead. 1434478 part 2 - Stop back-computing percentage padding/margin when the percentage basis is indefinite. Treat them as zero sized instead. 1434478 part 3 - Remove IntrinsicISizeOffsetData::hPctPadding/hPctMargin members since they are now unused. 1434478 part 4 - Factor out constants like NS_UNCONSTRAINEDSIZE so they can be used in headers without needing nsIFrame.h (idempotent patch). 1434478 part 5 - Create nsLayoutUtils::ResolveToLength for resolving CSS <length-percentage> (idempotent patch). 1434478 part 6 - Propagate a percentage basis to nsIFrame::IntrinsicISizeOffsets for resolving padding/margin. This is needed only for CSS Grid since in other cases we're only using IntrinsicISizeOffsets in the inline-axis and the percentage basis is always indefinite for *intrinsic sizing*. When calculating the intrinsic size of grid items in the grid container's block axis however, we do have a definite size for the grid area in the inline-axis and it should be used per: https://drafts.csswg.org/css-grid/#algo-overview "2. Next, the track sizing algorithm resolves the sizes of the grid rows, using the grid column sizes calculated in the previous step." (Percentage padding/margin for grid items is always resolved against the grid area's inline-size nowadays.)
* Issue #1233 - Part 2: Update ReftestsGaming4JC2019-09-28-4/+3292
| | | | | | | | | | | | | | | | | | List of relevant patches applied: 1425599 part 15 - [css-grid] Test reference fixes + more tests. 1373678 Part 3: Add line number checks to test_grid_implicit.html. 1416350 - Part 3: Add test to verify line numbers of grids with leading implicit tracks. 1416350 - Part 4: Add a reftest of repeat:auto-fit grids with leading implicit tracks. 1417711 - [css-grid] An abs.pos. grid container child that only covers removed 'auto-fit' tracks should not span to the end padding edge. 1416350 - Part 5: Correct the expected results for grids that have leading implicit tracks. 1418727 part 3 - [css-grid] Reftest updates.
* Issue #1233 - Part 1: Fix grid overflow and rendering issues by improving ↵Gaming4JC2019-09-28-278/+383
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Layout CSS-Grid API List of relevant patches applied: 1425599 part 1 - [css-grid] Change the track sizing algorithm for spanning items so that it accumulates individual item contributions to the plan by max() rather than incrementing the planned size directly. Also, fix a bug when copying back the planned limits after updating it for the first span group. It should only copy back track sizes that were actaully spanned by those items, other content-sized tracks' limits should remain at "infinity". 1425599 part 2 - [css-grid] Factor out the min-sizing parts of the track sizing for spanned items to a templated method (idempotent change). 1425599 part 3 - [css-grid] Factor out most of the max-sizing parts of the track sizing for spanned items to a templated method (idempotent change). 1425599 part 4 - [css-grid] Factor out the starting base/limit size to a templated method (idempotent change). 1425599 part 5 - [css-grid] Make CollectGrowable a templated method so that it works with either base/limit sizes (idempotent change). 1425599 part 6 - [css-grid] Make the size distribution methods templated with the intent of merging them in a later patch (idempotent change). This patch also introduces an eInfinitelyGrowable bit to help get rid of the 'limits' temporary track sizes in the next patch. 1425599 part 7 - [css-grid] Remove the 'limits' copy of track sizes since they are no longer needed (idempotent change). 1425599 part 8 - [css-grid] Factor out the fit-content clamping function from DistributeToTrackLimits and pass it as a param instead (idempotent change). 1425599 part 9 - [css-grid] Merge DistributeToTrackLimits/Bases (idempotent change). 1425599 part 10 - [css-grid] Make MarkExcludedTracks a static method since it doesn't use 'this' (idempotent change). 1425599 part 11 - [css-grid] Hoist the marking of excluded tracks out from GrowSelectedTracksUnlimited to a separate method (idempotent change). 1425599 part 12 - [css-grid] Merge CopyPlanToBase/Limits into a templated method instead (idempotent change). 1425599 part 13 - [css-grid] Merge Grow[Base|Limits]ForSpanningItems into a templated method instead (idempotent change). 1425599 part 14 - [css-grid] Use iterators instead of an array + start/end index for the item data (idempotent change). 1425599 part 16 - [css-grid] Make SizeContributionForPhase a template. 1425599 - [css-grid] Follow-up bustage fix for stupid compiler warnings. 1378481 - Assign 'roundingError' in the default branch too, to avoid a maybe-uninitialized compiler warning. 1423292 - [css-grid] Add a couple of ItemState bits to Dump(), and make an ItemState assertion stricter (DEBUG-only changes). 1373678 Part 1: Reduce grid line numbers by count of leading implicit lines, minimum 0. 1416350 - Part 1: Correctly account for removed 'auto-fit' tracks also when there are leading implicit tracks. 1416350 - Part 2: Correct logic for Grid API line numbering with leading implicit tracks. 1418727 part 1 - [css-grid] Introduce StateBitsForRange() that collects the union of the state bits for a range of tracks (idempotent change). 1418727 part 2 - [css-grid] Require that an item spans at least one track with an 'auto' min sizing function for Automatic Minimum Size to apply.
* Fix comments for Framepropertieswin7-72019-07-12-1/+1
| | | | | | | | | | https://bugzilla.mozilla.org/show_bug.cgi?id=1373884 Fixes comments for Frameproperties. These comments went unnoticed earlier. No code changes.
* Iterate the frame property list once to collect which child list properties ↵win7-72019-07-08-36/+53
| | | | | | we have Look into optimizing out the hashtable lookups from nsContainerFrame
* Attach FrameProperties to each frame instead of using a shared hashtablewin7-72019-06-26-321/+353
| | | | Dispense the shared hashtable and instead attach the frame property list directly to nsIFrame.
* Remove 18 yo OS/2 and AIX bustage workaround.wolfbeast2019-03-31-19/+73
| | | | Tag #186
* Handle the special case of a flex frame being the absolute containing block ↵JustOff2019-03-14-6/+22
| | | | correctly from the CSS align code
* Merge branch 'master' of https://github.com/MoonchildProductions/UXPwolfbeast2019-02-03-1/+1
|\
| * issue #908 - implement missing parts of CSS maskyami2019-02-02-1/+1
| |