| Commit message (Collapse) | Author | Age | Lines |
... | |
| |
| |
| |
| |
| |
| | |
Keyboard.jsm back in EXTRA_JS_MODULES
JSMs are NOT Components.
|
| |\
| | |
| | | |
Respond to disabled attribute set on <link> elements from HTML
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
This is not very "clean," and is mostly done in the same sloppy way as Emilio did it because that's basically the only way you can do it. Note well that this does NOT actually turn off everything I've done in a clean fashion like ifdefs would. For instance, the Explicitly Enabled flag is still present, but is now always false because the only condition that can set it true is behind the pref and therefore inert when this pref is off. Also, because the arguments of SetDisabled have changed, my modifications to SetMozDisabled must be present regardless of whether the pref is on or off. What I have done is turn off the actual reflection of the disabled attribute in Disabled and SetDisabled, as well as in AfterSetAttr.
However, turning the pref off seems to restore more or less our old behavior, though there may be subtle differences unlike with an ifdef since this is, unfortunately, not an exact science and I can only turn off changes that happen within individual functions and not changes in how functions interact with each other.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This part of the bug was significantly complicated by the following major refactors:
https://bugzilla.mozilla.org/show_bug.cgi?id=1456435
https://bugzilla.mozilla.org/show_bug.cgi?id=1459498
As best as I can tell, we just need to implement the explicitly enabled
flag on every instance of GetStyleSheetInfo, make sure
aIsExplicitlyEnabled is false in every situation except the one where
the disabled content attribute is removed from a link element, and
enable alternate stylesheets if this flag is set on them. So we take the
explicitly enabled flag as an input to PrepareSheet, and also add it to
LoadStyleLink and LoadInlineStyle. I also decided not to defer loading of
alternate stylesheets that have been explicitly enabled.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
So basically, I'm trying to adapt this to UXP:
https://bugzilla.mozilla.org/show_bug.cgi?id=1281135
The earliest source of difficulty while adapting Bug 1281135 to our codebase was simply getting the new ErrorResult flag added to the SetDisabled function to play nice with the SetMozDisabled function. At this point, the implementation can actually have a stylesheet be disabled by default but there are supposedly issues with alternate stylesheets.
At first I played around with the return type of SetMozDisabled to no avail, but I found another solution fairly quickly.
https://bugzilla.mozilla.org/show_bug.cgi?id=846972
https://bugzilla.mozilla.org/show_bug.cgi?id=1157898
Essentially, the way around the problem of the number of return arguments not matching up is to declare a local variable within SetMozDisabled called ErrorResult rv, and using that to store the return value of the ErrorResult argument from SetDisabled. After that, because ErrorCode was removed, you would return rv.StealNSResult() in order to report success or failure to any consumer that calls on SetMozDisabled.
|
| | |
| | |
| | |
| | | |
Because the spec says so.
|
| | |
| | |
| | |
| | | |
Because the spec says so.
|
|\| | |
|
| |\ \
| | | |
| | | | |
[Image/CSS] Intrinsic Aspect Ratio
|
| | | |
| | | |
| | | |
| | | | |
A simpler name feels so much cleaner.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
https://bugzilla.mozilla.org/show_bug.cgi?id=1547231
https://bugzilla.mozilla.org/show_bug.cgi?id=1559094
https://bugzilla.mozilla.org/show_bug.cgi?id=1633434
https://bugzilla.mozilla.org/show_bug.cgi?id=1565690
https://bugzilla.mozilla.org/show_bug.cgi?id=1602047
Make use of Aspect Ratios in Image frames before Images are loaded.
- Check for width and height HTML properties and create a ratio with them.
- Overwrite HTML size values with actual image dimensions on load.
- Collapse any frames with srcless images.
Comments:
dom/html/nsGenericHTMLElement.cpp:1483
layout/generic/nsImageFrame.cpp:289
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | | |
This is apparently used for fallback selection and if available it is "assumed"
Shadow DOM is also available, while this is a utility function.
Webcompat is a nightmare sometimes.
|
| | |
| | |
| | |
| | | |
This fixes a spec compliance issue with section 8.1.4.2 Fetching scripts.
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| |/ |
|
| |
| |
| |
| |
| |
| |
| | |
The added debug assertion did not take into account microtask refactoring done in BZ 1405821.
Resulting in error: no member named 'IsInMicroTask' in 'nsContentUtils'.
This resolves the error.
|
| |
| |
| |
| |
| | |
This is an ahead-of time port to try and address #1624.
This is based on BZ 1461751 and Jon Coppeard's work in it.
|
| |
| |
| |
| |
| |
| | |
a visited set
Ref: BZ 1365187
|
| |
| |
| |
| | |
Ref: BZ 1365187
|
| |
| |
| |
| |
| |
| |
| | |
The added debug assertion did not take into account microtask refactoring done in BZ 1405821.
Resulting in error: no member named 'IsInMicroTask' in 'nsContentUtils'.
This resolves the error.
|
| |
| |
| |
| |
| |
| | |
handling works correctly
Ref BZ 1395896
|
| |
| |
| |
| |
| |
| |
| |
| | |
This updates module implementation to match spec regarding handling of
instantiation errors, after it was changed yet again, this time to not remember
instantiation errors, but instead immediately rethrow applicable ones.
Ref: BZ 1420420
|
|/
|
|
|
|
|
| |
When module dependencies fail, don't spam with errors for each import; only fire
the error event once.
Ref: BZ 1421259
|
|
|
|
| |
Ref: BZ 1388728
|
|
|
|
| |
Ref: BZ 1388728
|
|
|
|
|
| |
This backs out the stuff added in Bug 1295978.
Ref: BZ 1295978, 1388728
|
|
|
|
|
|
| |
9ca74147225eed305e28c7887f9b2251aeeb0f36
Ref: BZ 1388728
|
| |
|
|
|
|
|
| |
If instantiation has failed, then also fail the load and don't fetch imports.
Ref BZ: 1358882
|
|
|
|
|
|
|
| |
This splits ScriptLoader up the same way Mozilla did with the exception of
ScriptRequest due to the fact that ScriptLoader and ScriptRequest are
interdependent and would create a circular dependency if split apart when not
using unified building.
|
|
|
|
|
|
| |
- Moves scripting parts of DOM into 'dom/script'
- Renames nsScript{Loader/Element} to Script{Loader/Element}
- Adjusts all callers
|
|
|
|
|
|
|
|
| |
Dynamic script loading/unloading (thank you modules) can yank the script
out from under us before the JS API for it is initialized, leading to
null deref crashes.
This adds a simple check if the passed-in object is sane and present.
Resolves #1602
|
|
|
|
| |
Tag #1375
|
|
|
|
| |
Tag #1375
|
|
|
|
| |
Tag #1375
|
|
|
|
|
|
| |
atoms as keys to avoid slow string assignments when possible.
Tag #1375
|
|
|
|
|
|
| |
save an allocation
Tag #1375
|
|\ |
|
| | |
|
| |
| |
| |
| | |
Since it didn't end up being in the final spec after all.
|
| |
| |
| |
| |
| | |
Also renames FetchSignal to AbortSignal. Includes renaming the various
controlling prefs to enable.
|
| |
| |
| |
| | |
Since it is specced separately from fetch.
|
| | |
|
| | |
|
| | |
|