summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeLines
* Merge pull request #1632 from athenian200/link_element_disabledMoonchild2020-08-18-44/+123
|\ | | | | Respond to disabled attribute set on <link> elements from HTML
| * Fix nitsathenian2002020-08-14-3/+3
| |
| * Issue #1629 - Part 3: Implement behind preference.athenian2002020-08-14-7/+26
| | | | | | | | | | | | This is not very "clean," and is mostly done in the same sloppy way as Emilio did it because that's basically the only way you can do it. Note well that this does NOT actually turn off everything I've done in a clean fashion like ifdefs would. For instance, the Explicitly Enabled flag is still present, but is now always false because the only condition that can set it true is behind the pref and therefore inert when this pref is off. Also, because the arguments of SetDisabled have changed, my modifications to SetMozDisabled must be present regardless of whether the pref is on or off. What I have done is turn off the actual reflection of the disabled attribute in Disabled and SetDisabled, as well as in AfterSetAttr. However, turning the pref off seems to restore more or less our old behavior, though there may be subtle differences unlike with an ifdef since this is, unfortunately, not an exact science and I can only turn off changes that happen within individual functions and not changes in how functions interact with each other.
| * Issue #1629 - Part 2: Implement the Explicitly Enabled flag.athenian2002020-08-13-31/+79
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This part of the bug was significantly complicated by the following major refactors: https://bugzilla.mozilla.org/show_bug.cgi?id=1456435 https://bugzilla.mozilla.org/show_bug.cgi?id=1459498 As best as I can tell, we just need to implement the explicitly enabled flag on every instance of GetStyleSheetInfo, make sure aIsExplicitlyEnabled is false in every situation except the one where the disabled content attribute is removed from a link element, and enable alternate stylesheets if this flag is set on them. So we take the explicitly enabled flag as an input to PrepareSheet, and also add it to LoadStyleLink and LoadInlineStyle. I also decided not to defer loading of alternate stylesheets that have been explicitly enabled.
| * Issue #1629 - Part 1: Implement basic logic in HTMLLinkElement.athenian2002020-08-13-12/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | So basically, I'm trying to adapt this to UXP: https://bugzilla.mozilla.org/show_bug.cgi?id=1281135 The earliest source of difficulty while adapting Bug 1281135 to our codebase was simply getting the new ErrorResult flag added to the SetDisabled function to play nice with the SetMozDisabled function. At this point, the implementation can actually have a stylesheet be disabled by default but there are supposedly issues with alternate stylesheets. At first I played around with the return type of SetMozDisabled to no avail, but I found another solution fairly quickly. https://bugzilla.mozilla.org/show_bug.cgi?id=846972 https://bugzilla.mozilla.org/show_bug.cgi?id=1157898 Essentially, the way around the problem of the number of return arguments not matching up is to declare a local variable within SetMozDisabled called ErrorResult rv, and using that to store the return value of the ErrorResult argument from SetDisabled. After that, because ErrorCode was removed, you would return rv.StealNSResult() in order to report success or failure to any consumer that calls on SetMozDisabled.
* | Merge pull request #1635 from g4jc/1620Moonchild2020-08-17-0/+2
|\ \ | | | | | | Intrinsic Aspect Ratio: Debug Follow up.
| * | Issue #1620 - Intrinsic Aspect Ratio: Debug Follow up.Gaming4JC2020-08-16-0/+2
|/ / | | | | | | | | | | | | Newly introduced aspect-ratio property did not have CSS_PROP_LIST_EXCLUDE_INTERNAL defines, resulting in the following assertion: \!nsCSSProps::PropHasFlags(p, (1<<28)) (properties defined outside of #ifndef CSS_PROP_LIST_EXCLUDE_INTERNAL sections must not have the CSS_PROPERTY_INTERNAL flag), at ...layout/style/nsCSSProps.cpp:289 This patch resolves the assertion by adding #ifndef around the aspect-ratio property.
* | [CSS] Alias -webkit-appearance for compatibility reasonsMoonchild2020-08-10-0/+5
| | | | | | | | | | | | | | | | | | | | Since this is supported as an alias by Firefox and Edge for the same reasons and we have websites using this to (attempt to) override the system-provided styling with their own, leaving out the only supported keyword we'd otherwise have (with -moz- prefix) but still stating -webkit-. TODO: unprefix this completely and make the vendor prefixes aliases.
* | Merge pull request #1613 from RealityRipple/AspectRatioMoonchild2020-08-08-155/+379
|\ \ | | | | | | [Image/CSS] Intrinsic Aspect Ratio
| * | Issue #1620 - Enable Intrinsic Ratio by DefaultAndy2020-08-07-2/+2
| | | | | | | | | | | | A simpler name feels so much cleaner.
| * | Issue #1620 - Remove Development CommentsAndy2020-08-07-18/+4
| | |
| * | Issue #1620 - Use Intrinsic Aspect Ratio for ImagesAndy2020-08-04-143/+381
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://bugzilla.mozilla.org/show_bug.cgi?id=1547231 https://bugzilla.mozilla.org/show_bug.cgi?id=1559094 https://bugzilla.mozilla.org/show_bug.cgi?id=1633434 https://bugzilla.mozilla.org/show_bug.cgi?id=1565690 https://bugzilla.mozilla.org/show_bug.cgi?id=1602047 Make use of Aspect Ratios in Image frames before Images are loaded. - Check for width and height HTML properties and create a ratio with them. - Overwrite HTML size values with actual image dimensions on load. - Collapse any frames with srcless images. Comments: dom/html/nsGenericHTMLElement.cpp:1483 layout/generic/nsImageFrame.cpp:289
* | | Pref and disable getRootNode()Moonchild2020-08-07-1/+3
| | | | | | | | | | | | | | | | | | | | | This is apparently used for fallback selection and if available it is "assumed" Shadow DOM is also available, while this is a utility function. Webcompat is a nightmare sometimes.
* | | Issue #1628 - Remove redundant PREF_EM_UPDATE_BACKGROUND_URLMatt A. Tobin2020-08-07-8/+1
|/ /
* | Merge pull request #1623 from g4jc/libeditor_patchMoonchild2020-08-04-340/+411
|\ \ | | | | | | Improve Performance of libeditor
| * | Issue #1621 - Part 4: Check whether node can be splited.Gaming4JC2020-07-31-7/+12
| | | | | | | | | | | | | | | | | | At first, HTMLEditor::GetActiveEditingHost might return null in this situation, we should check whether nullptr is returned. At second, SplitNodeDeep returns error since curent is design mode and selection node has no parent. So we should check error. Ref: Bug 1350772
| * | Issue #1621 - Part 3: Use nsIAtom to change attirbute if possible.Gaming4JC2020-07-31-64/+51
| | | | | | | | | | | | | | | | | | We can replace old nsIEditor API with nsIAtom version. Ref: Bug 1324996
| * | Issue #1621 - Part 2: Implement nsIAtom version of ↵Gaming4JC2020-07-31-100/+143
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | SetAttribute/RemoveAttribute/CloneAttirubte. Add nsIAtom version of the following. - CloneAttribute - RemoveAttribute - RemoveAttributeOrEquivalent - SetAttribute - SetAttributeOrEquivalent Ref: Bug 1324996
| * | Issue #1621 - Part 1: CSSEditUtils should use atom for CSS property if possible.Gaming4JC2020-07-31-188/+224
| | | | | | | | | | | | | | | | | | There is a lot of string compare when using CSS property name. We should use nsGkAtoms instead. Ref: Bug 1323138
* | | Issue #1625 - Allow MailNews Oauth2 support to be configured in confvars.shMatt A. Tobin2020-08-03-1/+0
| | | | | | | | | | | | Baby has his bottle, you ok now?
* | | [js] Try to catch bad pointers for GC and bail if not valid.Moonchild2020-08-03-0/+42
| | |
* | | Merge pull request #1622 from RealityRipple/masterMoonchild2020-08-03-229/+361
|\ \ \ | | | | | | | | Convert Intrinsic Ratio from nsSize to Float
| * | | Issue #1619 - Nits PickedAndy2020-08-02-8/+8
| | | |
| * | | Issue #1619 - Add Vertical Writing TestcaseAndy2020-08-01-20/+57
| | | | | | | | | | | | | | | | | | | | Ensures aspect ratio numerator and denominator aren't swapped in vertical writing modes. https://bugzilla.mozilla.org/show_bug.cgi?id=1548768
| * | | Issue #1619 - Missing Dimension ComputationAndy2020-07-31-0/+10
| | | | | | | | | | | | | | | | | | | | This existed in Firefox before this bug. I don't know if it came from a previous bug or was removed post-fork.
| * | | Issue #1619 - Convert Intrinsic Ratio to FloatAndy2020-07-31-229/+314
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | https://bugzilla.mozilla.org/show_bug.cgi?id=1547792 Aspect Ratio handling simplified by using floating point integers: - Multiplication of value (or inverse value) to a known side for Scaling - No unequal equal values such as "4/3" vs "8/6" vs "20/15" - Truly "Empty" aspect ratios, even if one dimension is not 0
* | | Add license header to media/webrtc/trunk/build/mac/find_sdk_uxp.pyMatt A. Tobin2020-07-31-0/+3
| | |
* | | Use an alt script to properly determine the OSX SDK versionMatt A. Tobin2020-07-31-1/+48
|/ /
* | Merge pull request #1618 from g4jc/libeditor_patchMoonchild2020-07-31-20/+14
|\ \ | | | | | | Clean up GetTextNode into TextEditRules.
| * | Bug 1318570 - Clean up GetTextNode into TextEditRules.Gaming4JC2020-07-30-20/+14
|/ / | | | | | | | | | | EditorBase parameter of GetTextNode is unnecessary because it uses static method only. Also, we should return nsINode to reduce QI. Resolves #1617
* | Merge pull request #1616 from athenian200/solaris_ldap_workNew Tobin Paradigm2020-07-30-8/+5
|\ \ | | | | | | SunOS LDAP cleanup
| * | Issue #1615 - SunOS LDAP cleanup.athenian2002020-07-29-8/+5
| | | | | | | | | | | | I meant to do this a long time ago, but basically it accounts for the new XP_SOLARIS build flag that never made it into the MailNews code. Additionally, it enables a compatibility flag for Solaris 11.4 that allows us to use the three-argument implementation of ctime_r still used by Solaris 11.3 and illumos (which also appears equivalent to the NSLDAPI_CTIME implementation used by libldap internally). Also, the ctime_r function has been added to the time.h header library for a while now, not sure why Mozilla thought we didn't have a ctime_r implementation.
* | | Issue #1614 - Update en-US DictionaryMatt A. Tobin2020-07-29-230/+2358
| | |
* | | Improve dll loading on Windows.Moonchild2020-07-29-2/+4
| | |
* | | [WebRTC] Stop putting addresses in the cookie chunk.Michael Tuexen2020-07-29-0/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When using AF_CONN addresses, don't put these in the COOKIE chunk. For these addresses it is possible to reconstruct them locally. Conceptually, addresses are something to be shared with the peer, but in the case of AF_CONN this might not be the case. Therefore, zero then out. Thanks to Natalie Silvanovich of Google Project Zero for finding and reporting the issue.
* | | [dom] Fix a spec compliance issue with the HTML LS regarding script loading.Moonchild2020-07-29-7/+9
| | | | | | | | | | | | This fixes a spec compliance issue with section 8.1.4.2 Fetching scripts.
* | | [js] Don't improve TypeSets containing the magic-args type.Moonchild2020-07-29-4/+4
| | | | | | | | | | | | | | | | | | JIT optimizations involving the Javascript 'arguments' object could potentially confuse later optimizations, so we simply disable these optimizations as a DiD measure.
* | | [xpcom] Make Base64 compatible with ReadSegments() with small buffers.Andrea Marchesini2020-07-29-7/+121
| | |
* | | [js] Fix Sink to check for non-recoverable operands.Jan de Mooij2020-07-29-1/+5
| | |
* | | [network/dom] Improve sanitization of download filenames.Moonchild2020-07-29-3/+26
| | |
* | | Issue #1391 - Remove the DOM battery APIMoonchild2020-07-28-1770/+0
| | |
* | | Follow up to 39be34c06 - The check sound be if not orderedMatt A. Tobin2020-07-27-2/+2
| | | | | | | | | | | | FINE! I'll go to bed already...
* | | Revert "Follow up to 39be34c06 - The check sound be if not ordered"Matt A. Tobin2020-07-27-2/+2
| | | | | | | | | | | | This reverts commit d7d4567ffee9527aaaf4b975246445305e38ef9d.
* | | Follow up to 39be34c06 - The check sound be if not orderedMatt A. Tobin2020-07-27-2/+2
| | | | | | | | | | | | I am tired.
* | | Revert "Follow up to 39be34c06 - The check sound be if not ordered"Matt A. Tobin2020-07-27-1/+1
| | | | | | | | | | | | This reverts commit 8698bde001373f7d2dd4ecddd80874d683bab32e.
* | | Follow up to 39be34c06 - The check sound be if not orderedMatt A. Tobin2020-07-27-1/+1
|/ /
* | [MailNews] Allow setting "Local Folders" as always the first displayed accountMatt A. Tobin2020-07-27-0/+5
| |
* | [MailNews] Allow ordering of accounts to respect mail.accountmanager.accountsMatt A. Tobin2020-07-27-1/+9
| |
* | Merge branch 'abortcontroller-work'Moonchild2020-07-27-30/+130
|\ \
| * | Fix line endings.Moonchild2020-07-25-714/+714
| | |