summaryrefslogtreecommitdiffstats
path: root/browser/components
diff options
context:
space:
mode:
Diffstat (limited to 'browser/components')
-rw-r--r--browser/components/build/moz.build22
-rw-r--r--browser/components/customizableui/CustomizableUI.jsm14
-rw-r--r--browser/components/customizableui/CustomizableWidgets.jsm5
-rw-r--r--browser/components/dirprovider/DirectoryProvider.cpp2
-rw-r--r--browser/components/downloads/DownloadsCommon.jsm8
-rw-r--r--browser/components/extensions/extension-win-panel.css7
-rw-r--r--browser/components/feeds/nsFeedSniffer.cpp15
-rw-r--r--browser/components/feeds/nsFeedSniffer.h2
-rw-r--r--browser/components/migration/nsIEHistoryEnumerator.cpp5
-rw-r--r--browser/components/moz.build4
-rw-r--r--browser/components/nsBrowserGlue.js4
-rw-r--r--browser/components/preferences/in-content/preferences.xul8
-rw-r--r--browser/components/preferences/in-content/security.xul4
-rw-r--r--browser/components/shell/ShellService.jsm4
-rw-r--r--browser/components/shell/nsGNOMEShellService.cpp25
-rw-r--r--browser/components/shell/nsGNOMEShellService.h2
-rw-r--r--browser/components/shell/nsMacShellService.cpp2
-rw-r--r--browser/components/shell/nsWindowsShellService.cpp81
-rw-r--r--browser/components/shell/nsWindowsShellService.h2
-rw-r--r--browser/components/webextensions/.eslintrc.js (renamed from browser/components/extensions/.eslintrc.js)0
-rw-r--r--browser/components/webextensions/ext-bookmarks.js (renamed from browser/components/extensions/ext-bookmarks.js)0
-rw-r--r--browser/components/webextensions/ext-browserAction.js (renamed from browser/components/extensions/ext-browserAction.js)11
-rw-r--r--browser/components/webextensions/ext-c-contextMenus.js (renamed from browser/components/extensions/ext-c-contextMenus.js)0
-rw-r--r--browser/components/webextensions/ext-c-omnibox.js (renamed from browser/components/extensions/ext-c-omnibox.js)0
-rw-r--r--browser/components/webextensions/ext-c-tabs.js (renamed from browser/components/extensions/ext-c-tabs.js)0
-rw-r--r--browser/components/webextensions/ext-commands.js (renamed from browser/components/extensions/ext-commands.js)0
-rw-r--r--browser/components/webextensions/ext-contextMenus.js (renamed from browser/components/extensions/ext-contextMenus.js)0
-rw-r--r--browser/components/webextensions/ext-desktop-runtime.js (renamed from browser/components/extensions/ext-desktop-runtime.js)0
-rw-r--r--browser/components/webextensions/ext-history.js (renamed from browser/components/extensions/ext-history.js)0
-rw-r--r--browser/components/webextensions/ext-omnibox.js (renamed from browser/components/extensions/ext-omnibox.js)0
-rw-r--r--browser/components/webextensions/ext-pageAction.js (renamed from browser/components/extensions/ext-pageAction.js)3
-rw-r--r--browser/components/webextensions/ext-sessions.js (renamed from browser/components/extensions/ext-sessions.js)0
-rw-r--r--browser/components/webextensions/ext-tabs.js (renamed from browser/components/extensions/ext-tabs.js)0
-rw-r--r--browser/components/webextensions/ext-utils.js (renamed from browser/components/extensions/ext-utils.js)4
-rw-r--r--browser/components/webextensions/ext-windows.js (renamed from browser/components/extensions/ext-windows.js)0
-rw-r--r--browser/components/webextensions/extension-mac-panel.css (renamed from browser/components/extensions/extension-mac-panel.css)0
-rw-r--r--browser/components/webextensions/extension-mac.css (renamed from browser/components/extensions/extension-mac.css)0
-rw-r--r--browser/components/webextensions/extension-win-panel.css5
-rw-r--r--browser/components/webextensions/extension.css (renamed from browser/components/extensions/extension.css)0
-rw-r--r--browser/components/webextensions/extension.svg (renamed from browser/components/extensions/extension.svg)0
-rw-r--r--browser/components/webextensions/extensions-browser.manifest (renamed from browser/components/extensions/extensions-browser.manifest)0
-rw-r--r--browser/components/webextensions/jar.mn (renamed from browser/components/extensions/jar.mn)0
-rw-r--r--browser/components/webextensions/moz.build (renamed from browser/components/extensions/moz.build)0
-rw-r--r--browser/components/webextensions/schemas/LICENSE (renamed from browser/components/extensions/schemas/LICENSE)0
-rw-r--r--browser/components/webextensions/schemas/bookmarks.json (renamed from browser/components/extensions/schemas/bookmarks.json)0
-rw-r--r--browser/components/webextensions/schemas/browser_action.json (renamed from browser/components/extensions/schemas/browser_action.json)0
-rw-r--r--browser/components/webextensions/schemas/commands.json (renamed from browser/components/extensions/schemas/commands.json)0
-rw-r--r--browser/components/webextensions/schemas/context_menus.json (renamed from browser/components/extensions/schemas/context_menus.json)0
-rw-r--r--browser/components/webextensions/schemas/context_menus_internal.json (renamed from browser/components/extensions/schemas/context_menus_internal.json)0
-rw-r--r--browser/components/webextensions/schemas/history.json (renamed from browser/components/extensions/schemas/history.json)0
-rw-r--r--browser/components/webextensions/schemas/jar.mn (renamed from browser/components/extensions/schemas/jar.mn)0
-rw-r--r--browser/components/webextensions/schemas/moz.build (renamed from browser/components/extensions/schemas/moz.build)0
-rw-r--r--browser/components/webextensions/schemas/omnibox.json (renamed from browser/components/extensions/schemas/omnibox.json)0
-rw-r--r--browser/components/webextensions/schemas/page_action.json (renamed from browser/components/extensions/schemas/page_action.json)1
-rw-r--r--browser/components/webextensions/schemas/sessions.json (renamed from browser/components/extensions/schemas/sessions.json)0
-rw-r--r--browser/components/webextensions/schemas/tabs.json (renamed from browser/components/extensions/schemas/tabs.json)0
-rw-r--r--browser/components/webextensions/schemas/windows.json (renamed from browser/components/extensions/schemas/windows.json)0
57 files changed, 121 insertions, 119 deletions
diff --git a/browser/components/build/moz.build b/browser/components/build/moz.build
index 8c99b74dd..622cf449c 100644
--- a/browser/components/build/moz.build
+++ b/browser/components/build/moz.build
@@ -12,8 +12,7 @@ SOURCES += [
'nsModule.cpp',
]
-Library('browsercomps')
-FINAL_LIBRARY = 'xul'
+XPCOMBinaryComponent('browsercomps')
LOCAL_INCLUDES += [
'../about',
@@ -22,3 +21,22 @@ LOCAL_INCLUDES += [
'../migration',
'../shell',
]
+
+if CONFIG['OS_ARCH'] == 'WINNT':
+ OS_LIBS += [
+ 'esent',
+ 'netapi32',
+ 'ole32',
+ 'shell32',
+ 'shlwapi',
+ 'version',
+ ]
+ DELAYLOAD_DLLS += [
+ 'esent.dll',
+ 'netapi32.dll',
+ ]
+
+# Mac: Need to link with CoreFoundation for Mac Migrators (PList reading code)
+# GTK2: Need to link with glib for GNOME shell service
+if CONFIG['MOZ_WIDGET_TOOLKIT'] in ('cocoa', 'gtk2', 'gtk3'):
+ OS_LIBS += CONFIG['TK_LIBS']
diff --git a/browser/components/customizableui/CustomizableUI.jsm b/browser/components/customizableui/CustomizableUI.jsm
index 86ff2708b..01389108d 100644
--- a/browser/components/customizableui/CustomizableUI.jsm
+++ b/browser/components/customizableui/CustomizableUI.jsm
@@ -262,24 +262,14 @@ var CustomizableUIInternal = {
defaultCollapsed: false,
}, true);
- if (AppConstants.platform != "macosx") {
+ if (AppConstants.MENUBAR_CAN_AUTOHIDE) {
this.registerArea(CustomizableUI.AREA_MENUBAR, {
legacy: true,
type: CustomizableUI.TYPE_TOOLBAR,
defaultPlacements: [
"menubar-items",
],
- get defaultCollapsed() {
- if (AppConstants.MENUBAR_CAN_AUTOHIDE) {
- if (AppConstants.platform == "linux") {
- return true;
- }
- // This is duplicated logic from /browser/base/jar.mn
- // for win6BrowserOverlay.xul.
- return AppConstants.isPlatformAndVersionAtLeast("win", 6);
- }
- return false;
- }
+ defaultCollapsed: true,
}, true);
}
diff --git a/browser/components/customizableui/CustomizableWidgets.jsm b/browser/components/customizableui/CustomizableWidgets.jsm
index 907e2e0f7..1e68b01c1 100644
--- a/browser/components/customizableui/CustomizableWidgets.jsm
+++ b/browser/components/customizableui/CustomizableWidgets.jsm
@@ -1187,10 +1187,7 @@ let preferencesButton = {
win.openPreferences();
}
};
-if (AppConstants.platform == "win") {
- preferencesButton.label = "preferences-button.labelWin";
- preferencesButton.tooltiptext = "preferences-button.tooltipWin2";
-} else if (AppConstants.platform == "macosx") {
+if (AppConstants.platform == "macosx") {
preferencesButton.tooltiptext = "preferences-button.tooltiptext.withshortcut";
preferencesButton.shortcutId = "key_preferencesCmdMac";
} else {
diff --git a/browser/components/dirprovider/DirectoryProvider.cpp b/browser/components/dirprovider/DirectoryProvider.cpp
index 7b4f81c7d..8b7c0b9e0 100644
--- a/browser/components/dirprovider/DirectoryProvider.cpp
+++ b/browser/components/dirprovider/DirectoryProvider.cpp
@@ -20,7 +20,7 @@
#include "nsDirectoryServiceUtils.h"
#include "mozilla/ModuleUtils.h"
#include "nsServiceManagerUtils.h"
-#include "nsString.h"
+#include "nsStringAPI.h"
#include "nsXULAppAPI.h"
#include "nsIPrefLocalizedString.h"
diff --git a/browser/components/downloads/DownloadsCommon.jsm b/browser/components/downloads/DownloadsCommon.jsm
index b6684817d..90f14f2d8 100644
--- a/browser/components/downloads/DownloadsCommon.jsm
+++ b/browser/components/downloads/DownloadsCommon.jsm
@@ -42,6 +42,8 @@ XPCOMUtils.defineLazyModuleGetter(this, "NetUtil",
"resource://gre/modules/NetUtil.jsm");
XPCOMUtils.defineLazyModuleGetter(this, "PluralForm",
"resource://gre/modules/PluralForm.jsm");
+XPCOMUtils.defineLazyModuleGetter(this, "AppConstants",
+ "resource://gre/modules/AppConstants.jsm");
XPCOMUtils.defineLazyModuleGetter(this, "Downloads",
"resource://gre/modules/Downloads.jsm");
XPCOMUtils.defineLazyModuleGetter(this, "DownloadUIHelper",
@@ -460,8 +462,12 @@ this.DownloadsCommon = {
throw new Error("aOwnerWindow must be a dom-window object");
}
+ let isWindowsExe = AppConstants.platform == "win" &&
+ aFile.leafName.toLowerCase().endsWith(".exe");
+
let promiseShouldLaunch;
- if (aFile.isExecutable()) {
+ // Don't prompt on Windows for .exe since there will be a native prompt.
+ if (aFile.isExecutable() && !isWindowsExe) {
// We get a prompter for the provided window here, even though anchoring
// to the most recently active window should work as well.
promiseShouldLaunch =
diff --git a/browser/components/extensions/extension-win-panel.css b/browser/components/extensions/extension-win-panel.css
deleted file mode 100644
index ddafe3ea5..000000000
--- a/browser/components/extensions/extension-win-panel.css
+++ /dev/null
@@ -1,7 +0,0 @@
-@media (-moz-os-version: windows-xp),
- (-moz-os-version: windows-vista),
- (-moz-os-version: windows-win7) {
- body {
- border-radius: 4px;
- }
-}
diff --git a/browser/components/feeds/nsFeedSniffer.cpp b/browser/components/feeds/nsFeedSniffer.cpp
index f2d0da776..f314d3d3b 100644
--- a/browser/components/feeds/nsFeedSniffer.cpp
+++ b/browser/components/feeds/nsFeedSniffer.cpp
@@ -185,15 +185,9 @@ IsDocumentElement(const char *start, const char* end)
static bool
ContainsTopLevelSubstring(nsACString& dataString, const char *substring)
{
- nsACString::const_iterator start, end;
- dataString.BeginReading(start);
- dataString.EndReading(end);
-
- if (!FindInReadable(nsCString(substring), start, end)){
+ int32_t offset = dataString.Find(substring);
+ if (offset == -1)
return false;
- }
-
- auto offset = start.get() - dataString.Data();
const char *begin = dataString.BeginReading();
@@ -318,10 +312,9 @@ nsFeedSniffer::GetMIMETypeFromContent(nsIRequest* request,
// RSS 1.0
if (!isFeed) {
- bool foundNS_RDF = FindInReadable(NS_LITERAL_CSTRING(NS_RDF), dataString);
- bool foundNS_RSS = FindInReadable(NS_LITERAL_CSTRING(NS_RSS), dataString);
isFeed = ContainsTopLevelSubstring(dataString, "<rdf:RDF") &&
- foundNS_RDF && foundNS_RSS;
+ dataString.Find(NS_RDF) != -1 &&
+ dataString.Find(NS_RSS) != -1;
}
// If we sniffed a feed, coerce our internal type
diff --git a/browser/components/feeds/nsFeedSniffer.h b/browser/components/feeds/nsFeedSniffer.h
index b7ac002bd..a0eb9862c 100644
--- a/browser/components/feeds/nsFeedSniffer.h
+++ b/browser/components/feeds/nsFeedSniffer.h
@@ -6,7 +6,7 @@
#include "nsIContentSniffer.h"
#include "nsIStreamListener.h"
-#include "nsString.h"
+#include "nsStringAPI.h"
#include "mozilla/Attributes.h"
class nsFeedSniffer final : public nsIContentSniffer,
diff --git a/browser/components/migration/nsIEHistoryEnumerator.cpp b/browser/components/migration/nsIEHistoryEnumerator.cpp
index 116e9a860..0b377d27e 100644
--- a/browser/components/migration/nsIEHistoryEnumerator.cpp
+++ b/browser/components/migration/nsIEHistoryEnumerator.cpp
@@ -9,10 +9,9 @@
#include "nsArrayEnumerator.h"
#include "nsCOMArray.h"
-#include "nsIURI.h"
#include "nsIVariant.h"
#include "nsNetUtil.h"
-#include "nsString.h"
+#include "nsStringAPI.h"
#include "nsWindowsMigrationUtils.h"
#include "prtime.h"
@@ -23,7 +22,7 @@ NS_IMPL_ISUPPORTS(nsIEHistoryEnumerator, nsISimpleEnumerator)
nsIEHistoryEnumerator::nsIEHistoryEnumerator()
{
- ::CoInitialize(nullptr);
+ ::CoInitialize(nullptr);
}
nsIEHistoryEnumerator::~nsIEHistoryEnumerator()
diff --git a/browser/components/moz.build b/browser/components/moz.build
index 3c0dea3fb..0393b6e92 100644
--- a/browser/components/moz.build
+++ b/browser/components/moz.build
@@ -10,7 +10,6 @@ DIRS += [
'customizableui',
'dirprovider',
'downloads',
- 'extensions',
'feeds',
'migration',
'newtab',
@@ -26,6 +25,9 @@ DIRS += [
'translation',
]
+if CONFIG['MOZ_WEBEXTENSIONS']:
+ DIRS += ['webextensions']
+
DIRS += ['build']
XPIDL_SOURCES += [
diff --git a/browser/components/nsBrowserGlue.js b/browser/components/nsBrowserGlue.js
index d69a11f6b..f97c173a0 100644
--- a/browser/components/nsBrowserGlue.js
+++ b/browser/components/nsBrowserGlue.js
@@ -64,6 +64,7 @@ XPCOMUtils.defineLazyServiceGetter(this, "AlertsService", "@mozilla.org/alerts-s
["Task", "resource://gre/modules/Task.jsm"],
["UITour", "resource:///modules/UITour.jsm"],
["URLBarZoom", "resource:///modules/URLBarZoom.jsm"],
+ ["UserAgentOverrides", "resource://gre/modules/UserAgentOverrides.jsm"],
["WebChannel", "resource://gre/modules/WebChannel.jsm"],
["WindowsRegistry", "resource://gre/modules/WindowsRegistry.jsm"],
["webrtcUI", "resource:///modules/webrtcUI.jsm"],
@@ -662,6 +663,8 @@ BrowserGlue.prototype = {
}
} catch (ex) { /* missing any of the prefs is not critical */ }
+ UserAgentOverrides.init();
+
PageThumbs.init();
webrtcUI.init();
AboutHome.init();
@@ -1042,6 +1045,7 @@ BrowserGlue.prototype = {
BrowserUsageTelemetry.uninit();
SelfSupportBackend.uninit();
+ UserAgentOverrides.uninit();
PageThumbs.uninit();
NewTabMessages.uninit();
AboutNewTab.uninit();
diff --git a/browser/components/preferences/in-content/preferences.xul b/browser/components/preferences/in-content/preferences.xul
index e9664eaf4..7ec7ef119 100644
--- a/browser/components/preferences/in-content/preferences.xul
+++ b/browser/components/preferences/in-content/preferences.xul
@@ -55,18 +55,10 @@
%advancedDTD;
]>
-#ifdef XP_WIN
-#define USE_WIN_TITLE_STYLE
-#endif
-
<page xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
xmlns:html="http://www.w3.org/1999/xhtml"
disablefastfind="true"
-#ifdef USE_WIN_TITLE_STYLE
- title="&prefWindow.titleWin;">
-#else
title="&prefWindow.title;">
-#endif
<html:link rel="shortcut icon"
href="chrome://browser/skin/preferences/in-content/favicon.ico"/>
diff --git a/browser/components/preferences/in-content/security.xul b/browser/components/preferences/in-content/security.xul
index a10576c25..b7bdb9361 100644
--- a/browser/components/preferences/in-content/security.xul
+++ b/browser/components/preferences/in-content/security.xul
@@ -45,6 +45,7 @@
<!-- Passwords -->
<preference id="signon.rememberSignons" name="signon.rememberSignons" type="bool"/>
+ <preference id="signon.autofillForms" name="signon.autofillForms" type="bool"/>
</preferences>
@@ -103,6 +104,9 @@
accesskey="&passwordExceptions.accesskey;"
preference="pref.privacy.disable_button.view_passwords_exceptions"/>
</hbox>
+ <checkbox id="autofillPasswords" flex="1"
+ label="&autofillPasswords.label;" accesskey="&autofillPasswords.accesskey;"
+ preference="signon.autofillForms"/>
<grid id="passwordGrid">
<columns>
<column flex="1"/>
diff --git a/browser/components/shell/ShellService.jsm b/browser/components/shell/ShellService.jsm
index 2a3400b60..cc225eae0 100644
--- a/browser/components/shell/ShellService.jsm
+++ b/browser/components/shell/ShellService.jsm
@@ -62,10 +62,10 @@ let ShellServiceInternal = {
if (AppConstants.platform == "win") {
let optOutValue = WindowsRegistry.readRegKey(Ci.nsIWindowsRegKey.ROOT_KEY_CURRENT_USER,
- "Software\\Mozilla\\Firefox",
+ "Software\\Mozilla\\Basilisk",
"DefaultBrowserOptOut");
WindowsRegistry.removeRegKey(Ci.nsIWindowsRegKey.ROOT_KEY_CURRENT_USER,
- "Software\\Mozilla\\Firefox",
+ "Software\\Mozilla\\Basilisk",
"DefaultBrowserOptOut");
if (optOutValue == "True") {
Services.prefs.setBoolPref("browser.shell.checkDefaultBrowser", false);
diff --git a/browser/components/shell/nsGNOMEShellService.cpp b/browser/components/shell/nsGNOMEShellService.cpp
index f6c2613d4..613b5bffc 100644
--- a/browser/components/shell/nsGNOMEShellService.cpp
+++ b/browser/components/shell/nsGNOMEShellService.cpp
@@ -14,7 +14,7 @@
#include "nsDirectoryServiceDefs.h"
#include "nsIPrefService.h"
#include "prenv.h"
-#include "nsString.h"
+#include "nsStringAPI.h"
#include "nsIGConfService.h"
#include "nsIGIOService.h"
#include "nsIGSettingsService.h"
@@ -70,16 +70,16 @@ static const MimeTypeAssociation appTypes[] = {
// GConf registry key constants
#define DG_BACKGROUND "/desktop/gnome/background"
-#define kDesktopImageKey DG_BACKGROUND "/picture_filename"
-#define kDesktopOptionsKey DG_BACKGROUND "/picture_options"
-#define kDesktopDrawBGKey DG_BACKGROUND "/draw_background"
-#define kDesktopColorKey DG_BACKGROUND "/primary_color"
+static const char kDesktopImageKey[] = DG_BACKGROUND "/picture_filename";
+static const char kDesktopOptionsKey[] = DG_BACKGROUND "/picture_options";
+static const char kDesktopDrawBGKey[] = DG_BACKGROUND "/draw_background";
+static const char kDesktopColorKey[] = DG_BACKGROUND "/primary_color";
-#define kDesktopBGSchema "org.gnome.desktop.background"
-#define kDesktopImageGSKey "picture-uri"
-#define kDesktopOptionGSKey "picture-options"
-#define kDesktopDrawBGGSKey "draw-background"
-#define kDesktopColorGSKey "primary-color"
+static const char kDesktopBGSchema[] = "org.gnome.desktop.background";
+static const char kDesktopImageGSKey[] = "picture-uri";
+static const char kDesktopOptionGSKey[] = "picture-options";
+static const char kDesktopDrawBGGSKey[] = "draw-background";
+static const char kDesktopColorGSKey[] = "primary-color";
nsresult
nsGNOMEShellService::Init()
@@ -451,7 +451,7 @@ nsGNOMEShellService::SetDesktopBackground(nsIDOMElement* aElement,
// Set the image to an empty string first to force a refresh
// (since we could be writing a new image on top of an existing
- // Firefox_wallpaper.png and nautilus doesn't monitor the file for changes)
+ // Basilisk_wallpaper.png and nautilus doesn't monitor the file for changes)
gconf->SetString(NS_LITERAL_CSTRING(kDesktopImageKey),
EmptyCString());
@@ -508,8 +508,7 @@ static void
ColorToCString(uint32_t aColor, nsCString& aResult)
{
// The #rrrrggggbbbb format is used to match gdk_color_to_string()
- aResult.SetLength(13);
- char *buf = aResult.BeginWriting();
+ char *buf = aResult.BeginWriting(13);
if (!buf)
return;
diff --git a/browser/components/shell/nsGNOMEShellService.h b/browser/components/shell/nsGNOMEShellService.h
index b3ef1a918..a7b003802 100644
--- a/browser/components/shell/nsGNOMEShellService.h
+++ b/browser/components/shell/nsGNOMEShellService.h
@@ -7,7 +7,7 @@
#define nsgnomeshellservice_h____
#include "nsIGNOMEShellService.h"
-#include "nsString.h"
+#include "nsStringAPI.h"
#include "mozilla/Attributes.h"
class nsGNOMEShellService final : public nsIGNOMEShellService
diff --git a/browser/components/shell/nsMacShellService.cpp b/browser/components/shell/nsMacShellService.cpp
index 48db4896b..d8d64039d 100644
--- a/browser/components/shell/nsMacShellService.cpp
+++ b/browser/components/shell/nsMacShellService.cpp
@@ -20,7 +20,7 @@
#include "nsIProperties.h"
#include "nsServiceManagerUtils.h"
#include "nsShellService.h"
-#include "nsString.h"
+#include "nsStringAPI.h"
#include "nsIDocShell.h"
#include "nsILoadContext.h"
diff --git a/browser/components/shell/nsWindowsShellService.cpp b/browser/components/shell/nsWindowsShellService.cpp
index 416e00cbc..879b0c7f0 100644
--- a/browser/components/shell/nsWindowsShellService.cpp
+++ b/browser/components/shell/nsWindowsShellService.cpp
@@ -12,7 +12,6 @@
#include "nsIDOMElement.h"
#include "nsIDOMHTMLImageElement.h"
#include "nsIImageLoadingContent.h"
-#include "nsIOutputStream.h"
#include "nsIPrefService.h"
#include "nsIPrefLocalizedString.h"
#include "nsIServiceManager.h"
@@ -102,18 +101,18 @@ OpenKeyForReading(HKEY aKeyRoot, const nsAString& aKeyName, HKEY* aKey)
// .htm .html .shtml .xht .xhtml
// are mapped like so:
//
-// HKCU\SOFTWARE\Classes\.<ext>\ (default) REG_SZ FirefoxHTML
+// HKCU\SOFTWARE\Classes\.<ext>\ (default) REG_SZ BasiliskHTML
//
// as aliases to the class:
//
-// HKCU\SOFTWARE\Classes\FirefoxHTML\
+// HKCU\SOFTWARE\Classes\BasiliskHTML\
// DefaultIcon (default) REG_SZ <apppath>,1
// shell\open\command (default) REG_SZ <apppath> -osint -url "%1"
// shell\open\ddeexec (default) REG_SZ <empty string>
//
// - Windows Vista and above Protocol Handler
//
-// HKCU\SOFTWARE\Classes\FirefoxURL\ (default) REG_SZ <appname> URL
+// HKCU\SOFTWARE\Classes\BasiliskURL\ (default) REG_SZ <appname> URL
// EditFlags REG_DWORD 2
// FriendlyTypeName REG_SZ <appname> URL
// DefaultIcon (default) REG_SZ <apppath>,1
@@ -133,10 +132,10 @@ OpenKeyForReading(HKEY aKeyRoot, const nsAString& aKeyName, HKEY* aKey)
//
// - Windows Start Menu (XP SP1 and newer)
// -------------------------------------------------
-// The following keys are set to make Firefox appear in the Start Menu as the
+// The following keys are set to make Basilisk appear in the Start Menu as the
// browser:
//
-// HKCU\SOFTWARE\Clients\StartMenuInternet\FIREFOX.EXE\
+// HKCU\SOFTWARE\Clients\StartMenuInternet\BASILISK.EXE\
// (default) REG_SZ <appname>
// DefaultIcon (default) REG_SZ <apppath>,0
// InstallInfo HideIconsCommand REG_SZ <uninstpath> /HideShortcuts
@@ -157,7 +156,7 @@ typedef struct {
const char* oldValueData;
} SETTING;
-#define APP_REG_NAME L"Firefox"
+#define APP_REG_NAME L"Basilisk"
#define VAL_FILE_ICON "%APPPATH%,1"
#define VAL_OPEN "\"%APPPATH%\" -osint -url \"%1\""
#define OLD_VAL_OPEN "\"%APPPATH%\" -requestPending -osint -url \"%1\""
@@ -171,11 +170,11 @@ typedef struct {
PREFIX MID
// The DefaultIcon registry key value should never be used when checking if
-// Firefox is the default browser for file handlers since other applications
+// Basilisk is the default browser for file handlers since other applications
// (e.g. MS Office) may modify the DefaultIcon registry key value to add Icon
// Handlers. see http://msdn2.microsoft.com/en-us/library/aa969357.aspx for
// more info. The FTP protocol is not checked so advanced users can set the FTP
-// handler to another application and still have Firefox check if it is the
+// handler to another application and still have Basilisk check if it is the
// default HTTP and HTTPS handler.
// *** Do not add additional checks here unless you skip them when aForAllTypes
// is false below***.
@@ -183,10 +182,10 @@ static SETTING gSettings[] = {
// File Handler Class
// ***keep this as the first entry because when aForAllTypes is not set below
// it will skip over this check.***
- { MAKE_KEY_NAME1("FirefoxHTML", SOC), VAL_OPEN, OLD_VAL_OPEN },
+ { MAKE_KEY_NAME1("BasiliskHTML", SOC), VAL_OPEN, OLD_VAL_OPEN },
// Protocol Handler Class - for Vista and above
- { MAKE_KEY_NAME1("FirefoxURL", SOC), VAL_OPEN, OLD_VAL_OPEN },
+ { MAKE_KEY_NAME1("BasiliskURL", SOC), VAL_OPEN, OLD_VAL_OPEN },
// Protocol Handlers
{ MAKE_KEY_NAME1("HTTP", DI), VAL_FILE_ICON },
@@ -196,14 +195,14 @@ static SETTING gSettings[] = {
};
// The settings to disable DDE are separate from the default browser settings
-// since they are only checked when Firefox is the default browser and if they
+// since they are only checked when Basilisk is the default browser and if they
// are incorrect they are fixed without notifying the user.
static SETTING gDDESettings[] = {
// File Handler Class
- { MAKE_KEY_NAME1("Software\\Classes\\FirefoxHTML", SOD) },
+ { MAKE_KEY_NAME1("Software\\Classes\\BasiliskHTML", SOD) },
// Protocol Handler Class - for Vista and above
- { MAKE_KEY_NAME1("Software\\Classes\\FirefoxURL", SOD) },
+ { MAKE_KEY_NAME1("Software\\Classes\\BasiliskURL", SOD) },
// Protocol Handlers
{ MAKE_KEY_NAME1("Software\\Classes\\FTP", SOD) },
@@ -340,7 +339,7 @@ IsAARDefault(const RefPtr<IApplicationAssociationRegistration>& pAAR,
return false;
}
- LPCWSTR progID = isProtocol ? L"FirefoxURL" : L"FirefoxHTML";
+ LPCWSTR progID = isProtocol ? L"BasiliskURL" : L"BasiliskHTML";
bool isDefault = !wcsicmp(registeredApp, progID);
CoTaskMemFree(registeredApp);
@@ -372,9 +371,9 @@ IsDefaultBrowserWin8(bool aCheckAllTypes, bool* aIsDefaultBrowser)
/*
* Query's the AAR for the default status.
- * This only checks for FirefoxURL and if aCheckAllTypes is set, then
- * it also checks for FirefoxHTML. Note that those ProgIDs are shared
- * by all Firefox browsers.
+ * This only checks for BasiliskURL and if aCheckAllTypes is set, then
+ * it also checks for BasiliskHTML. Note that those ProgIDs are shared
+ * by all Basilisk browsers.
*/
bool
nsWindowsShellService::IsDefaultBrowserVista(bool aCheckAllTypes,
@@ -417,7 +416,7 @@ nsWindowsShellService::IsDefaultBrowser(bool aStartupCheck,
return NS_ERROR_FAILURE;
// Convert the path to a long path since GetModuleFileNameW returns the path
- // that was used to launch Firefox which is not necessarily a long path.
+ // that was used to launch Basilisk which is not necessarily a long path.
if (!::GetLongPathNameW(exePath, exePath, MAX_BUF))
return NS_ERROR_FAILURE;
@@ -466,31 +465,32 @@ nsWindowsShellService::IsDefaultBrowser(bool aStartupCheck,
return NS_OK;
}
- res = ::RegOpenKeyExW(HKEY_CLASSES_ROOT, keyName.get(),
+ res = ::RegOpenKeyExW(HKEY_CLASSES_ROOT, PromiseFlatString(keyName).get(),
0, KEY_SET_VALUE, &theKey);
if (REG_FAILED(res)) {
// If updating the open command fails try to update it using the helper
- // application when setting Firefox as the default browser.
+ // application when setting Basilisk as the default browser.
*aIsDefaultBrowser = false;
return NS_OK;
}
+ const nsString &flatValue = PromiseFlatString(valueData);
res = ::RegSetValueExW(theKey, L"", 0, REG_SZ,
- (const BYTE *) valueData.get(),
- (valueData.Length() + 1) * sizeof(char16_t));
+ (const BYTE *) flatValue.get(),
+ (flatValue.Length() + 1) * sizeof(char16_t));
// Close the key that was created.
::RegCloseKey(theKey);
if (REG_FAILED(res)) {
// If updating the open command fails try to update it using the helper
- // application when setting Firefox as the default browser.
+ // application when setting Basilisk as the default browser.
*aIsDefaultBrowser = false;
return NS_OK;
}
}
}
- // Only check if Firefox is the default browser on Vista and above if the
- // previous checks show that Firefox is the default browser.
+ // Only check if Basilisk is the default browser on Vista and above if the
+ // previous checks show that Basilisk is the default browser.
if (*aIsDefaultBrowser) {
IsDefaultBrowserVista(aForAllTypes, aIsDefaultBrowser);
if (IsWin8OrLater()) {
@@ -499,9 +499,9 @@ nsWindowsShellService::IsDefaultBrowser(bool aStartupCheck,
}
// To handle the case where DDE isn't disabled due for a user because there
- // account didn't perform a Firefox update this will check if Firefox is the
+ // account didn't perform a Basilisk update this will check if Basilisk is the
// default browser and if dde is disabled for each handler
- // and if it isn't disable it. When Firefox is not the default browser the
+ // and if it isn't disable it. When Basilisk is not the default browser the
// helper application will disable dde for each handler.
if (*aIsDefaultBrowser && aForAllTypes) {
// Check ftp settings
@@ -515,7 +515,7 @@ nsWindowsShellService::IsDefaultBrowser(bool aStartupCheck,
if (NS_FAILED(rv)) {
::RegCloseKey(theKey);
// If disabling DDE fails try to disable it using the helper
- // application when setting Firefox as the default browser.
+ // application when setting Basilisk as the default browser.
*aIsDefaultBrowser = false;
return NS_OK;
}
@@ -529,13 +529,14 @@ nsWindowsShellService::IsDefaultBrowser(bool aStartupCheck,
if (REG_FAILED(res) || char16_t('\0') != *currValue) {
// Key wasn't set or was set to something other than our registry entry.
// Delete the key along with all of its childrean and then recreate it.
- ::SHDeleteKeyW(HKEY_CURRENT_USER, keyName.get());
- res = ::RegCreateKeyExW(HKEY_CURRENT_USER, keyName.get(), 0, nullptr,
+ const nsString &flatName = PromiseFlatString(keyName);
+ ::SHDeleteKeyW(HKEY_CURRENT_USER, flatName.get());
+ res = ::RegCreateKeyExW(HKEY_CURRENT_USER, flatName.get(), 0, nullptr,
REG_OPTION_NON_VOLATILE, KEY_SET_VALUE,
nullptr, &theKey, nullptr);
if (REG_FAILED(res)) {
// If disabling DDE fails try to disable it using the helper
- // application when setting Firefox as the default browser.
+ // application when setting Basilisk as the default browser.
*aIsDefaultBrowser = false;
return NS_OK;
}
@@ -546,7 +547,7 @@ nsWindowsShellService::IsDefaultBrowser(bool aStartupCheck,
::RegCloseKey(theKey);
if (REG_FAILED(res)) {
// If disabling DDE fails try to disable it using the helper
- // application when setting Firefox as the default browser.
+ // application when setting Basilisk as the default browser.
*aIsDefaultBrowser = false;
return NS_OK;
}
@@ -582,13 +583,14 @@ nsWindowsShellService::IsDefaultBrowser(bool aStartupCheck,
NS_ConvertUTF8toUTF16 valueData(VAL_OPEN);
valueData.Replace(offset, 9, appLongPath);
+ const nsString &flatValue = PromiseFlatString(valueData);
res = ::RegSetValueExW(theKey, L"", 0, REG_SZ,
- (const BYTE *) valueData.get(),
- (valueData.Length() + 1) * sizeof(char16_t));
+ (const BYTE *) flatValue.get(),
+ (flatValue.Length() + 1) * sizeof(char16_t));
// Close the key that was created.
::RegCloseKey(theKey);
// If updating the FTP protocol handlers shell open command fails try to
- // update it using the helper application when setting Firefox as the
+ // update it using the helper application when setting Basilisk as the
// default browser.
if (REG_FAILED(res)) {
*aIsDefaultBrowser = false;
@@ -646,11 +648,6 @@ nsWindowsShellService::LaunchControlPanelDefaultsSelectionUI()
nsresult
nsWindowsShellService::LaunchControlPanelDefaultPrograms()
{
- // This Default Programs feature is Win7+ only.
- if (!IsWin7OrLater()) {
- return NS_ERROR_FAILURE;
- }
-
// Build the path control.exe path safely
WCHAR controlEXEPath[MAX_PATH + 1] = { '\0' };
if (!GetSystemDirectoryW(controlEXEPath, MAX_PATH)) {
@@ -1005,7 +1002,7 @@ nsWindowsShellService::SetDesktopBackground(nsIDOMElement* aElement,
getter_AddRefs(file));
NS_ENSURE_SUCCESS(rv, rv);
- // eventually, the path is "%APPDATA%\Mozilla\Firefox\Desktop Background.bmp"
+ // eventually, the path is "%APPDATA%\Mozilla\Basilisk\Desktop Background.bmp"
rv = file->Append(fileLeafName);
NS_ENSURE_SUCCESS(rv, rv);
diff --git a/browser/components/shell/nsWindowsShellService.h b/browser/components/shell/nsWindowsShellService.h
index b9c473a15..06c6c3c9b 100644
--- a/browser/components/shell/nsWindowsShellService.h
+++ b/browser/components/shell/nsWindowsShellService.h
@@ -7,7 +7,7 @@
#define nswindowsshellservice_h____
#include "nscore.h"
-#include "nsString.h"
+#include "nsStringAPI.h"
#include "nsIWindowsShellService.h"
#include "nsITimer.h"
diff --git a/browser/components/extensions/.eslintrc.js b/browser/components/webextensions/.eslintrc.js
index 81a11c4ac..81a11c4ac 100644
--- a/browser/components/extensions/.eslintrc.js
+++ b/browser/components/webextensions/.eslintrc.js
diff --git a/browser/components/extensions/ext-bookmarks.js b/browser/components/webextensions/ext-bookmarks.js
index 399f6212d..399f6212d 100644
--- a/browser/components/extensions/ext-bookmarks.js
+++ b/browser/components/webextensions/ext-bookmarks.js
diff --git a/browser/components/extensions/ext-browserAction.js b/browser/components/webextensions/ext-browserAction.js
index 97c6fd22c..2c82ac701 100644
--- a/browser/components/extensions/ext-browserAction.js
+++ b/browser/components/webextensions/ext-browserAction.js
@@ -9,9 +9,9 @@ XPCOMUtils.defineLazyModuleGetter(this, "clearTimeout",
XPCOMUtils.defineLazyModuleGetter(this, "setTimeout",
"resource://gre/modules/Timer.jsm");
-XPCOMUtils.defineLazyGetter(this, "colorUtils", () => {
- return require("devtools/shared/css/color").colorUtils;
-});
+XPCOMUtils.defineLazyServiceGetter(this, "DOMUtils",
+ "@mozilla.org/inspector/dom-utils;1",
+ "inIDOMUtils");
Cu.import("resource://devtools/shared/event-emitter.js");
Cu.import("resource://gre/modules/ExtensionUtils.jsm");
@@ -497,6 +497,9 @@ extensions.registerSchemaAPI("browserAction", "addon_parent", context => {
// For internal consistency, we currently resolve both relative to the
// calling context.
let url = details.popup && context.uri.resolve(details.popup);
+ if (url && !context.checkLoadURL(url)) {
+ return Promise.reject({message: `Access denied for URL ${url}`});
+ }
BrowserAction.for(extension).setProperty(tab, "popup", url);
},
@@ -511,7 +514,7 @@ extensions.registerSchemaAPI("browserAction", "addon_parent", context => {
let tab = details.tabId !== null ? TabManager.getTab(details.tabId, context) : null;
let color = details.color;
if (!Array.isArray(color)) {
- let col = colorUtils.colorToRGBA(color);
+ let col = DOMUtils.colorToRGBA(color);
color = col && [col.r, col.g, col.b, Math.round(col.a * 255)];
}
BrowserAction.for(extension).setProperty(tab, "badgeBackgroundColor", color);
diff --git a/browser/components/extensions/ext-c-contextMenus.js b/browser/components/webextensions/ext-c-contextMenus.js
index 9fde90808..9fde90808 100644
--- a/browser/components/extensions/ext-c-contextMenus.js
+++ b/browser/components/webextensions/ext-c-contextMenus.js
diff --git a/browser/components/extensions/ext-c-omnibox.js b/browser/components/webextensions/ext-c-omnibox.js
index 3b9b6e2f7..3b9b6e2f7 100644
--- a/browser/components/extensions/ext-c-omnibox.js
+++ b/browser/components/webextensions/ext-c-omnibox.js
diff --git a/browser/components/extensions/ext-c-tabs.js b/browser/components/webextensions/ext-c-tabs.js
index d5ce9fbf9..d5ce9fbf9 100644
--- a/browser/components/extensions/ext-c-tabs.js
+++ b/browser/components/webextensions/ext-c-tabs.js
diff --git a/browser/components/extensions/ext-commands.js b/browser/components/webextensions/ext-commands.js
index 416544e86..416544e86 100644
--- a/browser/components/extensions/ext-commands.js
+++ b/browser/components/webextensions/ext-commands.js
diff --git a/browser/components/extensions/ext-contextMenus.js b/browser/components/webextensions/ext-contextMenus.js
index b3bf8aa53..b3bf8aa53 100644
--- a/browser/components/extensions/ext-contextMenus.js
+++ b/browser/components/webextensions/ext-contextMenus.js
diff --git a/browser/components/extensions/ext-desktop-runtime.js b/browser/components/webextensions/ext-desktop-runtime.js
index 0fdb45562..0fdb45562 100644
--- a/browser/components/extensions/ext-desktop-runtime.js
+++ b/browser/components/webextensions/ext-desktop-runtime.js
diff --git a/browser/components/extensions/ext-history.js b/browser/components/webextensions/ext-history.js
index a47df1621..a47df1621 100644
--- a/browser/components/extensions/ext-history.js
+++ b/browser/components/webextensions/ext-history.js
diff --git a/browser/components/extensions/ext-omnibox.js b/browser/components/webextensions/ext-omnibox.js
index 9b2f60ca4..9b2f60ca4 100644
--- a/browser/components/extensions/ext-omnibox.js
+++ b/browser/components/webextensions/ext-omnibox.js
diff --git a/browser/components/extensions/ext-pageAction.js b/browser/components/webextensions/ext-pageAction.js
index 153f05d7a..5bf3a9c70 100644
--- a/browser/components/extensions/ext-pageAction.js
+++ b/browser/components/webextensions/ext-pageAction.js
@@ -273,6 +273,9 @@ extensions.registerSchemaAPI("pageAction", "addon_parent", context => {
// For internal consistency, we currently resolve both relative to the
// calling context.
let url = details.popup && context.uri.resolve(details.popup);
+ if (url && !context.checkLoadURL(url)) {
+ return Promise.reject({message: `Access denied for URL ${url}`});
+ }
PageAction.for(extension).setProperty(tab, "popup", url);
},
diff --git a/browser/components/extensions/ext-sessions.js b/browser/components/webextensions/ext-sessions.js
index 4c13a1ac3..4c13a1ac3 100644
--- a/browser/components/extensions/ext-sessions.js
+++ b/browser/components/webextensions/ext-sessions.js
diff --git a/browser/components/extensions/ext-tabs.js b/browser/components/webextensions/ext-tabs.js
index bb575aaab..bb575aaab 100644
--- a/browser/components/extensions/ext-tabs.js
+++ b/browser/components/webextensions/ext-tabs.js
diff --git a/browser/components/extensions/ext-utils.js b/browser/components/webextensions/ext-utils.js
index 57c38a339..75b2f4bd4 100644
--- a/browser/components/extensions/ext-utils.js
+++ b/browser/components/webextensions/ext-utils.js
@@ -17,10 +17,6 @@ XPCOMUtils.defineLazyServiceGetter(this, "styleSheetService",
"@mozilla.org/content/style-sheet-service;1",
"nsIStyleSheetService");
-XPCOMUtils.defineLazyGetter(this, "colorUtils", () => {
- return require("devtools/shared/css/color").colorUtils;
-});
-
Cu.import("resource://gre/modules/ExtensionUtils.jsm");
Cu.import("resource://gre/modules/AppConstants.jsm");
diff --git a/browser/components/extensions/ext-windows.js b/browser/components/webextensions/ext-windows.js
index 5956ae15b..5956ae15b 100644
--- a/browser/components/extensions/ext-windows.js
+++ b/browser/components/webextensions/ext-windows.js
diff --git a/browser/components/extensions/extension-mac-panel.css b/browser/components/webextensions/extension-mac-panel.css
index 2e9ed6bdb..2e9ed6bdb 100644
--- a/browser/components/extensions/extension-mac-panel.css
+++ b/browser/components/webextensions/extension-mac-panel.css
diff --git a/browser/components/extensions/extension-mac.css b/browser/components/webextensions/extension-mac.css
index 49cd3b359..49cd3b359 100644
--- a/browser/components/extensions/extension-mac.css
+++ b/browser/components/webextensions/extension-mac.css
diff --git a/browser/components/webextensions/extension-win-panel.css b/browser/components/webextensions/extension-win-panel.css
new file mode 100644
index 000000000..9da6da14c
--- /dev/null
+++ b/browser/components/webextensions/extension-win-panel.css
@@ -0,0 +1,5 @@
+@media (-moz-os-version: windows-win7) {
+ body {
+ border-radius: 4px;
+ }
+}
diff --git a/browser/components/extensions/extension.css b/browser/components/webextensions/extension.css
index 6b59033e3..6b59033e3 100644
--- a/browser/components/extensions/extension.css
+++ b/browser/components/webextensions/extension.css
diff --git a/browser/components/extensions/extension.svg b/browser/components/webextensions/extension.svg
index a16455253..a16455253 100644
--- a/browser/components/extensions/extension.svg
+++ b/browser/components/webextensions/extension.svg
diff --git a/browser/components/extensions/extensions-browser.manifest b/browser/components/webextensions/extensions-browser.manifest
index ed5cca813..ed5cca813 100644
--- a/browser/components/extensions/extensions-browser.manifest
+++ b/browser/components/webextensions/extensions-browser.manifest
diff --git a/browser/components/extensions/jar.mn b/browser/components/webextensions/jar.mn
index a7b506ec4..a7b506ec4 100644
--- a/browser/components/extensions/jar.mn
+++ b/browser/components/webextensions/jar.mn
diff --git a/browser/components/extensions/moz.build b/browser/components/webextensions/moz.build
index 116e90415..116e90415 100644
--- a/browser/components/extensions/moz.build
+++ b/browser/components/webextensions/moz.build
diff --git a/browser/components/extensions/schemas/LICENSE b/browser/components/webextensions/schemas/LICENSE
index 9314092fd..9314092fd 100644
--- a/browser/components/extensions/schemas/LICENSE
+++ b/browser/components/webextensions/schemas/LICENSE
diff --git a/browser/components/extensions/schemas/bookmarks.json b/browser/components/webextensions/schemas/bookmarks.json
index fb74c633e..fb74c633e 100644
--- a/browser/components/extensions/schemas/bookmarks.json
+++ b/browser/components/webextensions/schemas/bookmarks.json
diff --git a/browser/components/extensions/schemas/browser_action.json b/browser/components/webextensions/schemas/browser_action.json
index 1a7da956a..1a7da956a 100644
--- a/browser/components/extensions/schemas/browser_action.json
+++ b/browser/components/webextensions/schemas/browser_action.json
diff --git a/browser/components/extensions/schemas/commands.json b/browser/components/webextensions/schemas/commands.json
index a1632088e..a1632088e 100644
--- a/browser/components/extensions/schemas/commands.json
+++ b/browser/components/webextensions/schemas/commands.json
diff --git a/browser/components/extensions/schemas/context_menus.json b/browser/components/webextensions/schemas/context_menus.json
index b31af51f3..b31af51f3 100644
--- a/browser/components/extensions/schemas/context_menus.json
+++ b/browser/components/webextensions/schemas/context_menus.json
diff --git a/browser/components/extensions/schemas/context_menus_internal.json b/browser/components/webextensions/schemas/context_menus_internal.json
index c3cb7aff0..c3cb7aff0 100644
--- a/browser/components/extensions/schemas/context_menus_internal.json
+++ b/browser/components/webextensions/schemas/context_menus_internal.json
diff --git a/browser/components/extensions/schemas/history.json b/browser/components/webextensions/schemas/history.json
index e05569e38..e05569e38 100644
--- a/browser/components/extensions/schemas/history.json
+++ b/browser/components/webextensions/schemas/history.json
diff --git a/browser/components/extensions/schemas/jar.mn b/browser/components/webextensions/schemas/jar.mn
index c9fc9a808..c9fc9a808 100644
--- a/browser/components/extensions/schemas/jar.mn
+++ b/browser/components/webextensions/schemas/jar.mn
diff --git a/browser/components/extensions/schemas/moz.build b/browser/components/webextensions/schemas/moz.build
index aac3a838c..aac3a838c 100644
--- a/browser/components/extensions/schemas/moz.build
+++ b/browser/components/webextensions/schemas/moz.build
diff --git a/browser/components/extensions/schemas/omnibox.json b/browser/components/webextensions/schemas/omnibox.json
index 34428fab7..34428fab7 100644
--- a/browser/components/extensions/schemas/omnibox.json
+++ b/browser/components/webextensions/schemas/omnibox.json
diff --git a/browser/components/extensions/schemas/page_action.json b/browser/components/webextensions/schemas/page_action.json
index f4f9ee8db..126378ca5 100644
--- a/browser/components/extensions/schemas/page_action.json
+++ b/browser/components/webextensions/schemas/page_action.json
@@ -173,6 +173,7 @@
{
"name": "setPopup",
"type": "function",
+ "async": true,
"description": "Sets the html document to be opened as a popup when the user clicks on the page action's icon.",
"parameters": [
{
diff --git a/browser/components/extensions/schemas/sessions.json b/browser/components/webextensions/schemas/sessions.json
index 690bb8ebc..690bb8ebc 100644
--- a/browser/components/extensions/schemas/sessions.json
+++ b/browser/components/webextensions/schemas/sessions.json
diff --git a/browser/components/extensions/schemas/tabs.json b/browser/components/webextensions/schemas/tabs.json
index 23ce33a4b..23ce33a4b 100644
--- a/browser/components/extensions/schemas/tabs.json
+++ b/browser/components/webextensions/schemas/tabs.json
diff --git a/browser/components/extensions/schemas/windows.json b/browser/components/webextensions/schemas/windows.json
index 8453358b5..8453358b5 100644
--- a/browser/components/extensions/schemas/windows.json
+++ b/browser/components/webextensions/schemas/windows.json