summaryrefslogtreecommitdiffstats
path: root/toolkit
diff options
context:
space:
mode:
authorwolfbeast <mcwerewolf@wolfbeast.com>2020-02-17 16:19:05 +0100
committerwolfbeast <mcwerewolf@wolfbeast.com>2020-02-17 16:19:05 +0100
commit4889e6dbbd2e13e778e7a244e7834ffc881e7a80 (patch)
tree94957f63b532f2eb57c7ee17a60deb7db5a857c2 /toolkit
parenta4ab3fc59dcd26d527716ae8ed23adf9148cb699 (diff)
downloadUXP-4889e6dbbd2e13e778e7a244e7834ffc881e7a80.tar
UXP-4889e6dbbd2e13e778e7a244e7834ffc881e7a80.tar.gz
UXP-4889e6dbbd2e13e778e7a244e7834ffc881e7a80.tar.lz
UXP-4889e6dbbd2e13e778e7a244e7834ffc881e7a80.tar.xz
UXP-4889e6dbbd2e13e778e7a244e7834ffc881e7a80.zip
Issue #1446 - Only match extension add-on types for target applications.
This resolves #1446
Diffstat (limited to 'toolkit')
-rw-r--r--toolkit/mozapps/extensions/internal/XPIProvider.jsm15
1 files changed, 9 insertions, 6 deletions
diff --git a/toolkit/mozapps/extensions/internal/XPIProvider.jsm b/toolkit/mozapps/extensions/internal/XPIProvider.jsm
index 2f298a934..d12e1de59 100644
--- a/toolkit/mozapps/extensions/internal/XPIProvider.jsm
+++ b/toolkit/mozapps/extensions/internal/XPIProvider.jsm
@@ -6528,12 +6528,15 @@ AddonInternal.prototype = {
app = targetApp;
}
#ifdef MOZ_PHOENIX_EXTENSIONS
- //Special case: check for Firefox TargetApps. this has to be done AFTER
- //the initial check to make sure appinfo.ID is preferred, even if
- //Firefox is listed before it in the install manifest.
- for (let targetApp of this.targetApplications) {
- if (targetApp.id == FIREFOX_ID) //Firefox GUID
- return targetApp;
+ // Special case: check for Firefox TargetApps. this has to be done AFTER
+ // the initial check to make sure appinfo.ID is preferred, even if
+ // Firefox is listed before it in the install manifest.
+ // Only do this for extensions. Other types should not be allowed.
+ if (this.type == "extension") {
+ for (let targetApp of this.targetApplications) {
+ if (targetApp.id == FIREFOX_ID) //Firefox GUID
+ return targetApp;
+ }
}
#endif
// Return toolkit ID if toolkit.