summaryrefslogtreecommitdiffstats
path: root/mailnews/extensions
diff options
context:
space:
mode:
authorMatt A. Tobin <email@mattatobin.com>2019-11-10 19:11:03 -0500
committerMatt A. Tobin <email@mattatobin.com>2019-11-10 19:11:03 -0500
commit201683afe4596ae32f7b1ea12dfca52995d59f9d (patch)
tree8632173f59a85d1c3bf679653de7957a59c96eae /mailnews/extensions
parent4db1ae892bad565e8e59ec6034b4c98946077248 (diff)
downloadUXP-201683afe4596ae32f7b1ea12dfca52995d59f9d.tar
UXP-201683afe4596ae32f7b1ea12dfca52995d59f9d.tar.gz
UXP-201683afe4596ae32f7b1ea12dfca52995d59f9d.tar.lz
UXP-201683afe4596ae32f7b1ea12dfca52995d59f9d.tar.xz
UXP-201683afe4596ae32f7b1ea12dfca52995d59f9d.zip
Bug 1487082 - Resolve potential for build bustage regarding bad implicit conversion constructors
* Part 1: make conversion CTORs explicit. Minor tweaks to conform with new(ish) static analysis rule which flags up implicit single-argument conversion constructors. * Part 2: fix a couple of double-mRefCnt declaration errors. * Part 3: Fix unsafe use of NS_ConvertASCIItoUTF16(). Tag #1273
Diffstat (limited to 'mailnews/extensions')
-rw-r--r--mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp2
-rw-r--r--mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.h4
2 files changed, 3 insertions, 3 deletions
diff --git a/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp b/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp
index 0fa5aa1e2..d0336db1d 100644
--- a/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp
+++ b/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp
@@ -898,7 +898,7 @@ public:
NS_DECL_NSISTREAMLISTENER
NS_DECL_NSIMSGHEADERSINK
- TokenStreamListener(TokenAnalyzer* analyzer);
+ explicit TokenStreamListener(TokenAnalyzer* analyzer);
protected:
virtual ~TokenStreamListener();
TokenAnalyzer* mAnalyzer;
diff --git a/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.h b/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.h
index 32a9d26d0..a1e2beaab 100644
--- a/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.h
+++ b/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.h
@@ -40,7 +40,7 @@ struct CorpusToken;
*/
class TokenEnumeration {
public:
- TokenEnumeration(PLDHashTable* table);
+ explicit TokenEnumeration(PLDHashTable* table);
bool hasMoreTokens();
BaseToken* nextToken();
@@ -96,7 +96,7 @@ public:
BaseToken* add(const char* word);
protected:
- TokenHash(uint32_t entrySize);
+ explicit TokenHash(uint32_t entrySize);
PLArenaPool mWordPool;
uint32_t mEntrySize;
PLDHashTable mTokenTable;