summaryrefslogtreecommitdiffstats
path: root/mailnews/db
diff options
context:
space:
mode:
authorMatt A. Tobin <email@mattatobin.com>2019-11-10 19:11:03 -0500
committerMatt A. Tobin <email@mattatobin.com>2019-11-10 19:11:03 -0500
commit201683afe4596ae32f7b1ea12dfca52995d59f9d (patch)
tree8632173f59a85d1c3bf679653de7957a59c96eae /mailnews/db
parent4db1ae892bad565e8e59ec6034b4c98946077248 (diff)
downloadUXP-201683afe4596ae32f7b1ea12dfca52995d59f9d.tar
UXP-201683afe4596ae32f7b1ea12dfca52995d59f9d.tar.gz
UXP-201683afe4596ae32f7b1ea12dfca52995d59f9d.tar.lz
UXP-201683afe4596ae32f7b1ea12dfca52995d59f9d.tar.xz
UXP-201683afe4596ae32f7b1ea12dfca52995d59f9d.zip
Bug 1487082 - Resolve potential for build bustage regarding bad implicit conversion constructors
* Part 1: make conversion CTORs explicit. Minor tweaks to conform with new(ish) static analysis rule which flags up implicit single-argument conversion constructors. * Part 2: fix a couple of double-mRefCnt declaration errors. * Part 3: Fix unsafe use of NS_ConvertASCIItoUTF16(). Tag #1273
Diffstat (limited to 'mailnews/db')
-rw-r--r--mailnews/db/msgdb/public/nsDBFolderInfo.h2
-rw-r--r--mailnews/db/msgdb/src/nsMailDatabase.cpp2
-rw-r--r--mailnews/db/msgdb/src/nsMsgDatabase.cpp2
-rw-r--r--mailnews/db/msgdb/src/nsMsgHdr.cpp2
4 files changed, 4 insertions, 4 deletions
diff --git a/mailnews/db/msgdb/public/nsDBFolderInfo.h b/mailnews/db/msgdb/public/nsDBFolderInfo.h
index 9b3a51348..b9747feb9 100644
--- a/mailnews/db/msgdb/public/nsDBFolderInfo.h
+++ b/mailnews/db/msgdb/public/nsDBFolderInfo.h
@@ -31,7 +31,7 @@ class nsDBFolderInfo : public nsIDBFolderInfo
public:
friend class nsMsgDatabase;
- nsDBFolderInfo(nsMsgDatabase *mdb);
+ explicit nsDBFolderInfo(nsMsgDatabase *mdb);
NS_DECL_ISUPPORTS
// interface methods.
diff --git a/mailnews/db/msgdb/src/nsMailDatabase.cpp b/mailnews/db/msgdb/src/nsMailDatabase.cpp
index 13a53485f..b9202a4b2 100644
--- a/mailnews/db/msgdb/src/nsMailDatabase.cpp
+++ b/mailnews/db/msgdb/src/nsMailDatabase.cpp
@@ -336,7 +336,7 @@ public:
// nsISimpleEnumerator methods:
NS_DECL_NSISIMPLEENUMERATOR
- nsMsgOfflineOpEnumerator(nsMailDatabase* db);
+ explicit nsMsgOfflineOpEnumerator(nsMailDatabase* db);
protected:
virtual ~nsMsgOfflineOpEnumerator();
diff --git a/mailnews/db/msgdb/src/nsMsgDatabase.cpp b/mailnews/db/msgdb/src/nsMsgDatabase.cpp
index 8b366ab5c..eb5f345f6 100644
--- a/mailnews/db/msgdb/src/nsMsgDatabase.cpp
+++ b/mailnews/db/msgdb/src/nsMsgDatabase.cpp
@@ -1024,7 +1024,7 @@ class MsgDBReporter final : public nsIMemoryReporter
{
nsMsgDatabase *mDatabase;
public:
- MsgDBReporter(nsMsgDatabase *db) : mDatabase(db) {}
+ explicit MsgDBReporter(nsMsgDatabase *db) : mDatabase(db) {}
NS_DECL_ISUPPORTS
NS_IMETHOD GetName(nsACString &aName)
diff --git a/mailnews/db/msgdb/src/nsMsgHdr.cpp b/mailnews/db/msgdb/src/nsMsgHdr.cpp
index ba1663e3b..136079473 100644
--- a/mailnews/db/msgdb/src/nsMsgHdr.cpp
+++ b/mailnews/db/msgdb/src/nsMsgHdr.cpp
@@ -998,7 +998,7 @@ public:
NS_DECL_ISUPPORTS
NS_DECL_NSIUTF8STRINGENUMERATOR
- nsMsgPropertyEnumerator(nsMsgHdr* aHdr);
+ explicit nsMsgPropertyEnumerator(nsMsgHdr* aHdr);
void PrefetchNext();
protected: