diff options
| author | Matt A. Tobin <email@mattatobin.com> | 2019-11-10 19:11:03 -0500 |
|---|---|---|
| committer | Matt A. Tobin <email@mattatobin.com> | 2019-11-10 19:11:03 -0500 |
| commit | 201683afe4596ae32f7b1ea12dfca52995d59f9d (patch) | |
| tree | 8632173f59a85d1c3bf679653de7957a59c96eae /mailnews/compose/src/nsSmtpProtocol.cpp | |
| parent | 4db1ae892bad565e8e59ec6034b4c98946077248 (diff) | |
| download | UXP-201683afe4596ae32f7b1ea12dfca52995d59f9d.tar UXP-201683afe4596ae32f7b1ea12dfca52995d59f9d.tar.gz UXP-201683afe4596ae32f7b1ea12dfca52995d59f9d.tar.lz UXP-201683afe4596ae32f7b1ea12dfca52995d59f9d.tar.xz UXP-201683afe4596ae32f7b1ea12dfca52995d59f9d.zip | |
Bug 1487082 - Resolve potential for build bustage regarding bad implicit conversion constructors
* Part 1: make conversion CTORs explicit.
Minor tweaks to conform with new(ish) static analysis rule which flags up implicit single-argument conversion constructors.
* Part 2: fix a couple of double-mRefCnt declaration errors.
* Part 3: Fix unsafe use of NS_ConvertASCIItoUTF16().
Tag #1273
Diffstat (limited to 'mailnews/compose/src/nsSmtpProtocol.cpp')
| -rw-r--r-- | mailnews/compose/src/nsSmtpProtocol.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/mailnews/compose/src/nsSmtpProtocol.cpp b/mailnews/compose/src/nsSmtpProtocol.cpp index 54d1e6f64..04347c1d0 100644 --- a/mailnews/compose/src/nsSmtpProtocol.cpp +++ b/mailnews/compose/src/nsSmtpProtocol.cpp @@ -2261,10 +2261,12 @@ nsSmtpProtocol::GetUsernamePassword(nsACString &aUsername, nsCString hostname; rv = smtpServer->GetHostname(hostname); NS_ENSURE_SUCCESS(rv, rv); + nsAutoString hostnameUTF16; + CopyASCIItoUTF16(hostname, hostnameUTF16); const char16_t *formatStrings[] = { - NS_ConvertASCIItoUTF16(hostname).get(), + hostnameUTF16.get(), nullptr }; |