diff options
author | Moonchild <moonchild@palemoon.org> | 2020-12-26 10:16:55 +0000 |
---|---|---|
committer | Moonchild <moonchild@palemoon.org> | 2020-12-26 10:16:55 +0000 |
commit | ae2a160348562dfa5361f1e68226365b240c9597 (patch) | |
tree | 8c3ee83f8a4b618942d4e215a6937af20d7a66b4 /layout/base | |
parent | 9f004841a248c7c17f536be77d7af67de7b3f39b (diff) | |
download | UXP-ae2a160348562dfa5361f1e68226365b240c9597.tar UXP-ae2a160348562dfa5361f1e68226365b240c9597.tar.gz UXP-ae2a160348562dfa5361f1e68226365b240c9597.tar.lz UXP-ae2a160348562dfa5361f1e68226365b240c9597.tar.xz UXP-ae2a160348562dfa5361f1e68226365b240c9597.zip |
Issue #1053 - Part 2a: Remove android from /layout (partial)
This removes android code from base, build, forms, generic, inspector, style,
printing, tools and xul.
Diffstat (limited to 'layout/base')
-rw-r--r-- | layout/base/AccessibleCaretManager.cpp | 12 | ||||
-rw-r--r-- | layout/base/FrameLayerBuilder.cpp | 4 | ||||
-rw-r--r-- | layout/base/PositionedEventTargeting.cpp | 2 | ||||
-rw-r--r-- | layout/base/ZoomConstraintsClient.cpp | 2 | ||||
-rw-r--r-- | layout/base/crashtests/crashtests.list | 6 | ||||
-rw-r--r-- | layout/base/moz.build | 5 | ||||
-rw-r--r-- | layout/base/nsCSSFrameConstructor.cpp | 6 | ||||
-rw-r--r-- | layout/base/nsDocumentViewer.cpp | 2 | ||||
-rw-r--r-- | layout/base/nsIPresShell.h | 4 | ||||
-rw-r--r-- | layout/base/nsLayoutUtils.cpp | 7 | ||||
-rw-r--r-- | layout/base/nsPresShell.cpp | 42 | ||||
-rw-r--r-- | layout/base/nsPresShell.h | 3 | ||||
-rw-r--r-- | layout/base/tests/chrome/chrome.ini | 1 | ||||
-rw-r--r-- | layout/base/tests/mochitest.ini | 12 | ||||
-rw-r--r-- | layout/base/tests/test_reftests_with_caret.html | 23 |
15 files changed, 17 insertions, 114 deletions
diff --git a/layout/base/AccessibleCaretManager.cpp b/layout/base/AccessibleCaretManager.cpp index ea73a5379..4dd55009c 100644 --- a/layout/base/AccessibleCaretManager.cpp +++ b/layout/base/AccessibleCaretManager.cpp @@ -22,9 +22,6 @@ #include "nsFrameSelection.h" #include "nsGenericHTMLElement.h" #include "nsIHapticFeedback.h" -#ifdef MOZ_WIDGET_ANDROID -#include "nsWindow.h" -#endif namespace mozilla { @@ -896,15 +893,6 @@ AccessibleCaretManager::SetSelectionDragState(bool aState) const if (fs) { fs->SetDragState(aState); } - - // Pin Fennecs DynamicToolbarAnimator in place before/after dragging, - // to avoid co-incident screen scrolling. - #ifdef MOZ_WIDGET_ANDROID - nsIDocument* doc = mPresShell->GetDocument(); - MOZ_ASSERT(doc); - nsIWidget* widget = nsContentUtils::WidgetForDocument(doc); - static_cast<nsWindow*>(widget)->SetSelectionDragState(aState); - #endif } void diff --git a/layout/base/FrameLayerBuilder.cpp b/layout/base/FrameLayerBuilder.cpp index 934d108e0..8695cd650 100644 --- a/layout/base/FrameLayerBuilder.cpp +++ b/layout/base/FrameLayerBuilder.cpp @@ -2502,7 +2502,6 @@ ContainerState::PreparePaintedLayerForUse(PaintedLayer* aLayer, aData->mVisibilityComputedRegion.SetEmpty(); // FIXME: Temporary workaround for bug 681192 and bug 724786. -#ifndef MOZ_WIDGET_ANDROID // Calculate exact position of the top-left of the active scrolled root. // This might not be 0,0 due to the snapping in ScaleToNearestPixels. gfxPoint animatedGeometryRootTopLeft = scaledOffset - ThebesPoint(matrix.GetTranslation()) + mParameters.mOffset; @@ -2515,9 +2514,6 @@ ContainerState::PreparePaintedLayerForUse(PaintedLayer* aLayer, } else if (didResetScrollPositionForLayerPixelAlignment) { aData->mAnimatedGeometryRootPosition = animatedGeometryRootTopLeft; } -#else - Unused << didResetScrollPositionForLayerPixelAlignment; -#endif } #if defined(DEBUG) || defined(MOZ_DUMP_PAINTING) diff --git a/layout/base/PositionedEventTargeting.cpp b/layout/base/PositionedEventTargeting.cpp index 668ff2938..731e951e5 100644 --- a/layout/base/PositionedEventTargeting.cpp +++ b/layout/base/PositionedEventTargeting.cpp @@ -620,8 +620,6 @@ FindFrameTargetedByInputEvent(WidgetGUIEvent* aEvent, PET_LOG("Final target is %p\n", target); // Uncomment this to dump the frame tree to help with debugging. - // Note that dumping the frame tree at the top of the function may flood - // logcat on Android devices and cause the PET_LOGs to get dropped. // aRootFrame->DumpFrameTree(); if (!target || !prefs->mRepositionEventCoords) { diff --git a/layout/base/ZoomConstraintsClient.cpp b/layout/base/ZoomConstraintsClient.cpp index 2391a116d..67666676b 100644 --- a/layout/base/ZoomConstraintsClient.cpp +++ b/layout/base/ZoomConstraintsClient.cpp @@ -53,7 +53,7 @@ GetWidget(nsIPresShell* aShell) return nullptr; } if (nsIFrame* rootFrame = aShell->GetRootFrame()) { -#if defined(MOZ_WIDGET_ANDROID) || defined(MOZ_WIDGET_UIKIT) +#if defined(MOZ_WIDGET_UIKIT) return rootFrame->GetNearestWidget(); #else if (nsView* view = rootFrame->GetView()) { diff --git a/layout/base/crashtests/crashtests.list b/layout/base/crashtests/crashtests.list index 9b09d1c84..1a3bf667b 100644 --- a/layout/base/crashtests/crashtests.list +++ b/layout/base/crashtests/crashtests.list @@ -294,7 +294,7 @@ load 469861-1.xhtml load 469861-2.xhtml load 470851-1.xhtml load 471594-1.xhtml -asserts-if(Android&&!asyncPan,1-2) load 473042.xhtml # bug 1034369 (may also cause a few assertions to be registered on the next test) +load 473042.xhtml # bug 1034369 (may also cause a few assertions to be registered on the next test) asserts(0-5) load 474075.html # bug 847368 load 477333-1.xhtml load 477731-1.html @@ -411,7 +411,7 @@ load 709536-1.xhtml load 722137.html load 725535.html load 727601.html -skip-if(Android) asserts(0-2) pref(dom.disable_open_during_load,false) load 735943.html # the assertion is bug 735966, for android bug 760271 +asserts(0-2) pref(dom.disable_open_during_load,false) load 735943.html # the assertion is bug 735966 asserts(0-2) load 736389-1.xhtml # sometimes the above assertions are delayed and is reported on this test instead load 736924-1.html load 749816-1.html @@ -447,7 +447,7 @@ load 866588.html load 876092.html load 876221.html load 897852.html -asserts(4-6) asserts-if(Android&&!asyncPan,2) load 898913.html # bug 847368 +asserts(4-6) load 898913.html # bug 847368 pref(layers.acceleration.enabled,false) pref(layers.force-active,true) load 919434.html load 926728.html load 930381.html diff --git a/layout/base/moz.build b/layout/base/moz.build index faf421f2e..51cab4c6b 100644 --- a/layout/base/moz.build +++ b/layout/base/moz.build @@ -193,11 +193,6 @@ LOCAL_INCLUDES += [ '/view', ] -if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'android': - LOCAL_INCLUDES += [ - '/widget/android', - ] - FINAL_LIBRARY = 'xul' BROWSER_CHROME_MANIFESTS += ['tests/browser.ini'] diff --git a/layout/base/nsCSSFrameConstructor.cpp b/layout/base/nsCSSFrameConstructor.cpp index 21068b673..45b95826c 100644 --- a/layout/base/nsCSSFrameConstructor.cpp +++ b/layout/base/nsCSSFrameConstructor.cpp @@ -3668,14 +3668,8 @@ nsCSSFrameConstructor::FindInputData(Element* aElement, nsCSSAnonBoxes::buttonContent) }, // TODO: this is temporary until a frame is written: bug 635240. SIMPLE_INT_CREATE(NS_FORM_INPUT_NUMBER, NS_NewNumberControlFrame), -#if defined(MOZ_WIDGET_ANDROID) - // On Android/B2G, date/time input appears as a normal text box. - SIMPLE_INT_CREATE(NS_FORM_INPUT_TIME, NS_NewTextControlFrame), - SIMPLE_INT_CREATE(NS_FORM_INPUT_DATE, NS_NewTextControlFrame), -#else SIMPLE_INT_CREATE(NS_FORM_INPUT_TIME, NS_NewDateTimeControlFrame), SIMPLE_INT_CREATE(NS_FORM_INPUT_DATE, NS_NewDateTimeControlFrame), -#endif // TODO: this is temporary until a frame is written: bug 888320 SIMPLE_INT_CREATE(NS_FORM_INPUT_MONTH, NS_NewTextControlFrame), // TODO: this is temporary until a frame is written: bug 888320 diff --git a/layout/base/nsDocumentViewer.cpp b/layout/base/nsDocumentViewer.cpp index a66a1edac..a0af38c28 100644 --- a/layout/base/nsDocumentViewer.cpp +++ b/layout/base/nsDocumentViewer.cpp @@ -4326,7 +4326,7 @@ nsDocumentViewer::ShouldAttachToTopLevel() if (nsIWidget::UsePuppetWidgets()) return true; -#if defined(XP_WIN) || defined(MOZ_WIDGET_GTK) || defined(MOZ_WIDGET_ANDROID) || defined(MOZ_WIDGET_UIKIT) +#if defined(XP_WIN) || defined(MOZ_WIDGET_GTK) || defined(MOZ_WIDGET_UIKIT) // On windows, in the parent process we also attach, but just to // chrome items nsWindowType winType = mParentWidget->WindowType(); diff --git a/layout/base/nsIPresShell.h b/layout/base/nsIPresShell.h index 5f83b9c15..cf19867ef 100644 --- a/layout/base/nsIPresShell.h +++ b/layout/base/nsIPresShell.h @@ -1711,10 +1711,6 @@ public: void SyncWindowProperties(nsView* aView); -#ifdef ANDROID - virtual nsIDocument* GetTouchEventTargetDocument() = 0; -#endif - protected: friend class nsRefreshDriver; diff --git a/layout/base/nsLayoutUtils.cpp b/layout/base/nsLayoutUtils.cpp index f2d166470..86a11bce9 100644 --- a/layout/base/nsLayoutUtils.cpp +++ b/layout/base/nsLayoutUtils.cpp @@ -911,11 +911,6 @@ ApplyRectMultiplier(nsRect aRect, float aMultiplier) bool nsLayoutUtils::UsesAsyncScrolling(nsIFrame* aFrame) { -#ifdef MOZ_WIDGET_ANDROID - // We always have async scrolling for android - return true; -#endif - return AsyncPanZoomEnabled(aFrame); } @@ -8104,7 +8099,7 @@ UpdateCompositionBoundsForRCDRSF(ParentLayerRect& aCompBounds, return false; } -#if defined(MOZ_WIDGET_ANDROID) || defined(MOZ_WIDGET_UIKIT) +#if defined(MOZ_WIDGET_UIKIT) nsIWidget* widget = rootFrame->GetNearestWidget(); #else nsView* view = rootFrame->GetView(); diff --git a/layout/base/nsPresShell.cpp b/layout/base/nsPresShell.cpp index b1b2671c4..1fb223172 100644 --- a/layout/base/nsPresShell.cpp +++ b/layout/base/nsPresShell.cpp @@ -197,10 +197,6 @@ #include "mozilla/StyleSheetInlines.h" #include "mozilla/dom/ImageTracker.h" -#ifdef ANDROID -#include "nsIDocShellTreeOwner.h" -#endif - #ifdef MOZ_TASK_TRACER #include "GeckoTaskTracer.h" using namespace mozilla::tasktracer; @@ -7287,12 +7283,6 @@ PresShell::HandleEvent(nsIFrame* aFrame, // if the mouse is being captured then retarget the mouse event at the // document that is being captured. retargetEventDoc = capturingContent->GetComposedDoc(); -#ifdef ANDROID - } else if ((aEvent->mClass == eTouchEventClass) || - (aEvent->mClass == eMouseEventClass) || - (aEvent->mClass == eWheelEventClass)) { - retargetEventDoc = GetTouchEventTargetDocument(); -#endif } if (retargetEventDoc) { @@ -7846,38 +7836,6 @@ PresShell::HandleEvent(nsIFrame* aFrame, return rv; } -#ifdef ANDROID -nsIDocument* -PresShell::GetTouchEventTargetDocument() -{ - nsPresContext* context = GetPresContext(); - if (!context || !context->IsRoot()) { - return nullptr; - } - - nsCOMPtr<nsIDocShellTreeItem> shellAsTreeItem = context->GetDocShell(); - if (!shellAsTreeItem) { - return nullptr; - } - - nsCOMPtr<nsIDocShellTreeOwner> owner; - shellAsTreeItem->GetTreeOwner(getter_AddRefs(owner)); - if (!owner) { - return nullptr; - } - - // now get the primary content shell (active tab) - nsCOMPtr<nsIDocShellTreeItem> item; - owner->GetPrimaryContentShell(getter_AddRefs(item)); - nsCOMPtr<nsIDocShell> childDocShell = do_QueryInterface(item); - if (!childDocShell) { - return nullptr; - } - - return childDocShell->GetDocument(); -} -#endif - #ifdef DEBUG void PresShell::ShowEventTargetDebug() diff --git a/layout/base/nsPresShell.h b/layout/base/nsPresShell.h index 80d462551..fbbcfc7ec 100644 --- a/layout/base/nsPresShell.h +++ b/layout/base/nsPresShell.h @@ -755,9 +755,6 @@ protected: virtual void SysColorChanged() override { mPresContext->SysColorChanged(); } virtual void ThemeChanged() override { mPresContext->ThemeChanged(); } virtual void BackingScaleFactorChanged() override { mPresContext->UIResolutionChanged(); } -#ifdef ANDROID - virtual nsIDocument* GetTouchEventTargetDocument() override; -#endif virtual void PausePainting() override; virtual void ResumePainting() override; diff --git a/layout/base/tests/chrome/chrome.ini b/layout/base/tests/chrome/chrome.ini index 2f6ca0ba8..56454d311 100644 --- a/layout/base/tests/chrome/chrome.ini +++ b/layout/base/tests/chrome/chrome.ini @@ -1,5 +1,4 @@ [DEFAULT] -skip-if = os == 'android' support-files = animated.gif blue-32x32.png diff --git a/layout/base/tests/mochitest.ini b/layout/base/tests/mochitest.ini index 405697977..fc616b1ef 100644 --- a/layout/base/tests/mochitest.ini +++ b/layout/base/tests/mochitest.ini @@ -1,6 +1,4 @@ [DEFAULT] -# Android: SLOW_DIRECTORY; -skip-if = toolkit == 'android' support-files = Ahem.ttf border_radius_hit_testing_iframe.html @@ -224,23 +222,18 @@ support-files = file_bug607529.html skip-if = e10s # bug 1020135, nested oop iframes not supported support-files = bug921928_event_target_iframe_apps_oop.html [test_mozPaintCount.html] -skip-if = toolkit == 'android' [test_scroll_event_ordering.html] [test_scroll_selection_into_view.html] support-files=scroll_selection_into_view_window.html [test_scroll_snapping.html] -skip-if = buildapp == 'android' # bug 1041833 [test_scroll_snapping_scrollbars.html] -skip-if = buildapp == 'android' # bug 1041833 [test_bug583889.html] support-files = bug583889_inner1.html bug583889_inner2.html [test_bug582771.html] [test_bug968148.html] support-files = bug968148_inner.html [test_bug603550.html] -skip-if = toolkit == 'android' #TIMED_OUT [test_bug629838.html] -skip-if = toolkit == 'android' [test_bug646757.html] [test_bug718809.html] [test_bug725426.html] @@ -270,13 +263,12 @@ support-files = # because of bug 469208. [test_bug332655-1.html] -skip-if = toolkit == 'android' [test_bug332655-2.html] [test_bug499538-1.html] [test_bug749186.html] [test_bug644768.html] [test_flush_on_paint.html] -skip-if = true || (toolkit == 'android') || (toolkit == "cocoa") # Bug 688128, bug 539356 +skip-if = true || (toolkit == "cocoa") # Bug 688128, bug 539356 [test_getBoxQuads_convertPointRectQuad.html] [test_bug687297.html] support-files = @@ -294,7 +286,7 @@ support-files = bug1080361_inner.html [test_bug1093686.html] support-files = bug1093686_inner.html [test_bug1120705.html] -skip-if = buildapp == 'android' || os == 'mac' || toolkit == 'gtk2' || toolkit == 'gtk3' # android does not have clickable scrollbars, mac does not have scrollbar down and up buttons, gtk may or may not have scrollbar buttons depending on theme +skip-if = os == 'mac' || toolkit == 'gtk2' || toolkit == 'gtk3' # mac does not have scrollbar down and up buttons, gtk may or may not have scrollbar buttons depending on theme [test_bug1153130.html] support-files = bug1153130_inner.html [test_bug1162990.html] diff --git a/layout/base/tests/test_reftests_with_caret.html b/layout/base/tests/test_reftests_with_caret.html index d9b5d4a6c..062c605b9 100644 --- a/layout/base/tests/test_reftests_with_caret.html +++ b/layout/base/tests/test_reftests_with_caret.html @@ -189,20 +189,15 @@ var tests = [ function() {SpecialPowers.pushPrefEnv({'clear': [['layout.accessiblecaret.enabled']]}, nextTest);} , ]; -if (navigator.appVersion.indexOf("Android") == -1 && - SpecialPowers.Services.appinfo.name != "B2G") { - tests.push([ 'bug512295-1.html' , 'bug512295-1-ref.html' ]); - tests.push([ 'bug512295-2.html' , 'bug512295-2-ref.html' ]); - tests.push([ 'bug923376.html' , 'bug923376-ref.html' ]); - tests.push(function() {SpecialPowers.pushPrefEnv({'set': [['layout.css.overflow-clip-box.enabled', true]]}, nextTest);}); - tests.push([ 'bug966992-1.html' , 'bug966992-1-ref.html' ]); - tests.push([ 'bug966992-2.html' , 'bug966992-2-ref.html' ]); - tests.push([ 'bug966992-3.html' , 'bug966992-3-ref.html' ]); - tests.push(function() {SpecialPowers.pushPrefEnv({'clear': [['layout.css.overflow-clip-box.enabled']]}, nextTest);}); - tests.push([ 'bug1258308-1.html' , 'bug1258308-1-ref.html' ]); // maybe VK_END doesn't work on Android? -} else { - is(SpecialPowers.getIntPref("layout.spellcheckDefault"), 0, "Spellcheck should be turned off for this platform or this if..else check removed"); -} +tests.push([ 'bug512295-1.html' , 'bug512295-1-ref.html' ]); +tests.push([ 'bug512295-2.html' , 'bug512295-2-ref.html' ]); +tests.push([ 'bug923376.html' , 'bug923376-ref.html' ]); +tests.push(function() {SpecialPowers.pushPrefEnv({'set': [['layout.css.overflow-clip-box.enabled', true]]}, nextTest);}); +tests.push([ 'bug966992-1.html' , 'bug966992-1-ref.html' ]); +tests.push([ 'bug966992-2.html' , 'bug966992-2-ref.html' ]); +tests.push([ 'bug966992-3.html' , 'bug966992-3-ref.html' ]); +tests.push(function() {SpecialPowers.pushPrefEnv({'clear': [['layout.css.overflow-clip-box.enabled']]}, nextTest);}); +tests.push([ 'bug1258308-1.html' , 'bug1258308-1-ref.html' ]); if (navigator.platform.indexOf("Linux") >= 0 && SpecialPowers.Services.appinfo.name != "B2G") { |