diff options
| author | wolfbeast <mcwerewolf@wolfbeast.com> | 2020-05-10 14:37:50 +0200 |
|---|---|---|
| committer | wolfbeast <mcwerewolf@wolfbeast.com> | 2020-05-10 14:37:50 +0200 |
| commit | 42c1fcaaed006e95699d40019f568e67c749906f (patch) | |
| tree | 8d374dad874048e2b81f61dbf7e0cf23a6671433 /dom/media/webaudio | |
| parent | 8b41800216fc404f016836e18d0da415c618611d (diff) | |
| download | UXP-42c1fcaaed006e95699d40019f568e67c749906f.tar UXP-42c1fcaaed006e95699d40019f568e67c749906f.tar.gz UXP-42c1fcaaed006e95699d40019f568e67c749906f.tar.lz UXP-42c1fcaaed006e95699d40019f568e67c749906f.tar.xz UXP-42c1fcaaed006e95699d40019f568e67c749906f.zip | |
Issue #1589 - Ensure computed length and data is always available
Diffstat (limited to 'dom/media/webaudio')
| -rw-r--r-- | dom/media/webaudio/AudioBuffer.cpp | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/dom/media/webaudio/AudioBuffer.cpp b/dom/media/webaudio/AudioBuffer.cpp index e4252dfcf..39fe8c735 100644 --- a/dom/media/webaudio/AudioBuffer.cpp +++ b/dom/media/webaudio/AudioBuffer.cpp @@ -254,6 +254,9 @@ void AudioBuffer::CopyFromChannel(const Float32Array& aDestination, uint32_t aChannelNumber, uint32_t aStartInChannel, ErrorResult& aRv) { + JS::AutoCheckCannotGC nogc; + aDestination.ComputeLengthAndData(); + uint32_t length = aDestination.Length(); CheckedInt<uint32_t> end = aStartInChannel; end += length; @@ -263,8 +266,6 @@ AudioBuffer::CopyFromChannel(const Float32Array& aDestination, uint32_t aChannel return; } - JS::AutoCheckCannotGC nogc; - aDestination.ComputeLengthAndData(); JSObject* channelArray = mJSChannels[aChannelNumber]; const float* sourceData = nullptr; if (channelArray) { @@ -295,6 +296,9 @@ AudioBuffer::CopyToChannel(JSContext* aJSContext, const Float32Array& aSource, uint32_t aChannelNumber, uint32_t aStartInChannel, ErrorResult& aRv) { + JS::AutoCheckCannotGC nogc; + aSource.ComputeLengthAndData(); + uint32_t length = aSource.Length(); CheckedInt<uint32_t> end = aStartInChannel; end += length; @@ -309,7 +313,6 @@ AudioBuffer::CopyToChannel(JSContext* aJSContext, const Float32Array& aSource, return; } - JS::AutoCheckCannotGC nogc; JSObject* channelArray = mJSChannels[aChannelNumber]; if (JS_GetTypedArrayLength(channelArray) != mLength) { // The array's buffer was detached. @@ -317,7 +320,6 @@ AudioBuffer::CopyToChannel(JSContext* aJSContext, const Float32Array& aSource, return; } - aSource.ComputeLengthAndData(); bool isShared = false; float* channelData = JS_GetFloat32ArrayData(channelArray, &isShared, nogc); // The channelData arrays should all have originated in |