summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorwolfbeast <mcwerewolf@wolfbeast.com>2020-01-14 13:35:03 +0100
committerwolfbeast <mcwerewolf@wolfbeast.com>2020-01-14 13:35:03 +0100
commit4a038e2b4b2485122b1512ce7cee9b6d7efed21c (patch)
tree3342c1f79745d0374357bc74bdbd517f969edbef
parent6d342dbab95e68dd10974e5b71767dfefb0df906 (diff)
downloadUXP-4a038e2b4b2485122b1512ce7cee9b6d7efed21c.tar
UXP-4a038e2b4b2485122b1512ce7cee9b6d7efed21c.tar.gz
UXP-4a038e2b4b2485122b1512ce7cee9b6d7efed21c.tar.lz
UXP-4a038e2b4b2485122b1512ce7cee9b6d7efed21c.tar.xz
UXP-4a038e2b4b2485122b1512ce7cee9b6d7efed21c.zip
Issue #1319 - Disable MOZ_LOGGING in production builds.
This makes it only enabled in debug builds, instead, where logging would be most useful.
-rw-r--r--xpcom/base/Logging.h11
1 files changed, 1 insertions, 10 deletions
diff --git a/xpcom/base/Logging.h b/xpcom/base/Logging.h
index 040fb9c49..765fdf085 100644
--- a/xpcom/base/Logging.h
+++ b/xpcom/base/Logging.h
@@ -22,16 +22,7 @@
// work progresses more functionality will be swapped out in favor of
// mozilla logging implementations.
-// We normally have logging enabled everywhere, but measurements showed that
-// having logging enabled on Android is quite expensive (hundreds of kilobytes
-// for both the format strings for logging and the code to perform all the
-// logging calls). Because retrieving logs from a mobile device is
-// comparatively more difficult for Android than it is for desktop and because
-// desktop machines tend to be less space/bandwidth-constrained than Android
-// devices, we've chosen to leave logging enabled on desktop, but disabled on
-// Android. Given that logging can still be useful for development purposes,
-// however, we leave logging enabled on Android developer builds.
-#if !defined(ANDROID) || !defined(RELEASE_OR_BETA)
+#ifdef DEBUG
#define MOZ_LOGGING_ENABLED 1
#else
#define MOZ_LOGGING_ENABLED 0